From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 267C6FD064D for ; Wed, 11 Mar 2026 07:48:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F59810E36B; Wed, 11 Mar 2026 07:48:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="pKBNhoMq"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 39D1D10E36B for ; Wed, 11 Mar 2026 07:48:39 +0000 (UTC) Received: from [127.0.1.1] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 710DA4B3; Wed, 11 Mar 2026 08:47:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1773215250; bh=nVW9S/l2Hl52QB5XiMXZiTlwBsBsyFGwBfntcehWkCs=; h=From:Subject:Date:To:Cc:From; b=pKBNhoMqxN70hPcFAlUkTTDDHoZrrTi0kf8JapQ7C/3imZDroUxZ7o3RnzozjIrFz z0/2d7bc6t4Goyu0u2ZtSjXhVluA9A9gcc28qESx1VDEeVYa7KD3xcQAG/GH8LaP/r GHdOqojgQz8D0P+HcFm72Zg5aP4W75NuoLTpzIkY= From: Tomi Valkeinen Subject: [PATCH v2 0/7] drm/bridge: tc358768: Long command support Date: Wed, 11 Mar 2026 09:48:11 +0200 Message-Id: <20260311-tc358768-v2-0-e75a99131bd5@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIADsesWkC/23MQQ7CIBCF4as0sxYDNFBw5T1MFxRGOwvBQEM0D XcXu3b5v7x8OxTMhAUuww4ZKxVKsYc8DeBXFx/IKPQGyaUSXAq2+VGZSRtmR1zkqI1dJgf9/sp 4p/dB3ebeK5Ut5c8hV/Fb/yBVMM6Csjx47YTj/koBXUlxSS6Hs09PmFtrX6+SWa+nAAAA X-Change-ID: 20251021-tc358768-93eb23689b7a To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Parth Pancholi , Francesco Dolcini Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tomi Valkeinen , =?utf-8?q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= , Dmitry Osipenko X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2267; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=nVW9S/l2Hl52QB5XiMXZiTlwBsBsyFGwBfntcehWkCs=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBpsR5OCIOdL2M3R/Lr13eYl88oGUqm5mZc4Fqgu LELgRVrKP+JAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCabEeTgAKCRD6PaqMvJYe 9e5DEACpf6FeDc835+3Q4pygrsoAKwk86kEWQVEunedYR31/vx4M6eOmccJF2l+4xzCyShQs/XO v9JipNjEuCYsGY9ScNM36aZyve2e57NXlebYF0zdZsgLU8EHrnsUuK1X4Vl+7bLYFB6feiP/08S 4dFQTOMgv+ZewwX9pJbabcJd5hQHjBe/rklugl6S/XbMqb37ENbFLEO5K4fqrApaEWF65h09Ky9 4BbxRO9T1NUdUhQ1qG7Hdtcj2WDAdh/lfhW8Vdgr6M6niHLxN1DW2fYomKviSHcigK/aNDgkvov ejXJyj8fOirPsqNYej0DSc+5ohQpuRPc47+uyAYYtaP/82OlV8Ky/Z5J1YaocWJSZp1WjuKyfnn aLNwXy4Eb/K5x8EN9uIZUOHV3HLEkrWEXDb/kAeISjEvf7Ymk6MVKDZJx5RCO/MCP1SPiOgbIUW wx/YV+oEI5YTzcKw20CXjn4Gc/buMgtcRYDoTlLMb0cYmQzBBkIIO89/484fwKjf51GQz1V85mu yxciokhmC5QXR5Y0OGRWqT46iLrmZytUXT4qmoUvLoeRCsByBF4w3kv8zCL9dFCyehaLaGnIcdI sj9bgJBPXtwCHuFfpdZtk5KREYAM0lC8NZS2TKAsXsSzICVOIwXMhlk8m0LtYAeguYnXlqn17c9 E3W7QR7Zz+wCDRA== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This series makes some small improvements to the tc358768 driver, and then adds support for long commands, commands that have more than 8 bytes of payload. This has been tested on Toradex Verdin AM62 board, with a ST7703 based DSI panel which requires initial configuration using commands that have 8+ bytes. I tested the following combinations, by observing the panel visually and the DSI lanes with an oscilloscope: - HS command transfer, continuous clock - HS command transfer, non-continuous clock - LP command transfer, continuous clock - LP command transfer, non-continuous clock All except LP + continuous clock work fine. While observing the lanes with normal oscilloscope is a very high level and vague view of what exactly is going on the lanes, it still looks good to me: initial commands are sent in LP, and then video data is being sent in HS, and clock lane is continuous. However, the panel stays black, so something is not quite right. As it doesn't make sense to send commands in LP during initial configuration, especially with longer commands, I will leave that particular combination unresolved. I'd be interested to hear if it works on some other panel. Signed-off-by: Tomi Valkeinen --- Changes in v2: - Add reviewed-by & tested-by tags - Rebase on v7.0-rc2 - Link to v1: https://lore.kernel.org/r/20251021-tc358768-v1-0-d590dc6a1a0c@ideasonboard.com --- Parth Pancholi (1): drm/bridge: tc358768: Set pre_enable_prev_first for reverse order Tomi Valkeinen (6): drm/bridge: tc358768: Fix typo in TC358768_DSI_CONTROL_DIS_MODE drm/bridge: tc358768: Separate indirect register writes drm/bridge: tc358768: Support non-continuous clock drm/bridge: tc358768: Add LP mode command support drm/bridge: tc358768: Separate video format config drm/bridge: tc358768: Add support for long command tx via video buffer drivers/gpu/drm/bridge/tc358768.c | 202 +++++++++++++++++++++++++++++--------- 1 file changed, 157 insertions(+), 45 deletions(-) --- base-commit: 11439c4635edd669ae435eec308f4ab8a0804808 change-id: 20251021-tc358768-93eb23689b7a Best regards, -- Tomi Valkeinen