From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C369AFD88EB for ; Wed, 11 Mar 2026 03:23:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1937E10E7E0; Wed, 11 Mar 2026 03:23:57 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="UF70PI67"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="O9T9H0Vu"; dkim-atps=neutral Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 29CA110E7DF for ; Wed, 11 Mar 2026 03:23:53 +0000 (UTC) Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62ANoJ3n145094 for ; Wed, 11 Mar 2026 03:23:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wJB79bVUZrsbxSexjswx340+SsqpUDunWLmQTkIAkcU=; b=UF70PI673THNW/9y GURpeEGLod+gCEH4KvjdYCxvaNJ7YwIy45zGgKJYqnDqPJcm25OOyadZQNqOCdeT 4mDlGcqPFRzjR+WVXF2MhWM9yev5Rjz4D2Ut/PFA6aIb0gMVFR+buRL2ckN2ukS3 4sj+t1mdW+Udu5iiBJ7DRrSfAnOyNTt6Av0txdm6q486KWFrRHef3EKBC7ZWxZlp n6XPLEVpuXYRtXgvhQN44nAqAVyx8lMdcemdL69Nr1G+fVOgdq59Em+GRRLMF64D I1cY6Mv4woKS0WdklThhgydvQX7DXKYICOYThUR2K/uuJCsFmf4KBq9krYNkLQ3Z XkXN2g== Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctwav8h6m-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 03:23:52 +0000 (GMT) Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-948357563a1so20811348241.1 for ; Tue, 10 Mar 2026 20:23:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773199432; x=1773804232; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wJB79bVUZrsbxSexjswx340+SsqpUDunWLmQTkIAkcU=; b=O9T9H0VuvTVGovNzH9Puj0OvFjM+ktRns3wSSmcB9c8xQfdIpMAJSJSooUF1SINhin tAKjAc9AGU9aHAaFCkvztKJOg7/iO205rXsjZ0qOGtFiNEqSU7mRvZqDBEO2pAM95fHp 2vJuQUXkoWXW4D2Ry8aQgoYSRvc7sV7tLnsc9g8ghjaPnTJoJ2jK7co+N1Q0lMN2mCYt ZuaIwMCb86yQWMjOCUQT1ZMh/RFanb3foVoCnDJcRQcI+24BOv64yKSmerI/CVETrPrJ yTzpu7n91oR+sTCqb6jLyJQc5UOWcJHm6tWIJ7UX4eD2G/Qendm/VR3V2UEK1nECQhk9 NwRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773199432; x=1773804232; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=wJB79bVUZrsbxSexjswx340+SsqpUDunWLmQTkIAkcU=; b=pwYSRhMuPznUSu44KySrSzs/nIpK2+79vbyeFmiD80I5sxgC7g5s3Fbew5JG/T7F3m kgoWTYNnJQM3coSJdJ61GqF7ifUGMWPFNjTjtlzCE+LCDwuR6BXlr6AXVkqD4RQMdAoT 0vaYZ8mT/xu6TZx/YoCJcUXBn2th/lq/Ry3rjQYVXtUcUtQfktEpJY+LuQbU8/5FhPi/ uvBizZRwC8CrRoccnexBx7M3a7UlWFIu0+CfCDq/P5TUd9mIYcjYgWHKV/Yh6nVzpSEF 0CzXxlsCcrun8SD32ryIPHubwLb0axIANHc+6V7nN4jV/d1fw7pfWGc8YRm9B2u1Lawx FN2g== X-Forwarded-Encrypted: i=1; AJvYcCXZ1mGZ7MxzJWm8rzX0T3NQNyw28cVSUX3pIV6PgkAsWLfJ0b/DTyZZQ8MEA57wU4Z7vDe5gm6XIzk=@lists.freedesktop.org X-Gm-Message-State: AOJu0YyUdcsLywE4/L71iaQZ2xPFOb9E9KKUmcBJzN8pAD4GqcQDf965 EPJA7nqT33ZiRwcMCn9ej8NtRJk9zA8P7gQvWEoNDOwVi7qxvy38XjdhC8cj8APXv/1pSazSZ7N xE3rHnLmMvmrUdqSOSLUGdTw0oA/5bftKtAyiMHhc+1LdN25k/H9wDoV+G64rCG3/0kY6LCA= X-Gm-Gg: ATEYQzzP7DfZm6eXfv/Sq7wylN7rvBKsL4pJSqyNn4e/Fz0uH+gFooECZpRCCHg8Wuo Bw87LxHdGTxaziRgOK63gZt7O3vvdoHnpD0o7tG9c6nse1sk1/O4rpnEHjZGxbq2XL78FNj+cRv B2vRNCqdLqPp27HHdfqgVOa+WMQPa8wjJM+3xB5OJx5l0+iU0zIfQSa3S3HNjdiM0dWGjKlSRkr gbF61n9S19uqVav7t/z0sZ650+QsxuIEYWG9a/DLZ8r6JGanvTGFiruQ8Xw9R4rDSxoJEfHllez Hdr6lCkhjPLtdXHTtVp0GNDqDttr8TmnBvMBkDocjGkXYSwu/8AKpspTaleuMPeck4NvLAC+bkw ooiMlXqZFVBUuwZH1OXw6vno8QQQ7AQLISsUPntelVKe04mAZkEBvdPQvJC/Cypd1QUqm1KSSRy 1D890MN6mGx7JAgojEM8bPoNyCvo4Z5FSXzGU= X-Received: by 2002:a05:6102:cc6:b0:5ff:cb2c:a013 with SMTP id ada2fe7eead31-601def2ae84mr377086137.29.1773199431674; Tue, 10 Mar 2026 20:23:51 -0700 (PDT) X-Received: by 2002:a05:6102:cc6:b0:5ff:cb2c:a013 with SMTP id ada2fe7eead31-601def2ae84mr377064137.29.1773199431215; Tue, 10 Mar 2026 20:23:51 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67e5ed41sm1422721fa.25.2026.03.10.20.23.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 20:23:50 -0700 (PDT) From: Dmitry Baryshkov Date: Wed, 11 Mar 2026 05:23:07 +0200 Subject: [PATCH v2 13/25] drm/msm/dpu: use new helper to set ubwc_swizzle MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260311-ubwc-rework-v2-13-69f718f2a1c9@oss.qualcomm.com> References: <20260311-ubwc-rework-v2-0-69f718f2a1c9@oss.qualcomm.com> In-Reply-To: <20260311-ubwc-rework-v2-0-69f718f2a1c9@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1592; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=BQXxAsNkcgoIebP1VAZBuBHx3qvfk0HLeeYsTxoyeyM=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsOAf+MEDFiFXRzUYyYP9Bp3XX7gDytbRI1moX AQYEekYgcKJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabDgHwAKCRCLPIo+Aiko 1V0gB/wIaYDlzH6MS3WkaAX++Av89arWPoM5JKEjyf8PpWgMhvDUDFknGf3vd9NzrlX3iaGJn+V qWxzovrHwKsOd1YPBRz96EsaAXJLgNSYRHHNFretd4UTmTK56YeeEzOCaZZU9T+9xl+cOQV9urE LCPgsCdYAxJniHQaAlKuw9tAU08kYPd8uA4UCf7YInUKdojr/rn7BnrhGC024SQlHc8oJ42SdA2 UwPop7zg7gbA2saFyUT7Jyye2Im0xKc54qLnpulw+UIXm7mhWAPPJYtw6C1J7dTpLp5pUG/iqS4 9WmuJE6UX4oECKee1+anJnj9Aoei58aUeoslAzN7yrlW6nUh X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDAyNiBTYWx0ZWRfX0MHRC6UbDfzx aKHm+sk48I41+M8Yi9etn0rVPCHm5/U5iIRNOQbcNPxSMNYeTqyyTYdnLqxgzZf+ZmWqv1X6au0 4ttwQXjK3T2dWn3lRiMWYdj+YQf8Dt9/e2MwMOkQp8ujC+uaePgKCf7m///oprL7RqdSD4umbb1 2xbpbNCJhBhH+UlfWP26zUKlv6FeqF8DPID/8F/1jKCgnIN5TMkuhEZkv5rJ/3Cri2a+OH+emcE EXPvdkEfEY+rcFPozgzogKdu+BLegwVsOpwjrvYV+j9a2DZGZDFPpHeE7pnQqMXlkfgaxo37faf C5nLwtEdhVOX3+8ItFWWz9lj5JXNETgcEu7LqnbzYrx3zHQBPB3v/BesxH8NtZI9ZdDnF/MkKba E8Q9Acb7+5kHoybyu0d5kpCRgIZUTd6kcukRyGW2v80DQY+OM/F4y1xhz1yQdLk2gomj3lMvnEf EH8GjQvM+Gnt7Zq+0tQ== X-Proofpoint-GUID: FQ7NhEOe_G3vs1yhyDDMRgpXUSt41JAs X-Authority-Analysis: v=2.4 cv=K/Yv3iWI c=1 sm=1 tr=0 ts=69b0e048 cx=c_pps a=UbhLPJ621ZpgOD2l3yZY1w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=46QewcZEoJiMQYndSOUA:9 a=QEXdDO2ut3YA:10 a=TOPH6uDL9cOC6tEoww4z:22 X-Proofpoint-ORIG-GUID: FQ7NhEOe_G3vs1yhyDDMRgpXUSt41JAs X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_05,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 malwarescore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110026 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Use freshly defined helper instead of using the raw value from the database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c index d3da70009234..6089a58074ac 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -318,13 +318,14 @@ void dpu_hw_setup_format_impl(struct dpu_sw_pipe *pipe, const struct msm_format if (ctx->ubwc->ubwc_enc_version == UBWC_1_0) { fast_clear = fmt->alpha_enable ? BIT(31) : 0; - ctrl_val = fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | + ctrl_val = fast_clear | + (qcom_ubwc_swizzle(ctx->ubwc) & UBWC_SWIZZLE_ENABLE_LVL1) | BIT(8) | (hbb << 4); } else if (ctx->ubwc->ubwc_enc_version == UBWC_2_0) { fast_clear = fmt->alpha_enable ? BIT(31) : 0; - ctrl_val = fast_clear | ctx->ubwc->ubwc_swizzle | (hbb << 4); + ctrl_val = fast_clear | qcom_ubwc_swizzle(ctx->ubwc) | (hbb << 4); } else if (ctx->ubwc->ubwc_enc_version == UBWC_3_0) { - ctrl_val = BIT(30) | (ctx->ubwc->ubwc_swizzle) | (hbb << 4); + ctrl_val = BIT(30) | qcom_ubwc_swizzle(ctx->ubwc) | (hbb << 4); } else if (ctx->ubwc->ubwc_enc_version == UBWC_4_0) { ctrl_val = MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30); } else if (ctx->ubwc->ubwc_enc_version <= UBWC_6_0) { -- 2.47.3