From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 859A0FD88EC for ; Wed, 11 Mar 2026 03:23:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E1EBC10E7DF; Wed, 11 Mar 2026 03:23:56 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="GfdsAQCm"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="azUonqSm"; dkim-atps=neutral Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id A829C10E7E1 for ; Wed, 11 Mar 2026 03:23:55 +0000 (UTC) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62AKWSTW1863207 for ; Wed, 11 Mar 2026 03:23:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Q9lDD8STPEjxzwqupY586LWOYSujuCVqRMW1zTbWzsI=; b=GfdsAQCmFnbGynTq Ako71aQ9zFhUJ3uitDr8CZupcre/pjxe1tD12LUJ1Jslw+iR0DZ5tIkrv0fbxvVh 6f7yQcb/gtokYczCnUWr9+MmDfOhhhrTkoLUPP+xHpAD42U8mjYF1PxFxC49Uqf5 Bxuot/g1rxzPDs531JCKU9b+lLd5bp/JuhGNorFgadNY/vjAShS/eU7D7Fw07net ClIdXJZvnNcwy+tSXwndkTIHFL/RMwhVd6xrVJsvGNpkZc/gNusEbmxxjKJW9tHT tApjurGslwGt+ldFWdT3o+I5PI0fHoWX0/iol1tYFsaWC3yRk7w8/0yL8Ff9jGFZ NQxqCw== Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctmw82kac-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 03:23:55 +0000 (GMT) Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-94df16a0801so21941236241.3 for ; Tue, 10 Mar 2026 20:23:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773199434; x=1773804234; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Q9lDD8STPEjxzwqupY586LWOYSujuCVqRMW1zTbWzsI=; b=azUonqSmyM5J6UeUpVEPWu3zev0WSrH5mTLjv08Tu7+Mnh9UFxDLhmqBiH6JuFectp yNdIEGmsC8+oab+R/VAKt+xpuceFTzNF2WrDvhIZ4DF2n5aQ906L9HdfxD7WwsBELPob JzeDDyNw1At6LvJmFpRgvM5zRkGD0HmgwOFUYlCoIelZzPqe9iymckr2O0YVFipxVKi4 ejWOkBR+AkmimP32F+f9wdPHDmap7oWgKaa9Scrmd64iuM1+UTjfEfAHAGB2BS2OcaLR XQMoiOCHbkCk3MYXz6IWmZ/HLYGuJyx8GNgDQfE7YiTaDWEgqfrNmPfeF2aVhGlV5/eS 0Mew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773199434; x=1773804234; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Q9lDD8STPEjxzwqupY586LWOYSujuCVqRMW1zTbWzsI=; b=HMX4pkVmNKBHkR0LlNrGXGvBhTX4+gXbaFdvBfEXxOf7T2XjF2bwG1w7M29oA0rLCl sy2/L9SPVJJsWTBHQf1sgc0Hp0dwk3rLGerkNJzMc55bOIgaxxMWQCrqsXh2dNnTSlUU JEdgEpwMuCNC7VVTFk9hvhdMFJxsEJojyYhMc9ppAEQbmxzro1AJSs44FyghMqBga3gZ RKvyaSFMdJbRK/iMECO9rOsapWIDaFwAw15gD7qzW65LbYAFfIDl2UPq6Kuad8SW4GO/ 77mC8+dgSA9SbrtsqEP+yy53nCtEsHB4o3AwekucVaRkFYTJVlU6Rbw79Wz5Zpd7fAhK yWng== X-Forwarded-Encrypted: i=1; AJvYcCU985s9v7y7F4ZY8yZ2s5skUClwpXjafySsz+irU5Tx0pixU7JWZ5Yo0u9bwyXV4Z6DExqRNXaVss0=@lists.freedesktop.org X-Gm-Message-State: AOJu0YzhqaGV2Hi5a/45Ut6LFNtynKPwkv2M80GJveZx3t298D4D4ePO M1yCufqgCuLzRvYzQeNvCmwAK/OLcKZVmHvYpFEahDfe/KM0Qsr/M5/XL1SYq1kiEFkb5gOVFqB FourvsFxbuzM3I31C3DYZ+zfcLhQwG4Wps6A3XxsKDZ/xOEHmZXPq0N8SM51mNEbM3prAf1Q= X-Gm-Gg: ATEYQzw0yLXysgMPJj8h8FHS4dDpMiR4j2uHt3lLUo4ZMvR6dTuX1+fNEK5w0nLkHo0 oYOUC5rn5SIkxEdqcYd52TbICAs2vX1a6Q5I5CB0ztRUKbrix8x8pbcQG5OIMxtz5jlCRYRz0C+ Rh2LiDDQwLPAjS1Up/W4M5V5TzFPG/gOpDxufHFq4Y5uzbhyAuJ4boePRytvwt5gWCBCPF1upUq dlolvSAMkH5dOfNEorQcqsjLOMSaJ2kbo5Y7JqFar2GlGqLajwTVw74ED4DUj4d8YfFNLa43nd3 3FN0DJTEFHUUkd/gpzD/6xYdf78H+FmuVF5XfL3Es7jikh8Hg+gzESESLHhJGI4Mh/nqM5V+Way qLmY4QJi9jc0SEjTXsteFgDXo23j4kPFyoVONoMllKpGAiiThX4yESK45kfD/JxC4RyVvVXsZNy RR9tIQMaJk3ap7RXpaS50qVIpujOEDhVrYoto= X-Received: by 2002:a05:6102:dcb:b0:5ff:ea98:c2dc with SMTP id ada2fe7eead31-601def73364mr463663137.33.1773199434231; Tue, 10 Mar 2026 20:23:54 -0700 (PDT) X-Received: by 2002:a05:6102:dcb:b0:5ff:ea98:c2dc with SMTP id ada2fe7eead31-601def73364mr463656137.33.1773199433843; Tue, 10 Mar 2026 20:23:53 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67e5ed41sm1422721fa.25.2026.03.10.20.23.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 20:23:51 -0700 (PDT) From: Dmitry Baryshkov Date: Wed, 11 Mar 2026 05:23:08 +0200 Subject: [PATCH v2 14/25] drm/msm/mdss: use new helper to set ubwc_swizzle MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260311-ubwc-rework-v2-14-69f718f2a1c9@oss.qualcomm.com> References: <20260311-ubwc-rework-v2-0-69f718f2a1c9@oss.qualcomm.com> In-Reply-To: <20260311-ubwc-rework-v2-0-69f718f2a1c9@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1997; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=atFJQP9/usuM4FRY4otJIO9yTCLiPPC8icE9Lv+0nTg=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsOAflOdnbVa71oM+AEie4Ga9xWTywVRK8ic9L dD9sQ0/abmJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabDgHwAKCRCLPIo+Aiko 1U3uB/9fT6d32sWGFoD4Ek/GEvHpGp1CYXDPAeXNR9sz279sC1S2DQZX4uDg4yN73Q5ssDyHzrO eH5tYIVyidhdjlwuS26+zRnT5hhW5kw+swCkgpGs7PJ07AzIbRUgQlN7isynM0pNiwrw/+HwMQp b9CzArzhcxRkdWfGKh8lTgnaDa0FFqG1TmijlDjvHIwAHRdCbZ1oegvjR60mC2rGYmDJ+Uqv67T 7BlWGfA4/YvLDK7+djDc1Fmg1s/v8AJSVNGo9ytimbLC8hYkkxfPCYjrRyDv+MDLlqf3Ys+vjFm NxZZnCETVM/HEbOe5i9mtQZhBDO/xc7y58rZNkfP88C15Qtu X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: DYTtKpuMpxW-C1vRmFIqOGJ_V7Ap9bnD X-Proofpoint-GUID: DYTtKpuMpxW-C1vRmFIqOGJ_V7Ap9bnD X-Authority-Analysis: v=2.4 cv=PJECOPqC c=1 sm=1 tr=0 ts=69b0e04b cx=c_pps a=KB4UBwrhAZV1kjiGHFQexw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=lYHGZ8dQhJ3a2aHNycIA:9 a=QEXdDO2ut3YA:10 a=o1xkdb1NAhiiM49bd1HK:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDAyNiBTYWx0ZWRfX2Fdbl8VecGEj EZRB6YP/8B8LdA77Un1QO5sHw1Xi9yxQXMTCDKN/HeB5jh0UloK/MZz2j9zJqLuE3i2+rWSzBKi 2PoKtn+Fg45P9bsABj+eSt9HcAHirKP57KEDZkLjH+9SnWQVmR6LMWYNBWVnvIbMPYGKLj1+L2s UTE/FhBC3KxxMJNmbbOc7MghCuB6TmfCGVi6E6SKJrukzqE1KLpep+gOUuzdI7vehFX0DQlTm1N 1g3Rc6xMs2zOONwqR5o8HrV2Mggc6CYOQTPK6TToUBw+55Kif+156LbpABTRBQLWZsZVSCzxXUp 0PDEtfymT0ME4mopznm0W7x8GocOz5FV2/0xeiwOZTLVmXp8dY5U7rrSWJP+8OL/gNa8GBwarbD a3n/UBVb4Qfs0wwL3Id59wb7MQObRaNIjzpab+3/+I5zVTAxuZvzk7JWozp+nbvgzDcvZ8BYILS WOpYjDD/XhXwDDcGpQQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_05,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 malwarescore=0 spamscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110026 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Use freshly defined helper instead of using the raw value from the database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index c28bdc21fb1e..0b15d725566c 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -169,7 +169,8 @@ static int _msm_mdss_irq_domain_add(struct msm_mdss *msm_mdss) static void msm_mdss_4x_setup_ubwc(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data = msm_mdss->mdss_data; - u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | + u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(qcom_ubwc_swizzle(data) & + UBWC_SWIZZLE_ENABLE_LVL1) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); value |= MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b(data)); @@ -180,7 +181,7 @@ static void msm_mdss_4x_setup_ubwc(struct msm_mdss *msm_mdss) static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data = msm_mdss->mdss_data; - u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | + u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(qcom_ubwc_swizzle(data)) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); if (qcom_ubwc_bank_spread(data)) @@ -200,7 +201,7 @@ static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm_mdss) static void msm_mdss_6x_setup_ubwc(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data = msm_mdss->mdss_data; - u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | + u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(qcom_ubwc_swizzle(data)) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); u32 prediction_mode; -- 2.47.3