From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E8E6FD88EB for ; Wed, 11 Mar 2026 03:23:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B711310E7BE; Wed, 11 Mar 2026 03:23:34 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="fXqgKjRP"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BbrovElu"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0724610E7BE for ; Wed, 11 Mar 2026 03:23:33 +0000 (UTC) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62AKOeHo140361 for ; Wed, 11 Mar 2026 03:23:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sHFCV47opCKmI6D1ocvZj16p1AvAwvvCv03JYIx/BSQ=; b=fXqgKjRPT2g96Sfs PI9kT3cPX4Gb+6E7oUcXUay1CMt3ftGSTzqp4LyViJiQIKoyIRz+gDNaxfryTXPc xQtOTXQYl6JQ0+owetus342XUrGBjJg1QQH1qFgFe5O5ar8HgGR0gho4c7tJfuZk 2HUuX36NeY0Zf9aGYM3seXbpJlg3XXqjGS3GQh+q2GvR/q9ph6OVyG7AHOedJGXy b0Hf9fYKPDD5CLcjFd+9adOUAQiDUGpknarwf3SANBYsGQrn6hLT4o8hY3EgMc5M etzV3BTHbXQbkWxhSEGtSzK6kw0EGLgFf0Mw6PZkDeN/CSHZ6UQbE1JhOgkMwL0k X5dDGA== Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctg1muscx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 03:23:33 +0000 (GMT) Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-9483e4a8662so19159537241.3 for ; Tue, 10 Mar 2026 20:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773199412; x=1773804212; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=sHFCV47opCKmI6D1ocvZj16p1AvAwvvCv03JYIx/BSQ=; b=BbrovEluvWdNAjpc4fHiopUfvEKNRP9+oLp2bG2i4cwP4BXy0cTJ43KDLd/TaofHjq 5CE9k3RG8Hs93mszsCKPAV62J+LpE7Fz3frut+etJ+A1B2MDNbs4XKr/WbIiUHMRkblQ zXlHsCyTqkDYVZPCvWXjlh3KsBOMDQow5YIXLDZufNZv690EZWIAkfUnQzgliFh5u6hG tlMXExAFlvoCdoTRuOm0zoE1FUySd7r9HYcoYSeWh9DWEUAw4bYR5NUgr5DAh2+/8zIL Ltm8oCHlT0n52H9uQFdt+Af0dn+K//X4gSAHmMA8HtY4hn6nO6EXg7zknm0nGwJOFyVb cqhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773199412; x=1773804212; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sHFCV47opCKmI6D1ocvZj16p1AvAwvvCv03JYIx/BSQ=; b=KONknejt9xeIcjyCSyVnYtLHuqOc1atQV30Jp1AJ6qou0/kp5p2KRjzU3wB9rruSoz Ftv6IKYE8CUT6C2y5OVgnR1cExHyGThasAgwJ0L0hKXqOuz1ct6UW3segDAsXHM1DPrM Qt453LiVZLlJP/RvqBy7SKnw5iSfvXvnD4PsKAwlvAPfEe1bVxJHfDmGVx2aphLLIx2c 9rTW/FroMYxqN1ZSxIwNmex3RBcc86ZI50Cr2cAK6O+Go0WI4h2+fch965uk+6mh0aAt ePih6sZMcIsYIySNFnxrAhgUrIJMbqbmI4pQ4LWGIIX9XFOIhkPwfFYld7746TN8Co83 /mNQ== X-Forwarded-Encrypted: i=1; AJvYcCUJSVEXeRoKQ0z0DggyQLuhqfTJg0yaUsjQMBEiImrs1LA364FgjL1TZicJf4GbdOsBOfwV0KWWiRI=@lists.freedesktop.org X-Gm-Message-State: AOJu0YyUArFKk+8zPnQ+MrvIrRkxLNL2kvdMbnGtdYIexnqv92MUIxUT mZHOFFPKXkzzHLdEm6fcqawXj/EbGt72sulmiJPzCi+/DFo1soHqXYtwr4VyRPTBSd7m3syVvof Hv/Uz6wOGFixEXrFdQimuZce+h8v2WNGgoGQ+BJUr2h2oSHVR5WKXSaYlQQWi3WvuLJCqUCY= X-Gm-Gg: ATEYQzyooYpbKOc36FXOPgzXByJZPNDv2rgftc3wBYxxbtLLYn50QN4upuy/vrs6HK5 B+ZQzvSbMphsv2D/lhHg65OmyVSGe+ABMlcsVom1eTkc/DESL8kTGQltjM75km5NL8kpPvq0aia BmA21Q1FCrOZueOSytTYFjkZIEqCkBWJjLJ0MGp2csb+F1oyn3sg31U8FehSoANw0P55VN1WD2o Efe26SpRO3JYv3tusudNSvsJwp98W69h9NGvjLTck9tjkzTlRDGXbTcfsjvAdRzr1ZHfMqyQfKs 6aUzyKqP3bdOzyZrWQNEaPG9sK95ClFiz+Ck82Nm/z68EfqWM/XNd5EY+Q2WY/cVFZzDyHVpnRO vSmtBnVTdDPfIpLva1+1xSLVuZ/NWQJDRxYb9MPoWcdoI5cmylC+cC0ZVX3e6V7DXhnfwwPpcSh TJNvaIQO8m7xL6r9lu58mnQn8Oc7tzAmIgsOw= X-Received: by 2002:a05:6102:3f02:b0:5ff:ea33:2c0 with SMTP id ada2fe7eead31-601def8944cmr439048137.33.1773199412322; Tue, 10 Mar 2026 20:23:32 -0700 (PDT) X-Received: by 2002:a05:6102:3f02:b0:5ff:ea33:2c0 with SMTP id ada2fe7eead31-601def8944cmr439037137.33.1773199411918; Tue, 10 Mar 2026 20:23:31 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67e5ed41sm1422721fa.25.2026.03.10.20.23.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 20:23:30 -0700 (PDT) From: Dmitry Baryshkov Date: Wed, 11 Mar 2026 05:22:59 +0200 Subject: [PATCH v2 05/25] drm/msm/adreno: use qcom_ubwc_version_tag() helper MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260311-ubwc-rework-v2-5-69f718f2a1c9@oss.qualcomm.com> References: <20260311-ubwc-rework-v2-0-69f718f2a1c9@oss.qualcomm.com> In-Reply-To: <20260311-ubwc-rework-v2-0-69f718f2a1c9@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1565; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=DQjdkhkQRL9h9cv0XC/AXKUXCFPEB+rX9LBo0dUvSGs=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsOAdgfYeu6GQDLEeuxccJ1k6HQX8RtzGU0npY 98s/E/1KTKJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabDgHQAKCRCLPIo+Aiko 1UIaCACkHLHsytPdk4DlFH6siwOBvarPpL59dCFFX5HO2jq6Gdn72E8+dIRpPcDMqqpAR5A44Sh 55f8l8+skl4IZDAQI4t3yiIAxrtiop3WDdDR27xOIV7+FtPRjBRKnmGMx4GYRpcOVAnJ351Dv2y cpZ5eCDfVU2AK7z0WR8gxwqO/QZnMNtWpzV6pRnZYkq7MNUFAeEBv/iRlal86F1fcB/NMnZLZ8L o04ysuS5qWT+baJFgON9493TQKzXw8NNvtC7z96K42oVOzQA5W02pdMHka6LRNPlBT/W8pjr0WI kqONI03oJvq1hsx8KbUxL97kpKiJLVkx/Yf2NX9GP0GefK7o X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=YOeSCBGx c=1 sm=1 tr=0 ts=69b0e035 cx=c_pps a=KB4UBwrhAZV1kjiGHFQexw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=xoTxleRWwXRO4XdZWWkA:9 a=QEXdDO2ut3YA:10 a=o1xkdb1NAhiiM49bd1HK:22 X-Proofpoint-ORIG-GUID: aInRA2QT82ZaKDW0xjx65JkATEYrX-OR X-Proofpoint-GUID: aInRA2QT82ZaKDW0xjx65JkATEYrX-OR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDAyNiBTYWx0ZWRfX+C5IP21YjgIC dDWsrqQ+NtDdvYxPbBtBAHrCQdhQlWfvvmEcC/XRHt1f4mZuGlJ9vxrOnmrTcfNF2H4N9C+XltC 0iUjYaoT15b3vQxSzQjMFnCSkpxqTg7R1AUcm6REu6d3lj4her6F5ebgrXxKlzcHxCq5RgRPuP4 AoJewZ6VdO1zOarMCtf2NRRHMFF2XkPeeVVzsOJiDV1lT/pLPDjZhrqST16yumH10frLMU6I0lS w8I1ZcQG0Vb7NqQQx4iVajCB5tyrIrZb+5W+lmsbC46i9GJenfP3NXEFe96VuP5wWaB34o3S2Hx l3MJgcx8m0XFV+WQ5ULdIZd2qzoqChkNWLn7sfy1esWzqtJI8Erph+HPR7PunqJBjKwBWrzd3Am DuC973CsoqjdS9jwBneHjnfyZ+Z90SItmGvUtNqCcVHxceGkjuF2MEoCiDaFUDcBEax8/t5Adx9 NCaTmfmDNdmcKL/rNCw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_05,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 spamscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 phishscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110026 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Use new helper defined to program UBWC version to the hardware. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c index b1887e0cf698..6dc1d81fcaeb 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -272,35 +272,33 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) bool rgb565_predicator = false, amsbc = false; bool ubwc_mode = qcom_ubwc_get_ubwc_mode(cfg); u32 ubwc_version = cfg->ubwc_enc_version; - u32 hbb, hbb_hi, hbb_lo, mode = 1; + u32 hbb, hbb_hi, hbb_lo, mode; u8 uavflagprd_inv = 2; switch (ubwc_version) { case UBWC_6_0: yuvnotcomptofc = true; - mode = 5; break; case UBWC_5_0: amsbc = true; rgb565_predicator = true; - mode = 4; break; case UBWC_4_0: amsbc = true; rgb565_predicator = true; fp16compoptdis = true; rgba8888_lossless = true; - mode = 2; break; case UBWC_3_0: amsbc = true; - mode = 1; break; default: dev_err(&gpu->pdev->dev, "Unknown UBWC version: 0x%x\n", ubwc_version); break; } + mode = qcom_ubwc_version_tag(cfg); + /* * We subtract 13 from the highest bank bit (13 is the minimum value * allowed by hw) and write the lowest two bits of the remaining value -- 2.47.3