From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 961B8FD88EB for ; Wed, 11 Mar 2026 03:23:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EC0F410E7CB; Wed, 11 Mar 2026 03:23:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="cgNMVsZx"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Lp5ARX4d"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 02BE710E7C9 for ; Wed, 11 Mar 2026 03:23:37 +0000 (UTC) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62B2o9w21572935 for ; Wed, 11 Mar 2026 03:23:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tABjXUq/OjxQFlltJI7qwEI7Ulj0yf3Q34M6i0RzZsQ=; b=cgNMVsZxErBUR+FZ T+qVtr9b1dx2619MlUbmEGH719FcC3bq4a7gXH/wghH2uqcnucunxcL5FQBj85uj qt5VCGLaj5pFGn8oSc+zw1txQNzJR3hnuVRQCsgne79V54Ht5sdkwk8xChgOk5a8 5HqAltakLkzPXQiWfY7CdevljZHAhD1QPuG8hyNiYivDGDUgsc9nHTeI2kwTR3b1 DO7BBDNvefVyE7XtZ8Q7fUfWsVH0L60GG5hOullhyYvq8FgWxlPBfVpsNNRbtUoM 3w4Rqr+ulovv2HFoeC7ejdoD9JjhVRkPZ4HedC3/8VAe9yM2+B9VcTjM/w+mY6AM jEPi6Q== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctqgk9r9x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 03:23:37 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-5ffaa511969so7624276137.1 for ; Tue, 10 Mar 2026 20:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773199416; x=1773804216; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tABjXUq/OjxQFlltJI7qwEI7Ulj0yf3Q34M6i0RzZsQ=; b=Lp5ARX4dzRc0zlAaKpTlxlzs/CmG87uotMPRk8pbYmLE6uNlRbqIZzMkB33uSNtQNr qT6PFY24+8O62WBlB7cSiILyCg6tBjzBQdXNJ27ynXNj8c7mjTiSHk4JiT1KKp6fKFIw RHjmb7SzlKt4DxSiQHHbZxBsx9N1MRSRguG1fORgH8i445FSco/LaQUGHOOQ3v7pGy4X nOeC2fDB9BMACYY1ZZeMkEAkwMSOuulFeoo+m2s1wxlomY7mBZaKrBkXmnICRVIoYQZC n/uaIARS+5oPObqIdKyDjSS8pxSZzX0p0ptqs2Fm0PWnPRpCyXAYO0vA8X27lD/resX3 byXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773199416; x=1773804216; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=tABjXUq/OjxQFlltJI7qwEI7Ulj0yf3Q34M6i0RzZsQ=; b=XdkYrGWCTxpAbvJKnIoEHAeeBWydzuNHfyd/xO0aHCIWU7Im/Xnwl/sRLO9fIQhtE+ jV/RB4w/8Cr/pHqLCNxbUDaP/nKxgzxEhz16qsLXahddxB+D5t3onRHHujQfBLeYnU0o 49kuwnReROFq+ElYzamX+TKdkCBI2BuuGKMHbLDm5ignDVg9FGj05EwiEedVWLEXLD9v TZ/g68m7R/z3lufJk36ULgvKxex3gqr6rpfifhH2nA/SIDDc2rKASiHF4YkLjYx/7Eha nJ2/Tkun9T9UR5G9JVzPrLZchwVBWKsGdxOjmj/bv0FXSj6E1uxWIbieJz8Gj9JBlQka x2Fg== X-Forwarded-Encrypted: i=1; AJvYcCUAL+EEsmiEoojVRSVNe791tQVwkf5G1ZcZzMM9kr+9kD1SKPhrqrK/OuA4cZL/AhlR8yKy9pz0vN4=@lists.freedesktop.org X-Gm-Message-State: AOJu0YxqraC5DYlOkmeqx84sRg0eFpQkY8xSc0lZxeZ+dgmYWiw1pb8l 5Vb8SAX2vldo5DUiPJq8S1YHOeDPLQ4gJrWyc9AgnX8CxQs4hAmF0O5ePiKoJhjRUFyAk5nlwmX ENF2yhaQSwxQKjDuf7Jj5Rb/9+t7pZBChrmRcxFxKn+TkojC7KL2ise52GV+zM3tK+d9MwfI= X-Gm-Gg: ATEYQzwWY0845DKXSAaIQDLR1P0JzVc5GyhlU88optV+auLrX0YpPgJTrk2ctpA+stb weTz0u/5rIDiF3cD9Odj/G2q9tYVFlla85OlpiABapkDbmnef/NVniNrwXYK7ChXN7jTy5lFRVt 2zDcOtzsEd3gOkRiQAIyaRufWz/FDSESIMedXazmckTwimlcx43TJBjM5m9fFzVLB9RMfW0AFIz dJ9uQRZjjk5CFhbcHVF3fYsimFKIWeoWEWHa+nVArxmGlJnazYfOfrsLRst7lt0hVe/tv74sVE9 hOKfpgKQuzmtqmXsjQdp8tfXETj3rU/5ih8zrZl54yI6QbHm73ezLP8jdcb591tikgezYwK9EjH rs3N6fPSYMJCGhsNGnQDYiz7fhFMSyEjh9xFa8ONqn4dOjkOfFy3zQ6iAZX0qUvTrvpH0+YguIA abK9tm57wiof0FDtP8WeR78x4mRucGbPbkOnk= X-Received: by 2002:a05:6102:5491:b0:5fd:f8d6:e5d3 with SMTP id ada2fe7eead31-601deb93545mr402765137.10.1773199416517; Tue, 10 Mar 2026 20:23:36 -0700 (PDT) X-Received: by 2002:a05:6102:5491:b0:5fd:f8d6:e5d3 with SMTP id ada2fe7eead31-601deb93545mr402760137.10.1773199416080; Tue, 10 Mar 2026 20:23:36 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67e5ed41sm1422721fa.25.2026.03.10.20.23.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 20:23:33 -0700 (PDT) From: Dmitry Baryshkov Date: Wed, 11 Mar 2026 05:23:01 +0200 Subject: [PATCH v2 07/25] drm/msm/adreno: use new helper to set min_acc length MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260311-ubwc-rework-v2-7-69f718f2a1c9@oss.qualcomm.com> References: <20260311-ubwc-rework-v2-0-69f718f2a1c9@oss.qualcomm.com> In-Reply-To: <20260311-ubwc-rework-v2-0-69f718f2a1c9@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1349; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=vcRHbEAGLYLgXe4iaZftIzhetGkuS44tvnfyt/ZXY1c=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsOAeO4nElIJcpuyqbvQC62M0/OONI27Dtl7Qg uWcvp4x3wqJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabDgHgAKCRCLPIo+Aiko 1X0kB/wJwyuj+XLI2LEBuuKOWUFkxdi8dLenQPx9p5GvUg/qDaDdI3lJrLI0e6dSH/jM7X43NqF vp97cFEvLGZdiP3JIxQWRXV2Vx2mfcZFE2kVgMAnTrq+OfY+8JohGMZkZjYr/L9djyw8E1rdKlw yOSoBZswqU9MR5MQClsZ3qzhz3EmHuxs4D5M8X8ns76JoRBasuj31BzzW3Fwc6O3oH4N0k8gvLv 81GxHCtnumJZl6va1/kqsxDwY+ZnfwAxOg93USVQ9uBO6gHK1Feq7AP/PXU0fNSt0g4Hv5KY5bn 5S9ZAOi7sOp/QBdnF5CKnUZFeckHk5s8kT+I4m++nWpdeefC X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: rQs-rmRsqWMfTxQj4aIaQFhqkjO59ANc X-Proofpoint-ORIG-GUID: rQs-rmRsqWMfTxQj4aIaQFhqkjO59ANc X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDAyNiBTYWx0ZWRfX7i6tug6CC2Bl CrIiGBdfx1tYjyKf0R0bey/sL8QZaLilhU89aLFLEY+cbPJVx5LzzjVc5Y1Daos1gusqIaZYNSt 3tJMZRzVKim68qVlxK8nYEwCqSI+YTXVelkyCA5qWJC3+HqZA9mMFtRBWh5grvVT07E1y378ay2 pmPy/aKasrc7P/UDi0yMIdgmUWiyKPioC7PMb3APjnRZLZCp/6q4j6wMQDQ8m7ZfR9gsWfrg5Rs L67eoozRLE6DL/s2+TbmqEuoECMTZ5EaP83EE5/+1X4DtuK/igjfE6HLsR171agBdjbeDV8Ec8k eWzXF3D45uwtVu2J7B0tS5JPn4YBnXQQQYVLZ+z3FMjP/lGi/Sqz3DurpOIhBwadrwR2vGc8MS9 PYH6FRbxHAb1PbSzT7osQhJ8iYrbMRz1qae3CoFXx0v+pASg5H5dcU8pqo8PfGsCylxWgQPCATZ V8FSVEJ482ETfMxED7Q== X-Authority-Analysis: v=2.4 cv=M4JA6iws c=1 sm=1 tr=0 ts=69b0e039 cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=X-e67srwgh_QgMMAbO4A:9 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_05,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 adultscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110026 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Use freshly defined helper instead of hardcoding the checks in the driver. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index 6eca7888013b..2027e479d5b1 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -744,7 +744,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) u32 level2_swizzling_dis = !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LVL2); bool ubwc_mode = qcom_ubwc_get_ubwc_mode(cfg); bool amsbc = cfg->ubwc_enc_version >= UBWC_3_0; - bool min_acc_len_64b = false; + bool min_acc_len_64b; u8 uavflagprd_inv = 0; u32 hbb_hi = hbb >> 2; u32 hbb_lo = hbb & 3; @@ -752,8 +752,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) if (adreno_is_a650_family(adreno_gpu) || adreno_is_a7xx(adreno_gpu)) uavflagprd_inv = 2; - if (adreno_is_a610(adreno_gpu) || adreno_is_a702(adreno_gpu)) - min_acc_len_64b = true; + min_acc_len_64b = qcom_ubwc_min_acc_length_64b(cfg); gpu_write(gpu, REG_A6XX_RB_NC_MODE_CNTL, level2_swizzling_dis << 12 | -- 2.47.3