From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4CEE6FD88EB for ; Wed, 11 Mar 2026 03:23:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 804E210E7D0; Wed, 11 Mar 2026 03:23:44 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="ktVzbtwt"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EOp5RWn5"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id CB8AA10E7CA for ; Wed, 11 Mar 2026 03:23:40 +0000 (UTC) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62AInbgF3417119 for ; Wed, 11 Mar 2026 03:23:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uPjlYcDhTlo5kJobBmeD1ArJXAfI/y95Lr5sjDuhNbk=; b=ktVzbtwtF7q2sBan 9EdHyU1rhjDMZlha42Z0+SV+I/VvkRH37rUhoOtfb0WO6J1FEq0dsuZrgkxtXReY UZV5dd2RGM534YCuKYcNtGnDGzh++gMVJt8m1kyqab0LbJItggR+Lx+1AH+6yaxb S/L9O7VEU9t5gSl2gUYK3IpM9hQfpO4BlUQ+3RKgz1tUMhOxZm226XKg41j7vFy1 eKTueA+Lol4Di5lhe8obyjan0TX3aD9RVqzszIAvdkMv3omCDWXifaYckGlX+8UR yt6AkTDtG7qzo/RBx/tzPxXd9nyAtTGOf9DdW4AH4j+gOmxqYQ00wNekZXIBEeTn 8lKeew== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctja2b61p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 03:23:39 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-5ffbbf0e3easo7445703137.2 for ; Tue, 10 Mar 2026 20:23:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773199419; x=1773804219; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uPjlYcDhTlo5kJobBmeD1ArJXAfI/y95Lr5sjDuhNbk=; b=EOp5RWn5LXo+q4JZ5nrPSZzsn54E/V9UKoAAFO/sFXXN0YcJr00gQ4qabOoWVIILeX 3sA4Rhkz19wByFxvvpnsmP568sajlz/lFB3tN+2dk4rPtwuPTJxh/2g5kwZ9GzigyPhN WsdjYsbRkmudYgo5J1Amb1T0AwMX7qMAZsPbMTx0+QFdUNaMkClbA9vx44hZbGbcWXRF i2eni9MsZhKocWF5nfNH34SQqocmFLYOim1oYlJz0gnyD9+Y4PrL/eckHpElfAuVoXxw 1NCn3AvbOzepumrKDkz+5roV9BeJ8I6UP7ca53SpJf61oeTjzTkgXC5BVuESnanxJcz6 4FTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773199419; x=1773804219; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=uPjlYcDhTlo5kJobBmeD1ArJXAfI/y95Lr5sjDuhNbk=; b=gAyD1YhDaScunz4wPg6JaI82LySJCylkgIZLpq3BxgjDMOdeC7ndVHAzJicQBjSS6y V27yPtN7942ZayJlSP5Bjn3p9hdE4YQk701USrq9P4ZurlFiZQTM+IVKa1w6T4Wth4pc WoL8F8tpjB6M77C/OKaSFbQCOHOSzk7KK1M43pEz2iBcsoWBhDXve1ZH5hwSxaINso/N NIo8CtcF7ZVsU9mkgIqYcwqxMdSSHIVEFxuzBxKpWk3OnhChtFOlj8jVZlhfn8UuBX2K rY/0tCB8ncM2Zf5rH4VjY6VvIglWYLZBaksZlSOiZgr1Qn1GWkFhEyCe6xmvpGq8iWzE +j7Q== X-Forwarded-Encrypted: i=1; AJvYcCUm7fsoJ7jEAfm+VcwM9V6dAJ3imKV3PcM2rKVd4bwof82clMP/H//PVZ1c5SPNNmHcXaPxL/tNutg=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yxrf4y8omHxfdg7287IQkfJIGG9HIbDhPH+D6Ut8K0dRxBte0UQ 1vzPver/NrzVhV7HbpdLKAsRf1E9q/zNY68ssRDICT0wri3AKM4v7h/Ov9KXuwhSPHB7FoLPPcL O0DgzdU5gn3lTsBVdsw6HVhAk1L1nrL9n+TMZRAdJJxRiW2NbZtYwx6oqlnODpD0ALmZ6WUI= X-Gm-Gg: ATEYQzx3jFWs6bVfWBlZkoCfuZOpdVCIXdkxEFNUMkj4BXl1gvIJqS15+1T/+O+S253 Oor+koZOcpYXD1EK1UYx/zGz0L25O31ucj084tR27zG9lEsg/2dryStVSkq/11bQZHguokJRSiG vWACXyt82v72KzX8AWCqUSG1FaCjNKOsSU/2VBqL8qAFN+6CGHRzVXigXP40r528hSxbG4xv1Ci rPB5jYdxuJDk9J+omwPmuKxZ+62ZxTC1lWa/ongzRD+F3FQzs4PPQkdfIzumDYRMzWvGJ6/WPhp Me6kNY7e8iCiF3nqyEPan6Y23kIYmm91G54axZetRcH+ykgpRoBfF6fRA5UkMfzRN7ibv3IpJkl EJwd0OqPER3ufs8Xb2OkRYGS/+C8btHwXVVjySc7nRh7ExajJWkTwpbjZRPSaFEGpQ2ELO1vuq6 YAqvTz2w+lcfRn3kf/YH17ApWAaYrsqiGVGf4= X-Received: by 2002:a05:6102:dc8:b0:5ff:172c:2d96 with SMTP id ada2fe7eead31-601deb20514mr426648137.3.1773199419227; Tue, 10 Mar 2026 20:23:39 -0700 (PDT) X-Received: by 2002:a05:6102:dc8:b0:5ff:172c:2d96 with SMTP id ada2fe7eead31-601deb20514mr426628137.3.1773199418778; Tue, 10 Mar 2026 20:23:38 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67e5ed41sm1422721fa.25.2026.03.10.20.23.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 20:23:36 -0700 (PDT) From: Dmitry Baryshkov Date: Wed, 11 Mar 2026 05:23:02 +0200 Subject: [PATCH v2 08/25] drm/msm/mdss: use new helper to set min_acc length MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260311-ubwc-rework-v2-8-69f718f2a1c9@oss.qualcomm.com> References: <20260311-ubwc-rework-v2-0-69f718f2a1c9@oss.qualcomm.com> In-Reply-To: <20260311-ubwc-rework-v2-0-69f718f2a1c9@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1420; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=Mo2e5asKPI5xpZsCjnNf0ROQpEF4U0WKdwGGP3IBoTc=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsOAe5uYcfbPSgL2H//BPLqal0DXFxZ43VPoW5 a8Tb4BB9rOJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabDgHgAKCRCLPIo+Aiko 1XCcCACKtqmULG8LMHRj/2pUtR2naMjTqEtRo0nHjZ21AchJ5RiEStTNpjUq4XT8Cq8JBxhmbnz EifCb6Zt+K4E+rFIGvAInS1QYyNu/tSRULdkMPBWPD/mwjHScGAasPBcgPQ2wkBy6xUpvO16dch HRebfaYz4AFZWxnQ8OkTOyDiZTzYnoKDNSbp90ssQXzl2dF2/Lp0XNTJpXtYk7Qw9D4CK+vSHlt bWZQqwZPoQCVKRXt7RnLcwWL0aqU7PVGgF2cE7gfKu2mdew7XmDzUt11b5O3LOCieGpMgH7Buzp YQ3W1CJPvxx9OvCM9fCqL5zzMy2Jb/tajk8cQaDk3R9DwNw+ X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=c9WmgB9l c=1 sm=1 tr=0 ts=69b0e03b cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=pH-95HYbptEkGMIaxFMA:9 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-ORIG-GUID: qYVyemMJQXP8FZxPy9kS7Jcv71ixLky- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDAyNiBTYWx0ZWRfX6NViB8DGkT39 aJp5pA4aWnLpJTjNvl86xTLY/wlix0BIyUj2voqCL9BkYO+flmrYFs1bLnrYMdynD4ddRFHGAT/ MuLc5oPDE4NoXsZ4yjA3VRLdxC5E0rFIeoyboWv/j5/F/K4IFI0BOm/hLD5Ha3qKxM/+Z0LRLw2 VIYk+BaAiZKccbiK4va+USSDb9gMfUHcSb4K+NJPK0tO49Xr3l2vQjni1bXtQ4lE/af+K3QpSjv aib7PPZNuDNBDD8dlbzIHB3WF9nYBi1Fuaj7+uxdj+WJEtUBo92cNp0mW/ZUYn4rK31d/Q5vksN XMkDkrUl048GrqtQ+2/cvc9DAKzrH40DSUf/77yHBm9sXJnsyS+6ZHTYGo7JDI3MvfYg8GStgVc XtJh6nRjoxP0dlB5EGxUb/nZM42PLUV57IcMP7+JhUYMxRqzO7QQqq8BC6ehULXNi/JL5V/KnaL A2K8cv0/2IFOeevnA2Q== X-Proofpoint-GUID: qYVyemMJQXP8FZxPy9kS7Jcv71ixLky- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_05,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 clxscore=1015 impostorscore=0 phishscore=0 bulkscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110026 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Use freshly defined helper instead of hardcoding the checks in the driver. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 497db0ce28bd..49ad1a9bac23 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -172,8 +172,7 @@ static void msm_mdss_4x_setup_ubwc(struct msm_mdss *msm_mdss) u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); - if (data->ubwc_enc_version == UBWC_1_0) - value |= MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); + value |= MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b(data)); writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); } @@ -193,8 +192,7 @@ static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm_mdss) if (data->ubwc_enc_version == UBWC_3_0) value |= MDSS_UBWC_STATIC_UBWC_AMSBC; - if (data->ubwc_enc_version == UBWC_1_0) - value |= MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); + value |= MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b(data)); writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); } -- 2.47.3