public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] MAINTAINERS: adjust file entry in GPU BUDDY ALLOCATOR
@ 2026-03-11  4:33 Lukas Bulwahn
  2026-03-11  6:25 ` Joel Fernandes
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Lukas Bulwahn @ 2026-03-11  4:33 UTC (permalink / raw)
  To: Joel Fernandes, Dave Airlie, Matthew Auld, Arun Pravin,
	Christian Koenig, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel
  Cc: kernel-janitors, linux-kernel, Lukas Bulwahn

From: Lukas Bulwahn <lukas.bulwahn@redhat.com>

The commit 4a9671a03f2b ("gpu: Move DRM buddy allocator one level up (part
one)") and commit ba110db8e1bc ("gpu: Move DRM buddy allocator one level up
(part two)") split the majority of the file drivers/gpu/drm/drm_buddy.c
into drivers/gpu/buddy.c, with some pieces remaining in the original
location drivers/gpu/drm/drm_buddy.c.

The commits also adjust the file entries in the GPU BUDDY ALLOCATOR
section, but as part of that, change the file entry to the non-existing
file drivers/gpu/drm_buddy.c instead of keeping the reference to the
existing file drivers/gpu/drm/drm_buddy.c.

Make the file entry in GPU BUDDY ALLOCATOR refer to the intended existing
file. While at it, order the file entries in this section alphabetically.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
---
 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index fe2a6e548169..c847d05e6c27 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8946,11 +8946,11 @@ R:	Christian Koenig <christian.koenig@amd.com>
 L:	dri-devel@lists.freedesktop.org
 S:	Maintained
 T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
-F:	drivers/gpu/drm_buddy.c
 F:	drivers/gpu/buddy.c
+F:	drivers/gpu/drm/drm_buddy.c
 F:	drivers/gpu/tests/gpu_buddy_test.c
-F:	include/linux/gpu_buddy.h
 F:	include/drm/drm_buddy.h
+F:	include/linux/gpu_buddy.h
 
 DRM AUTOMATED TESTING
 M:	Helen Koike <helen.fornazier@gmail.com>
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] MAINTAINERS: adjust file entry in GPU BUDDY ALLOCATOR
  2026-03-11  4:33 [PATCH] MAINTAINERS: adjust file entry in GPU BUDDY ALLOCATOR Lukas Bulwahn
@ 2026-03-11  6:25 ` Joel Fernandes
  2026-03-11  6:31 ` Arunpravin Paneer Selvam
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Joel Fernandes @ 2026-03-11  6:25 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: Dave Airlie, Matthew Auld, Arun Pravin, Christian Koenig,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
	Simona Vetter, dri-devel, kernel-janitors, linux-kernel

On Wed, 11 Mar 2026, Lukas Bulwahn wrote:
> The commit 4a9671a03f2b ("gpu: Move DRM buddy allocator one level up (part
> one)") and commit ba110db8e1bc ("gpu: Move DRM buddy allocator one level up
> (part two)") split the majority of the file drivers/gpu/drm/drm_buddy.c
> into drivers/gpu/buddy.c, with some pieces remaining in the original
> location drivers/gpu/drm/drm_buddy.c.
>
> The commits also adjust the file entries in the GPU BUDDY ALLOCATOR
> section, but as part of that, change the file entry to the non-existing
> file drivers/gpu/drm_buddy.c instead of keeping the reference to the
> existing file drivers/gpu/drm/drm_buddy.c.
>
> Make the file entry in GPU BUDDY ALLOCATOR refer to the intended existing
> file. While at it, order the file entries in this section alphabetically.

Reviewed-by: Joel Fernandes <joelagnelf@nvidia.com>

-- 
Joel Fernandes

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] MAINTAINERS: adjust file entry in GPU BUDDY ALLOCATOR
  2026-03-11  4:33 [PATCH] MAINTAINERS: adjust file entry in GPU BUDDY ALLOCATOR Lukas Bulwahn
  2026-03-11  6:25 ` Joel Fernandes
@ 2026-03-11  6:31 ` Arunpravin Paneer Selvam
  2026-03-11  7:58 ` Maxime Ripard
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Arunpravin Paneer Selvam @ 2026-03-11  6:31 UTC (permalink / raw)
  To: Lukas Bulwahn, Joel Fernandes, Dave Airlie, Matthew Auld,
	Christian Koenig, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel
  Cc: kernel-janitors, linux-kernel, Lukas Bulwahn

Reviewed-by: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>

On 3/11/2026 10:03 AM, Lukas Bulwahn wrote:
> From: Lukas Bulwahn <lukas.bulwahn@redhat.com>
>
> The commit 4a9671a03f2b ("gpu: Move DRM buddy allocator one level up (part
> one)") and commit ba110db8e1bc ("gpu: Move DRM buddy allocator one level up
> (part two)") split the majority of the file drivers/gpu/drm/drm_buddy.c
> into drivers/gpu/buddy.c, with some pieces remaining in the original
> location drivers/gpu/drm/drm_buddy.c.
>
> The commits also adjust the file entries in the GPU BUDDY ALLOCATOR
> section, but as part of that, change the file entry to the non-existing
> file drivers/gpu/drm_buddy.c instead of keeping the reference to the
> existing file drivers/gpu/drm/drm_buddy.c.
>
> Make the file entry in GPU BUDDY ALLOCATOR refer to the intended existing
> file. While at it, order the file entries in this section alphabetically.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
> ---
>   MAINTAINERS | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fe2a6e548169..c847d05e6c27 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8946,11 +8946,11 @@ R:	Christian Koenig <christian.koenig@amd.com>
>   L:	dri-devel@lists.freedesktop.org
>   S:	Maintained
>   T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
> -F:	drivers/gpu/drm_buddy.c
>   F:	drivers/gpu/buddy.c
> +F:	drivers/gpu/drm/drm_buddy.c
>   F:	drivers/gpu/tests/gpu_buddy_test.c
> -F:	include/linux/gpu_buddy.h
>   F:	include/drm/drm_buddy.h
> +F:	include/linux/gpu_buddy.h
>   
>   DRM AUTOMATED TESTING
>   M:	Helen Koike <helen.fornazier@gmail.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] MAINTAINERS: adjust file entry in GPU BUDDY ALLOCATOR
  2026-03-11  4:33 [PATCH] MAINTAINERS: adjust file entry in GPU BUDDY ALLOCATOR Lukas Bulwahn
  2026-03-11  6:25 ` Joel Fernandes
  2026-03-11  6:31 ` Arunpravin Paneer Selvam
@ 2026-03-11  7:58 ` Maxime Ripard
  2026-03-11 21:19 ` Claude review: " Claude Code Review Bot
  2026-03-11 21:19 ` Claude Code Review Bot
  4 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2026-03-11  7:58 UTC (permalink / raw)
  To: Joel Fernandes, Dave Airlie, Matthew Auld, Arun Pravin,
	Christian Koenig, Maarten Lankhorst, Thomas Zimmermann,
	David Airlie, Simona Vetter, dri-devel, Lukas Bulwahn
  Cc: Maxime Ripard, kernel-janitors, linux-kernel, Lukas Bulwahn

On Wed, 11 Mar 2026 05:33:14 +0100, Lukas Bulwahn wrote:
> The commit 4a9671a03f2b ("gpu: Move DRM buddy allocator one level up (part
> one)") and commit ba110db8e1bc ("gpu: Move DRM buddy allocator one level up
> (part two)") split the majority of the file drivers/gpu/drm/drm_buddy.c
> into drivers/gpu/buddy.c, with some pieces remaining in the original
> location drivers/gpu/drm/drm_buddy.c.
> 
> The commits also adjust the file entries in the GPU BUDDY ALLOCATOR
> section, but as part of that, change the file entry to the non-existing
> file drivers/gpu/drm_buddy.c instead of keeping the reference to the
> existing file drivers/gpu/drm/drm_buddy.c.
> 
> [...]

Applied to misc/kernel.git (drm-misc-next).

Thanks!
Maxime

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Claude review: MAINTAINERS: adjust file entry in GPU BUDDY ALLOCATOR
  2026-03-11  4:33 [PATCH] MAINTAINERS: adjust file entry in GPU BUDDY ALLOCATOR Lukas Bulwahn
                   ` (2 preceding siblings ...)
  2026-03-11  7:58 ` Maxime Ripard
@ 2026-03-11 21:19 ` Claude Code Review Bot
  2026-03-11 21:19 ` Claude Code Review Bot
  4 siblings, 0 replies; 6+ messages in thread
From: Claude Code Review Bot @ 2026-03-11 21:19 UTC (permalink / raw)
  To: dri-devel-reviews

Overall Series Review

Subject: MAINTAINERS: adjust file entry in GPU BUDDY ALLOCATOR
Author: Lukas Bulwahn <lbulwahn@redhat.com>
Patches: 4
Reviewed: 2026-03-12T07:19:00.950819

---

This is a single, straightforward MAINTAINERS fix. The patch correctly identifies a typo introduced when the buddy allocator was split across files: the MAINTAINERS entry references `drivers/gpu/drm_buddy.c` (missing the `/drm/` directory level), which does not exist. The correct path is `drivers/gpu/drm/drm_buddy.c`. The fix is accurate and verified against the kernel tree. As a bonus, the patch also alphabetically sorts the file entries, which is consistent with MAINTAINERS conventions.

**Verdict: Correct and ready to merge.**

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Claude review: MAINTAINERS: adjust file entry in GPU BUDDY ALLOCATOR
  2026-03-11  4:33 [PATCH] MAINTAINERS: adjust file entry in GPU BUDDY ALLOCATOR Lukas Bulwahn
                   ` (3 preceding siblings ...)
  2026-03-11 21:19 ` Claude review: " Claude Code Review Bot
@ 2026-03-11 21:19 ` Claude Code Review Bot
  4 siblings, 0 replies; 6+ messages in thread
From: Claude Code Review Bot @ 2026-03-11 21:19 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

**Commit message:** Clear and well-written. It correctly identifies the two commits that introduced the problem and explains both changes (path fix + alphabetical ordering).

**Code changes:**

The fix replaces the non-existent path with the correct one:
```
-F:	drivers/gpu/drm_buddy.c
+F:	drivers/gpu/drm/drm_buddy.c
```

I verified against the kernel tree:
- `drivers/gpu/drm_buddy.c` — **does not exist** (confirmed)
- `drivers/gpu/drm/drm_buddy.c` — **exists** (confirmed)
- `drivers/gpu/buddy.c` — **exists** (confirmed)
- `drivers/gpu/tests/gpu_buddy_test.c` — **exists** (confirmed)
- `include/drm/drm_buddy.h` — **exists** (confirmed)
- `include/linux/gpu_buddy.h` — **exists** (confirmed)

All file entries after the patch reference files that exist in the tree.

The alphabetical reordering is also correct:
```
 F:	drivers/gpu/buddy.c
+F:	drivers/gpu/drm/drm_buddy.c
 F:	drivers/gpu/tests/gpu_buddy_test.c
+F:	include/drm/drm_buddy.h
 F:	include/linux/gpu_buddy.h
```

This follows `b` < `d` < `t` for `drivers/gpu/` entries and `d` < `l` for `include/` entries.

**No issues found.** Reviewed-by worthy.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-03-11 21:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-11  4:33 [PATCH] MAINTAINERS: adjust file entry in GPU BUDDY ALLOCATOR Lukas Bulwahn
2026-03-11  6:25 ` Joel Fernandes
2026-03-11  6:31 ` Arunpravin Paneer Selvam
2026-03-11  7:58 ` Maxime Ripard
2026-03-11 21:19 ` Claude review: " Claude Code Review Bot
2026-03-11 21:19 ` Claude Code Review Bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox