From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21DF11125839 for ; Wed, 11 Mar 2026 14:57:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8176510E27A; Wed, 11 Mar 2026 14:57:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="SMHvpRj4"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id C850210E27A for ; Wed, 11 Mar 2026 14:57:02 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id BBC556013E; Wed, 11 Mar 2026 14:57:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0A29C4CEF7; Wed, 11 Mar 2026 14:57:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1773241021; bh=10tQazNeIGFnsWcgwk76le6RPUpdLK86sNU/apn2tvs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SMHvpRj4iYTvHzWzOOsVI7uyXIk/fX+3/Uo44qPzGxU4Hk9ynq8aI1NC8alo3YTZI pOa3SDEkPpzOWMAIBUZ2fe36/LhgVPeJV7dRGYkVyfWdSBgqtpVfJu66mS+eYekjD2 AYv02EUhWVnDLrN35w0jG5kdidhKc91LIE2ZupRs= Date: Wed, 11 Mar 2026 15:56:57 +0100 From: Greg KH To: Anas Iqbal Cc: andy@kernel.org, linux-staging@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fbtft: fb_tinylcd: replace udelay() with usleep_range() Message-ID: <2026031106-gliding-oat-2b52@gregkh> References: <20260311142407.35403-1-mohd.abd.6602@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260311142407.35403-1-mohd.abd.6602@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Mar 11, 2026 at 02:24:07PM +0000, Anas Iqbal wrote: > Replace udelay() with usleep_range() for a 250 microsecond delay > as recommended by checkpatch.pl. usleep_range() avoids busy > waiting and allows the scheduler to schedule other tasks. > > Signed-off-by: Anas Iqbal > --- > drivers/staging/fbtft/fb_tinylcd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c > index 9469248f2c50..51e6493b050f 100644 > --- a/drivers/staging/fbtft/fb_tinylcd.c > +++ b/drivers/staging/fbtft/fb_tinylcd.c > @@ -38,10 +38,10 @@ static int init_display(struct fbtft_par *par) > write_reg(par, 0xE5, 0x00); > write_reg(par, 0xF0, 0x36, 0xA5, 0x53); > write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00, > - 0x00, 0x35, 0x33, 0x00, 0x00, 0x00); > + 0x00, 0x35, 0x33, 0x00, 0x00, 0x00); Don't you think the original formatting makes more sense? And you did not describe this change in the changelog :( > write_reg(par, MIPI_DCS_SET_PIXEL_FORMAT, 0x55); > write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE); > - udelay(250); > + usleep_range(250, 500); This is a totally different change than above. And also one that keeps getting rejected, please see the mailing list archives for details. thanks, greg k-h