public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com, jouni.hogander@intel.com,
	animesh.manna@intel.com,
	Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [PATCH 07/19] drm/i915/dp: Account for AS_SDP guardband only when enabled
Date: Wed, 11 Mar 2026 17:05:59 +0530	[thread overview]
Message-ID: <20260311113611.3393194-8-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20260311113611.3393194-1-ankit.k.nautiyal@intel.com>

Currently the intel_dp_sdp_min_guardband() accounts for AS_SDP for all
platforms that support adaptive sync SDP even for configurations where
it cannot be enabled. Instead account for adaptive sync SDP guardband
only when it is enabled.

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 108d2e338e3a..10927bc836d6 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -7364,7 +7364,6 @@ int intel_dp_get_lines_for_sdp(const struct intel_crtc_state *crtc_state, u32 ty
 int intel_dp_sdp_min_guardband(const struct intel_crtc_state *crtc_state,
 			       bool assume_all_enabled)
 {
-	struct intel_display *display = to_intel_display(crtc_state);
 	int sdp_guardband = 0;
 
 	if (assume_all_enabled ||
@@ -7379,8 +7378,8 @@ int intel_dp_sdp_min_guardband(const struct intel_crtc_state *crtc_state,
 		sdp_guardband = max(sdp_guardband,
 				    intel_dp_get_lines_for_sdp(crtc_state, DP_SDP_PPS));
 
-	if ((assume_all_enabled && HAS_AS_SDP(display)) ||
-	    crtc_state->infoframes.enable & intel_hdmi_infoframe_enable(DP_SDP_ADAPTIVE_SYNC))
+	if (crtc_state->infoframes.enable &
+	    intel_hdmi_infoframe_enable(DP_SDP_ADAPTIVE_SYNC))
 		sdp_guardband = max(sdp_guardband,
 				    intel_dp_get_lines_for_sdp(crtc_state, DP_SDP_ADAPTIVE_SYNC));
 
-- 
2.45.2


  parent reply	other threads:[~2026-03-11 11:51 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 11:35 [PATCH 00/19] Fix Adaptive Sync SDP for PR with Link ON + Auxless ALPM Ankit Nautiyal
2026-03-11 11:35 ` [PATCH 01/19] drm/dp: Rename and relocate AS SDP payload field masks Ankit Nautiyal
2026-03-11 20:55   ` Claude review: " Claude Code Review Bot
2026-03-11 11:35 ` [PATCH 02/19] drm/dp: Clean up DPRX feature enumeration macros Ankit Nautiyal
2026-03-11 20:55   ` Claude review: " Claude Code Review Bot
2026-03-11 11:35 ` [PATCH 03/19] drm/dp: Add bits for AS SDP FAVT Payload Fields Parsing support Ankit Nautiyal
2026-03-11 20:55   ` Claude review: " Claude Code Review Bot
2026-03-11 11:35 ` [PATCH 04/19] drm/dp: Add DPCD for configuring AS SDP for PR + VRR Ankit Nautiyal
2026-03-11 20:55   ` Claude review: " Claude Code Review Bot
2026-03-11 11:35 ` [PATCH 05/19] drm/i915/dp: Fix readback for target_rr in Adaptive Sync SDP Ankit Nautiyal
2026-03-11 20:55   ` Claude review: " Claude Code Review Bot
2026-03-11 11:35 ` [PATCH 06/19] drm/i915/vrr: Avoid vrr for PCON with HDMI2.1 sink Ankit Nautiyal
2026-03-11 20:55   ` Claude review: " Claude Code Review Bot
2026-03-11 11:35 ` Ankit Nautiyal [this message]
2026-03-11 20:55   ` Claude review: drm/i915/dp: Account for AS_SDP guardband only when enabled Claude Code Review Bot
2026-03-11 11:36 ` [PATCH 08/19] drm/i915/dp: Add a helper to decide if AS SDP can be used Ankit Nautiyal
2026-03-11 20:55   ` Claude review: " Claude Code Review Bot
2026-03-11 11:36 ` [PATCH 09/19] drm/i915/dp: Skip AS SDP for DP branch devices Ankit Nautiyal
2026-03-11 20:55   ` Claude review: " Claude Code Review Bot
2026-03-11 11:36 ` [PATCH 10/19] drm/i915/dp: Use revision field of AS SDP data structure Ankit Nautiyal
2026-03-11 20:55   ` Claude review: " Claude Code Review Bot
2026-03-11 11:36 ` [PATCH 11/19] drm/i915/dp: Add member to intel_dp to store AS SDP v2 support Ankit Nautiyal
2026-03-11 20:55   ` Claude review: " Claude Code Review Bot
2026-03-11 11:36 ` [PATCH 12/19] drm/i915/psr: Write the PR config DPCDs in burst mode Ankit Nautiyal
2026-03-11 20:55   ` Claude review: " Claude Code Review Bot
2026-03-11 11:36 ` [PATCH 13/19] drm/i915/display: Add helper for AS SDP transmission time selection Ankit Nautiyal
2026-03-11 20:55   ` Claude review: " Claude Code Review Bot
2026-03-11 11:36 ` [PATCH 14/19] drm/i915/psr: Program Panel Replay CONFIG3 using AS SDP transmission time Ankit Nautiyal
2026-03-11 20:55   ` Claude review: " Claude Code Review Bot
2026-03-11 11:36 ` [PATCH 15/19] drm/i915/dp: Set relevant Downspread Ctrl DPCD bits for PR + Auxless ALPM Ankit Nautiyal
2026-03-11 20:55   ` Claude review: " Claude Code Review Bot
2026-03-11 11:36 ` [PATCH 16/19] drm/i915/dp: Program AS SDP DB[1:0] for PR with Link off Ankit Nautiyal
2026-03-11 20:55   ` Claude review: " Claude Code Review Bot
2026-03-11 11:36 ` [PATCH 17/19] drm/i915/dp: Split AS SDP computation between compute_config and compute_config_late Ankit Nautiyal
2026-03-11 20:55   ` Claude review: " Claude Code Review Bot
2026-03-11 11:36 ` [PATCH 18/19] drm/i915/dp: Make provision for AS SDP version 1 Ankit Nautiyal
2026-03-11 20:55   ` Claude review: " Claude Code Review Bot
2026-03-11 11:36 ` [PATCH 19/19] drm/i915/dp: Always enable AS SDP if supported by source + sink Ankit Nautiyal
2026-03-11 20:55   ` Claude review: " Claude Code Review Bot
2026-03-11 20:55 ` Claude review: Fix Adaptive Sync SDP for PR with Link ON + Auxless ALPM Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260311113611.3393194-8-ankit.k.nautiyal@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jouni.hogander@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox