From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A049112586B for ; Wed, 11 Mar 2026 19:16:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5840910E3DE; Wed, 11 Mar 2026 19:16:30 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="Bm3ScU91"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RYk7X7Ui"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9C14110E3DC for ; Wed, 11 Mar 2026 19:16:29 +0000 (UTC) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62BIfvOd1439681 for ; Wed, 11 Mar 2026 19:16:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=M6F2sM+eNOI6ryH461JlMbp6jSOf87pDbVN oVk+OREo=; b=Bm3ScU91/1gbgUtg12dKKtbeLcwP1WzLf0fRvYobQ0tC+dxzV1D jixSoZTKlD1QdTfs0T4W3noLyFrRFX6t4rJUMDnfkhrhoWHPErAfgCAuMNFbWMCy R4L+2SE2RtA0I4EVoAqhQrL8OYz/lzE49gOBWPVU65tf0NwV5sw68dswOrogesbp K+u3exXivYalvIhh833iyxuKG9LgtqTzen0ltSyOqORH9etjF5HYeEIpDVhReBhw +fMFdFuON1HDs47xngINu09G793baXoGWmF99ZfS3ObgLxL73Oiz96lqn+Tfhcb0 hrrBzlqxH4pbszJ3emsLYIpwrPxLPO/q9VA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cu38yjrh1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 19:16:28 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd7774be64so109518285a.0 for ; Wed, 11 Mar 2026 12:16:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773256588; x=1773861388; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=M6F2sM+eNOI6ryH461JlMbp6jSOf87pDbVNoVk+OREo=; b=RYk7X7UiRdcThB969yoGwR/L1u7/Sy6CrDI9Imfsl5fZHyO6bOfNCY9EeL8xhzorIz mn/Ewrcy8qan9nxPPor1cnfPjzmMsZZc7SzS/N85lGFQr8DHDnIistIOIRpN9Plvk1U2 zP9eU1eD8wtYTOG6b7A3qZzyAF4UAq4KC3oOs5WzHxwh9wxSU8Gem4caynQbjg6MGFpI FDLNupAs4xxQMQIxOcNz79zVC1ucJds3GJkZjWvKmwhibUSJ/2F2wNqJBeqBCvUnGfzl RhbVrK7zkKfT2D4GinoClAGK9w2InYFspHhksH/oZh+tZiulg/xD6UwN+82NIZxxryWp FLTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773256588; x=1773861388; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=M6F2sM+eNOI6ryH461JlMbp6jSOf87pDbVNoVk+OREo=; b=IUdsaV9qTd9yBNHA9Gw6VoqhzVgXyurPmKiylIlcqB2dxh3nMBGoqMrHU+nWgy/14o vclZxQa3VczGugCaETMGbBNXMEFah8T4os1o9rI82BQL+8anaOB6CeoRWdYNqNQqYR4v 4iybLiDg6kjPBUHTPnzzTV7BULZPfQhuheg0ceMgrlDkSxIbYHbrTT90HmElHKCW+Hmb JS1CEEPosChKCb6nFVkkcReeJxRBCOWaFhbq4nB1VmYd5LOm7yWm7YPQG/A+CqMCbsD+ H6X+Iolu//hypt5IT/sQl0zipvV0a4m1yVCjhMXxqdvKNZftgFrofVNt1LioP7xl1Exr lAZg== X-Forwarded-Encrypted: i=1; AJvYcCWd7xJrnKY4vO8zHzQtoqtMYa0Hpy4aiU96hruCg4lsJy6KsFi+Z3X4JTwQlujd4WhI008xzKt6eCo=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwgXd+j2nHyWOFk7+jjgiiQsI/EedDA6M40zasE62mVFJX/Xjq4 MFVOe2UQPrm5qL6tmXwcuWnVHdvI16//uQ4txBHjltirUAUiyX62w504ZI/eZY8qdK6sz3ScGWD iTxSOB2hAB7jH8DsWvKkFTjZeS944D6Q7/3JYeVz52YInL8qyCds//jYu+ZYPQpqmxpHPZp4= X-Gm-Gg: ATEYQzy4L1wFZ+lMuC9haDNp8z1d+j8r/+v5i+PaKK1AekWsiXHymUBCt4zdJU4Vzv/ 4Bnutx3rduethFbmPSAz1HfRM7hSsmEkeZFiugvkF5i+SNIpgRjmc8SqM1gUlYFJ8Tk1C1aotSo KnJXgfBkVyc/7j56oFRMTRC+NV6gqJ+KvqJvvzU11bUDI7pMQ/pfEqQk3QUBsvTMyCxRwpi/Kv3 vmpv819YhLboQpjgQLYqT7TUzaX4mMUkOgCPpQo4Ia+/yXpdDAx+xdXmQdVz9rZqhiX80brpapw W3DGGbJnoFIKiL2J1FfkEzZ3GKAOfpY16DJfDrNAZqKfaW5M1U5wXGG/1QKQHAGVXnsmxDgRvWI flNSJsqtWf8wdZlyrKsydES1Ti+dJ3aipkK2Y X-Received: by 2002:a05:620a:46ab:b0:8cd:97a7:a343 with SMTP id af79cd13be357-8cda1a29234mr498553885a.36.1773256588021; Wed, 11 Mar 2026 12:16:28 -0700 (PDT) X-Received: by 2002:a05:620a:46ab:b0:8cd:97a7:a343 with SMTP id af79cd13be357-8cda1a29234mr498548885a.36.1773256587514; Wed, 11 Mar 2026 12:16:27 -0700 (PDT) Received: from quoll ([178.197.219.94]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe2273d9sm1475806f8f.34.2026.03.11.12.16.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 12:16:26 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maxime Ripard , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , stable@vger.kernel.org Subject: [PATCH] drm/msm/hdmi: Fix wrong CTRL1 register used in writing info frames Date: Wed, 11 Mar 2026 20:16:21 +0100 Message-ID: <20260311191620.245394-2-krzysztof.kozlowski@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1818; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject; bh=0Qnr7VxidfvU+xsDleNOZhfJsVXxieNl3yqIIH0Y+3o=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpsb+EltUEMM5EjdIEq/s76SBmQyTVDzV2KeOFC RL/nWWEX0GJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCabG/hAAKCRDBN2bmhouD 1/YxD/wOPr0o16gKuvZcH1lDYB5OKlGeVB6cFFqVE0WRcXlUXwBj1qbsymgbYZllOE8iIAnx+xc l+XGmhJIL3Ytxv9JujjEucIdn2I0Y1U/GI9/dBXNonw/AqRMYOjb6l60LqNme2qDQS9N9AYEPaB 63o7mVsB0hLaTvRdXMa+yzfRQcyakznFByatyE6IKSwxGgW/NiM+bF+z5YmxoxLW7KtgS9gvyib ZxG61HkdyDqj4+mN4qNWU7JMVtrcMI8XZPriotu+YJor1W0d6EH8VRbo+pndWpXfrvHQ0eVRO3i E+CjV6H/MjwwTwHYKd9ErpFuExModykTudNq93r/ymIgJFsHyCF1ariJ6BO3SH9e683E0ooxw2O 1/QOnPZQMKOo5ZEJ6o5k6uTGjJni3lK+hIPNA0milUC5znVlboHUWgVY2ML04TWG2BworNw5398 n3P6N3tmTdr5LJQoxo8dcXkG4nYUz5gNC8tvaGj/bFa/HcHYYlcuY58qQQAqCgviTHEIl9v9a/p DDD5Ug7wrg7bYaAv7QSDKoIf2B/NGRDWjJoSZD79tci6kfjO8gtgBXqGQ3eLlpspgMkyvx1F/8Q BMT1/xjh3EcM+d4982bUiGZH4UNxzE3k4wOVsa3fidiOalcuzqfZIsDYbcau13HbhQUY1zS8tHj 0fKIP+gfkmkiMaQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDE2MyBTYWx0ZWRfX8fC8TJrUa4GX 4itMIMt8/0K10naOHXCfk4XJ9uGYNRHhYU4IhIUBKzISjqvXYocMEU6xmYm83BftHJP0j/MqA36 N71J+8UdLCFQfP109hHsFq222RG6EKfdXQuy5e3tdgCXcogmx/DCRo4wvx0r9Vb/9TiHlKt4am3 UnEediPTnh5E+hEWkMd3Uhctc7dxGiOXV/gEmPwlY7SWObtxpe0PgLOrfmMAFmGAmMN15clOHTF AU5Avm33uYxFa1iBF3+HPz5spdVWu9ThUFyjW5Uy4/Fxgh05/T9zL671JXc27Ng0Nbi1Zvcf1eO OufYsiFjM3uXWhayr6wkHvjGqs+FlyGyK4cXAk7HjpyBvxsfbiuKq9PtBxw7jyBS02bFCfvi0Ft JzYNMJoMKgb2nc2iAt1k+6JJTLnplk+e4ArI1O7QKALp+M5OC+roFULLtge6z70sj5EJKOisI/X WXXmKdfVC996eRptvnA== X-Proofpoint-GUID: IIQp8RtQZXGVWDHERmakGd1OWdLbF-SD X-Proofpoint-ORIG-GUID: IIQp8RtQZXGVWDHERmakGd1OWdLbF-SD X-Authority-Analysis: v=2.4 cv=Cq+ys34D c=1 sm=1 tr=0 ts=69b1bf8c cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=gOEeR9iKwsj33Yj5oN/cWg==:17 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ksbDLleXNvo7xJVorFEA:9 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-11_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110163 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Commit 384d2b03d0a1 ("drm/msm/hdmi: make use of the drm_connector_hdmi framework") changed the unconditional register writes in few places to updates: read, apply mask, write. The new code reads REG_HDMI_INFOFRAME_CTRL1 register, applies fields/mask for HDMI_INFOFRAME_CTRL0 register and finally writes to HDMI_INFOFRAME_CTRL0. This difference between CTRL1 and CTRL0 looks unintended and may result in wrong data being written to HDMI bridge registers. Cc: Fixes: 384d2b03d0a1 ("drm/msm/hdmi: make use of the drm_connector_hdmi framework") Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c index 3c407e275ce5..a9eb6489c520 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c @@ -153,7 +153,7 @@ static int msm_hdmi_bridge_write_avi_infoframe(struct drm_bridge *bridge, for (i = 0; i < ARRAY_SIZE(buf); i++) hdmi_write(hdmi, REG_HDMI_AVI_INFO(i), buf[i]); - val = hdmi_read(hdmi, REG_HDMI_INFOFRAME_CTRL1); + val = hdmi_read(hdmi, REG_HDMI_INFOFRAME_CTRL0); val |= HDMI_INFOFRAME_CTRL0_AVI_SEND | HDMI_INFOFRAME_CTRL0_AVI_CONT; hdmi_write(hdmi, REG_HDMI_INFOFRAME_CTRL0, val); @@ -193,7 +193,7 @@ static int msm_hdmi_bridge_write_audio_infoframe(struct drm_bridge *bridge, buffer[9] << 16 | buffer[10] << 24); - val = hdmi_read(hdmi, REG_HDMI_INFOFRAME_CTRL1); + val = hdmi_read(hdmi, REG_HDMI_INFOFRAME_CTRL0); val |= HDMI_INFOFRAME_CTRL0_AUDIO_INFO_SEND | HDMI_INFOFRAME_CTRL0_AUDIO_INFO_CONT | HDMI_INFOFRAME_CTRL0_AUDIO_INFO_SOURCE | -- 2.51.0