From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 426DF105A58D for ; Thu, 12 Mar 2026 11:41:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A9A6310E9D8; Thu, 12 Mar 2026 11:41:31 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=imgtec.com header.i=@imgtec.com header.b="LSsIXVke"; dkim-atps=neutral Received: from mx08-00376f01.pphosted.com (mx08-00376f01.pphosted.com [91.207.212.86]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C02710E9D9 for ; Thu, 12 Mar 2026 11:41:28 +0000 (UTC) Received: from pps.filterd (m0168888.ppops.net [127.0.0.1]) by mx08-00376f01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C6DfHu3792160; Thu, 12 Mar 2026 11:41:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=dk201812; bh=4 WMYA4KVqA3O8lxjZCn1coG6Ben4j1tWFldvlrq6psc=; b=LSsIXVke5+gWQ92bZ P9Rhc+U+wIJciIxLS3hRBrjWI3lmbaQ9geP70Wu+m76DMhiVTJAC3l/OfvhXPhDm zCoXyvo6dS2lf/xcncDnhZLZRi975sooDlwYcdiohPzknStF1NqVo4/8PnJaawe+ gcARxTVPU0QVhMSHk0s+JMh47lvTQnVttEmgS1T+e882DLIku/LbSGouU5pO72WH MHR5aXB8f+faH+GfVGtLFUiLXdjfwnRS/aGrWgT+atW36FN7mCbWotw+vv9cPiDt T6lDWt+MKVQSfmLucCKWVi7RjVssBpFT2MreLDi+uDPdC1XaORJzYiSoeQ8Fxn1K saXVQ== Received: from hhmail01.hh.imgtec.org (83-244-153-141.cust-83.exponential-e.net [83.244.153.141]) by mx08-00376f01.pphosted.com (PPS) with ESMTPS id 4ctxvy1c16-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Mar 2026 11:41:15 +0000 (GMT) Received: from [127.0.1.1] (172.25.10.37) by HHMAIL01.hh.imgtec.org (10.100.10.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Thu, 12 Mar 2026 11:41:14 +0000 From: Alexandru Dadu Date: Thu, 12 Mar 2026 13:40:54 +0200 Subject: [PATCH v2 2/3] drm/imagination: Switch reset_reason fields from enum to u32 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-ID: <20260312-b4-firmware-context-reset-notification-handling-v2-2-aec5a64cb06f@imgtec.com> References: <20260312-b4-firmware-context-reset-notification-handling-v2-0-aec5a64cb06f@imgtec.com> In-Reply-To: <20260312-b4-firmware-context-reset-notification-handling-v2-0-aec5a64cb06f@imgtec.com> To: Frank Binns , Matt Coster , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: , , "Alessio Belle" , Brajesh Gupta , Alexandru Dadu X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773315672; l=1898; i=alexandru.dadu@imgtec.com; s=20260304; h=from:subject:message-id; bh=GEhtv8jPF6IZFz2Yv8qIUQ036AidYPCRjdm2hvybvEY=; b=hhzHF365gbZIAueIMtD95L0c7L7DJSghhRWLWcmiSjNi1NxLURopGN+5ylyDxrZK4K452cVwt EUNPHRvEDM0CeUVuUPkBaQAxLqv+ns/JPUeJP/OoqMR2zqQEgc02w3V X-Developer-Key: i=alexandru.dadu@imgtec.com; a=ed25519; pk=FU07SyNrYGwhahqSxbWEuzyXlUh47xBXvLvOR7UA6+U= X-Originating-IP: [172.25.10.37] X-Proofpoint-GUID: Il79FvllxOV95FuEur7wzu5VBqBm9TyP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDA5MiBTYWx0ZWRfX2uBFfyRH+Heb ZXqyPpomhq8NMCKykj2qk9K1k1mC3JTZfnXhe0VHrIeAXp+tpQEe1uiIEefK4mEqAbTdgsaXB31 Tm3/eVPCPT/nWNEVm33CzboIagszM1AncDc6scm1tyXgjBj3s4XFVT2rclBmAGsuQavVoQVFN/a FZA73cVKdRACm98iqTgPL8+p4bTw8OOEXI3vDPlvKEObC8gAZoWZ59kfWUWO9mtQXjlnNFsvKrB ALGaCG5wmHmsl4dAScFn/KMWIx+Lm/gNKeBeJ8R8JKB/zGlVQgWFUK9g2OgtHC8DHQ3n+3IZAi9 gVf5Sp5ZYnb20sH7i73jh+LPAqdmTtwXxMGvzRBTdYaSwMb/bQ7JkU40t6z4Ihme7hcmUQ0c+NQ /uBXAVTiyhevkzBnBrvY1zHdN/9SAiOKIW1cdsGNA2qOoPCnAsRfSh38JHLTjR14PB0m+zxEg5s 8TyJWKXMFSOZcAg+OZQ== X-Authority-Analysis: v=2.4 cv=NuzcssdJ c=1 sm=1 tr=0 ts=69b2a65b cx=c_pps a=AKOq//PuzOIrVTIF9yBwbA==:117 a=AKOq//PuzOIrVTIF9yBwbA==:17 a=7IANbbwssFwA:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=kQ-hrUj2-E3RCbRHssb7:22 a=qZQ2PDNLMSdLoqI-hfl9:22 a=r_1tXGB3AAAA:8 a=1QHZ_anrujvv2WxOvQkA:9 a=QEXdDO2ut3YA:10 a=t8nPyN_e6usw4ciXM-Pk:22 X-Proofpoint-ORIG-GUID: Il79FvllxOV95FuEur7wzu5VBqBm9TyP X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Update the reset_reason fwif structure fields from enum to u32 to remove any ambiguity from the interface (enum is not a fixed size thus is unfit for the purpose of the data type). Fixes: a26f067feac1f ("drm/imagination: Add FWIF headers") Signed-off-by: Alexandru Dadu --- drivers/gpu/drm/imagination/pvr_rogue_fwif.h | 8 ++++++-- drivers/gpu/drm/imagination/pvr_rogue_fwif_shared.h | 6 +++++- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/imagination/pvr_rogue_fwif.h b/drivers/gpu/drm/imagination/pvr_rogue_fwif.h index 172886be4c82..5d590c4c2566 100644 --- a/drivers/gpu/drm/imagination/pvr_rogue_fwif.h +++ b/drivers/gpu/drm/imagination/pvr_rogue_fwif.h @@ -1347,8 +1347,12 @@ struct rogue_fwif_fwccb_cmd_freelists_reconstruction_data { struct rogue_fwif_fwccb_cmd_context_reset_data { /* Context affected by the reset */ u32 server_common_context_id; - /* Reason for reset */ - enum rogue_context_reset_reason reset_reason; + /* + * Reason for reset + * The valid values for reset_reason are the ones from + * enum rogue_context_reset_reason + */ + u32 reset_reason; /* Data Master affected by the reset */ u32 dm; /* Job ref running at the time of reset */ diff --git a/drivers/gpu/drm/imagination/pvr_rogue_fwif_shared.h b/drivers/gpu/drm/imagination/pvr_rogue_fwif_shared.h index f622553cdc11..869d904e3649 100644 --- a/drivers/gpu/drm/imagination/pvr_rogue_fwif_shared.h +++ b/drivers/gpu/drm/imagination/pvr_rogue_fwif_shared.h @@ -261,7 +261,11 @@ enum rogue_context_reset_reason { }; struct rogue_context_reset_reason_data { - enum rogue_context_reset_reason reset_reason; + /* + * The valid values for reset_reason are the ones from + * enum rogue_context_reset_reason + */ + u32 reset_reason; u32 reset_ext_job_ref; }; -- 2.43.0