From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 632FA105A59E for ; Thu, 12 Mar 2026 13:30:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0BF8510EA3B; Thu, 12 Mar 2026 13:30:05 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="LlV7KYE1"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EeAiLDBc"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id E20B810EA26 for ; Thu, 12 Mar 2026 13:29:56 +0000 (UTC) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C9GUgc1756606 for ; Thu, 12 Mar 2026 13:29:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wJB79bVUZrsbxSexjswx340+SsqpUDunWLmQTkIAkcU=; b=LlV7KYE1TbX8pTa+ YgFsjbh/gIgk+VM7wm6DMI7vzq+cDYuEIXlroRUOElyXdRD3IGEH21CSZ4kAZva8 JoGfzWT3OWPZOhs4t7URmdFHOfPaET6tG+B63a4TKyH3kv3Upkyxwo+2vNKuKEtd E+e1pEKOq6Dpb9aviia45BolMxf/MVWPTcBB8wVZEXrxgfGB/oAd0uySn50CrNHb uF9aU3CCxodB2UvN7IuZSuqL3ncIqnV2O8cRLNNE0+YQ83McTzzuspxAJ2uVhA1a iusKv+7b/VbhQi6NuBJiG7A9/oLFYGT9SHGfgsRguWbmzBtfP14FDLtkHmJ94W4G HyaH3A== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh53j6ub-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:55 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cd7d4cc049so1174917785a.0 for ; Thu, 12 Mar 2026 06:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322195; x=1773926995; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wJB79bVUZrsbxSexjswx340+SsqpUDunWLmQTkIAkcU=; b=EeAiLDBci+sABD1Jt1cwt/JPHnKokwWHhLv+7tw5kbWzJGWYomIdcfa6w9qdk1Zvw7 0nYMg/bX4E6j6Tg6Vqx/TeU9VkqarPmEBshX9jq+tpWw5sH7DBTUqECBgq7AvMBxmn7F DwjenPH4IvPq7kdoxsh1LY3KJ6qb+Mj5dp2HcpNJumfQSjnLEtTBatzITngK7hSNgoxU aj+mov42s6HOYbVP6EL3aosSzy2W9ywvn6PMpFYBFTWQ0hT1VMIiOSEXL9hDawTxGgKI +Ykw2MUgMjQeeIcjqogkGSsoybDS0BHo8R9D7xqIvZhuMaLQfmXfARsGUk9RDC1xu+v5 ba7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322195; x=1773926995; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=wJB79bVUZrsbxSexjswx340+SsqpUDunWLmQTkIAkcU=; b=ARzG7ncKYj9U8QSMImkJBRyjHCQSbPGTIgx8FChwJA+C8FvVWYV5FCDaz6sBvx+U8N dvbbaeXC1zFX7Slf1zHeogKaoB/oEpCcSIQwGWcej1cTpAHtFi/iUQv5JUsw7DMSUltF WmA0saVn7vNCA9swOoesn0C5pYwdMIJHck0ZVCVpgWAkcTAz8++AwYT77WZudo6eXVJR rHBFdRgaoH/pUmAN2Zd0kNuWpURrGF7nyJR1m2z3EViKf8Lqjw+hPPpKj+YWeRjJgJ/j fhsg0u3z5wke5Pbgi4tE2UeoTon5S5kAHkB/fTQvXg6JvwMV6ZufQR3ibarLdCGpZg7V X9mA== X-Forwarded-Encrypted: i=1; AJvYcCWvouTzNKx/Zvhf+W2dKi8xXtB2YV5F5JEOhp6tR/cZc6JJwAC/iQ4Y7jTuui9Fue5simB0Bwt69SI=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yyauz3nBltC7+EwK3QZW6VHMdJhYE/rjjJ+4xTgEau1uVGDcjFP JiBZIB8pkG9IoRw3RjMjB7GwCBSMf9Wfm2MDnaggDVoVWScjQch2SRuJ0Fup4ZEU8g4fLmzcgVF 31uhq4nU3I6v4lLZCQTzRzGCQ7RX8PjR+5Ca5F6oAuQVqJuSYglSH32cxPH+UHq911UYJgIQ= X-Gm-Gg: ATEYQzz3sEcfiLEjARpQhzTC020fXE7D2/MR1yr2PBnzSitBAPXJTRn085XeSirnS/u UbI5U2Gi4Yao8mrCWGSmVJDrIr2Ow+GLQSjgfa767RWV0SLYM/XdSpN6VSeeCtfsfbmJ4ZZWbc+ oML1cltaWnsu7anSCaWqqXFDb3ff7RIiv9t6vyBqoYl4fOkm3tyNg9GS3/PIqmu7DUZjEAWrjrW tV6QBSvyA07TJ8zmnb3Qe6dchXNsEWQvl8S7fNS2dBwbcyEyaK/xJjLe8QJBfr8rlbJ/Bz5oy6H IaqnTrqIwJp3T+ynphTrZ/OAFWVai/i6/196ugxQKgp6A6fjHxKA6vUfFodxPv5SJSxH07hM/uq m0SWTApaezoX21ndsrMuNeq6JUplzZSGsYceGWzWqy1pezB8RSnfWAzhNZSTzVhpqyLDh7Vkscf W0QwCviTFKVZwuHde5MvjTKSeCXspRCdKtUVw= X-Received: by 2002:a05:620a:d8c:b0:8cd:988e:c946 with SMTP id af79cd13be357-8cda19f6294mr859449485a.24.1773322195236; Thu, 12 Mar 2026 06:29:55 -0700 (PDT) X-Received: by 2002:a05:620a:d8c:b0:8cd:988e:c946 with SMTP id af79cd13be357-8cda19f6294mr859444685a.24.1773322194771; Thu, 12 Mar 2026 06:29:54 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:53 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:35 +0200 Subject: [PATCH v3 14/27] drm/msm/dpu: use new helper to set ubwc_swizzle MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260312-ubwc-rework-v3-14-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1592; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=BQXxAsNkcgoIebP1VAZBuBHx3qvfk0HLeeYsTxoyeyM=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+2anppC3ym8KO6XdcRCp1SnmFKlx2bhqppr 3Vr+RU265aJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/tgAKCRCLPIo+Aiko 1Zf6B/90dYQfJofMo0jzPjYwCBIiQVaMZ5/4eRlYzzGNQoW8TFbe609iQZFNio8O2JS7QCh+EpK 350LDlV7+ha8b14G3gaIML0qRx3W6EGk71G+94lXvHP3M5b3xcYcHN3Og669ZIQf8EvNKGA5KDX u+IRFP6dKFEEkQbMpyGFht4qqn2TOLD9CNl9itmO+WUGM3gDXzeuaCa4yhnI1DWDij0wU1la3S7 OlPgxyfMfYTRF6wTk8GMAHl5ipF+yrHpBF6JQZbUXqbBtSCDbsV7ejq/2cpnjOJ9ZdGeIKHWDAr qUcvehsSdbCvxqoF27h+i/r2TRGyUlq7lXABSoxHu1RYvplz X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=ZN/aWH7b c=1 sm=1 tr=0 ts=69b2bfd4 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=46QewcZEoJiMQYndSOUA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX5n0fHBMCAK09 9E0fnSLn0/0A6459Hlf77JcPFJb/JFCn+Dw2hwXzqEQnKfL7zyftv0UE3nXMwrXLuQff1zRT+f2 FqkUd8BVzMhis1GDMFdMlNFsXxMigCi6Ifidy1u3Z1kFymSwKR0bLYzi2cwkIKMLATohgjavHh7 CVzC0gouSrvoVRuENXq0kNE6cyEAiOr1tJzAmD456arZ0YvUZ8Yf6Un2OSThfXrahy12nldLElb YJbWYg924e9Dk8q2kUAwpsHNETtTlermKgHSW+z8laxbB0LmKIKndZn5DljktL8VqWql7lf5msh DnGhDn1QtVhZP2jA0QfQ129m62qG6nITzH77QVmzBFR+RAPfYZGxRO4JZHTnprrRApcFr20xCFe hyN+epx5XbVxJ3ewSa8qCkZ9XLMcrQsXW5kxh0zAQ7pFHZqDQIQA+yQCbcL19QV7FdnKxqNWHoA /OF1T1pg3tYgDy2hDkg== X-Proofpoint-GUID: zDo5LCG17cJ-0Z79vr2Zz-oRrJzPNcra X-Proofpoint-ORIG-GUID: zDo5LCG17cJ-0Z79vr2Zz-oRrJzPNcra X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 phishscore=0 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Use freshly defined helper instead of using the raw value from the database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c index d3da70009234..6089a58074ac 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -318,13 +318,14 @@ void dpu_hw_setup_format_impl(struct dpu_sw_pipe *pipe, const struct msm_format if (ctx->ubwc->ubwc_enc_version == UBWC_1_0) { fast_clear = fmt->alpha_enable ? BIT(31) : 0; - ctrl_val = fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | + ctrl_val = fast_clear | + (qcom_ubwc_swizzle(ctx->ubwc) & UBWC_SWIZZLE_ENABLE_LVL1) | BIT(8) | (hbb << 4); } else if (ctx->ubwc->ubwc_enc_version == UBWC_2_0) { fast_clear = fmt->alpha_enable ? BIT(31) : 0; - ctrl_val = fast_clear | ctx->ubwc->ubwc_swizzle | (hbb << 4); + ctrl_val = fast_clear | qcom_ubwc_swizzle(ctx->ubwc) | (hbb << 4); } else if (ctx->ubwc->ubwc_enc_version == UBWC_3_0) { - ctrl_val = BIT(30) | (ctx->ubwc->ubwc_swizzle) | (hbb << 4); + ctrl_val = BIT(30) | qcom_ubwc_swizzle(ctx->ubwc) | (hbb << 4); } else if (ctx->ubwc->ubwc_enc_version == UBWC_4_0) { ctrl_val = MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30); } else if (ctx->ubwc->ubwc_enc_version <= UBWC_6_0) { -- 2.47.3