From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 855FB1125853 for ; Thu, 12 Mar 2026 13:30:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 247D010EA3C; Thu, 12 Mar 2026 13:30:05 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="nrGJls8F"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CfG7vOYi"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2D04410EA26 for ; Thu, 12 Mar 2026 13:29:58 +0000 (UTC) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62CA6X1T3666482 for ; Thu, 12 Mar 2026 13:29:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IHkjxAifHisAGsBgDLIKhhx6s1dp+Liwk96nqDXbhiE=; b=nrGJls8F6+SNjwuV UpZi9Q2c5amWPB4V7Izz5ZPeUHb81ExPklqbeIJ5hCi1qUQq9VZ3q8GS7+vtzpL2 cCgIU6uWwI4/zMUcJXVHkq59uLrdAXl/6j4bvEcgB2/bdqKfKOG0FxXfQ+KmgGXG 4xTGUeNcdyK2e1P9mf1iGLKfeKdkZlxImJuBUKi29cF20ZaYX+IQ+zJSFr40hOYX zN3Hoh3VwFDUpfITXhFdIFNipPu6TFAgBfebTDuK3VGGFdQ9EOKJa9+UGxlwC4p6 AhjN1xdLIgT7s2Q4q1Wiqzl//hegv2daKtag1JP4W4GDGmjUSfe1Zl9PLdueAK4N NzsY4A== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh60j7v4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:57 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd781c0d90so1189566185a.1 for ; Thu, 12 Mar 2026 06:29:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322197; x=1773926997; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IHkjxAifHisAGsBgDLIKhhx6s1dp+Liwk96nqDXbhiE=; b=CfG7vOYioJpSExIBUjgwPLt+SaxEzFqLgdZF1bRnZlbWbzgacJIyDpcdXYxH310Ukg U+qVHlip0AL+g8AvYKhLKHMNCe7wSV/3G/LOv0LDGX5KHa1KrP6RLhubkL07Glgl8TpQ cCzj7Ye+phD9qtXZIHdfAg62+11B465XDU52OuFL+sICRx+IRIGaXqTFiQlSqg2T/t2n hac30Xwz9kzp0WyZP+eLB7dRKwr5s+cAiIxkDehX4fphzXmzfTLJW17qn/0BLF5Swici /bSKd3lSCXZJujNrZlpFOTH2pHFgw5ZSfJ/ZbC1Ld+VRsCEyF5OkCiPAVGjg3li8AHex vRUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322197; x=1773926997; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IHkjxAifHisAGsBgDLIKhhx6s1dp+Liwk96nqDXbhiE=; b=H7PgSFctuekTWlUNIpCdiSXI71ieZr5tbjoAKSkD4gacgx3aopICRiheRGwWbeIcF4 qmS1rCK6kOsW9i2QD3JWLqcIxtIiCl0ZZS2vh779/TJoTncONvjC94sT/RaHw9ZjyGQv Ju6oiRKPXddUW8v+smzQce4FazUnWo956P7VOI1EkssNXOTnZBPAsKchfOw7BRT9wWWs wPrmwp92o4OU7Z8U1pMsF0sU7DKQzFA4vSyp4oE9hJf3emCKB//wYiHsA3TWLHREdXGB 9TuRBwMh9VH54fCfiDGr/qPtAUWovE82zkxepFJOhNcz8fQbt/TvAtyEMibCTgeIEjj3 +Tkw== X-Forwarded-Encrypted: i=1; AJvYcCVpf//KBlvaioVHaqaKEwUXKLO+sS8cW5fb+xFD7AI74rvzW7aLt3Jxx+o9BMXE+QOWJKMtK5YGKv4=@lists.freedesktop.org X-Gm-Message-State: AOJu0YxPy5lo8apj3iYskca+VwwQ3YOti4XZXElxH1pLie+u1BLy21TU SxUKK8lS3IJa5v01pROnuaqqJNgI2wx5MXc87utS6CcvIr4CFe1M7xTFDIuuqfJVnI5liG8JhVn sJEcLWhbjCnUD7EXZZpAah7ItYLb8K5a6fz17act7dh1OW8mXo6VitnD8hN2fHha/O7bXtPc= X-Gm-Gg: ATEYQzw5kp+YifFL6+FP/533bAeQG15FpzePZwpLnozQO7ISUf46n6nmclssUpJfcYg G03fM5Gp7ky4cRwMSJrk9/wx9xAe3ThXWrwozwDVzV/qpBGzjYFMdIkfuOcpgHiwHvtNxzdByCi I3++LLZKRVl87WsyydsPuntQOLLy89eVaCq8GFtZsYrhfFVBgKp3LWX0ViHStDLuaUOSeM37CmJ aAW0lh1MWc4k2boZ7fYHLYiFfy9n1rY9TgOtLGAiuspQFf0TvdC22POMNaeBSlf0GPaCRRdbiOU FwnSnoUfPv+Dcpg7n5YpGaspzShx2Dh8rabJULPHFwa9yNyaud0rzyVPSTzNZdXoS/Vzh40DRbh FTfZ7zXjcIVhQ8MhsS/VDsoZR/IGIXJEurFauSEWBjz94c/SE6HQ/ctq4GeoxUWgZaltAJKJwXD T98jPLUtYgDHi/LPVOsM3uzaVYAY5LNYasZYk= X-Received: by 2002:a05:620a:2608:b0:8cd:b341:7593 with SMTP id af79cd13be357-8cdb3417670mr86995985a.19.1773322196637; Thu, 12 Mar 2026 06:29:56 -0700 (PDT) X-Received: by 2002:a05:620a:2608:b0:8cd:b341:7593 with SMTP id af79cd13be357-8cdb3417670mr86991885a.19.1773322196158; Thu, 12 Mar 2026 06:29:56 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:55 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:36 +0200 Subject: [PATCH v3 15/27] drm/msm/mdss: use new helper to set ubwc_swizzle MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260312-ubwc-rework-v3-15-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2044; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=CN3kZ0/IBWNiI5YHIzLGKD4m0aY5Oisezj7zkRehZl8=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+2jQT5pOrOTTeC5VX0xsxPmWNd6PDBdjyjo BZtm+GouG+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/tgAKCRCLPIo+Aiko 1TX4B/9882VAuHu2t29avT6n+6Ies3TV9cF9fpKejG/Jz07h8LsQAhLyQiGiqjTzD/4UBVi1XQN oZf39xifu9Fs9UmrPRMwkFI2XVppauY1PP2KO1xR0f5PXFDcBLtbVD1nmgG2ajqxr2kahDgS3EQ BFIonfPtygQLDnhdp4W/Km7Rlvfd1PbbK9JRZHvhKGIRoAqYjRkBz7YgV3/Iagq8gXNqfRW/7+s vYbdMq43QRKkZ50RTYyKltULaB4cQ6nI7B3yMmc3RIDIq4tzZXr7CQcRuOhX/s5liAhCiL/K2Ps ZtzhrMNMQIrA3N06rMNVDoocwKHB4YkC0pA/wNtdkh99k7cy X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: MWdYSpHDVy6LH1YN6QnRgmEH0o__Dbgp X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX36uyYFNAUiy5 yHdhc9s6sXX3jMi3UQhFriE0g0kF66tqA5XBOuZITDWCH9pQs0B6USSVvA0LXnt8xuZatj4i+ht E5kMGTLCGtX8lRVz61X9bnL5PZdB7bN1rWTawOLVxdQH5EYTXqyewevl+Jch8sU0b7GWoTWMh3p 4SqY0mmmzD3O9iYYj1x+ttmGJvR38b9mRrjZbqoHylY6occ0AvwC7UAeI/sWM6lAmLnxsUt/lJm btiunfEb/8otK8JL7hdHC9qLs3xZmZ35VUYI2OSBfBjVCIGzAh1z62gND4+s8imYa8t3UFLij9s RSYI8O6EeFMpDRvFq0Mn0y6sj+PJXBlxiivxHI4J52En+G7zWbOrZQpcWgiPtNww/5MkSk6vdnQ FcXGmSR71gOoyrqKz+GtUb/WfNj6JLfUEduGlmCtx2R+OlgY/jCH7T32ge1pXrxB1eJ0PNrqRh1 6n4Hkhywr7RWxCmHQrw== X-Authority-Analysis: v=2.4 cv=DsRbOW/+ c=1 sm=1 tr=0 ts=69b2bfd5 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=crYPmtHWi7n-_IQ59sQA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: MWdYSpHDVy6LH1YN6QnRgmEH0o__Dbgp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 impostorscore=0 suspectscore=0 adultscore=0 clxscore=1015 bulkscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Use freshly defined helper instead of using the raw value from the database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 76657a4a8f65..ca59bcdde7b2 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -169,7 +169,8 @@ static int _msm_mdss_irq_domain_add(struct msm_mdss *msm_mdss) static void msm_mdss_4x_setup_ubwc(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data = msm_mdss->mdss_data; - u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | + u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(qcom_ubwc_swizzle(data) & + UBWC_SWIZZLE_ENABLE_LVL1) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); value |= MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b(data)); @@ -180,7 +181,8 @@ static void msm_mdss_4x_setup_ubwc(struct msm_mdss *msm_mdss) static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data = msm_mdss->mdss_data; - u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | + u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(qcom_ubwc_swizzle(data) & + UBWC_SWIZZLE_ENABLE_LVL1) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); if (qcom_ubwc_macrotile_mode(data)) @@ -197,7 +199,7 @@ static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm_mdss) static void msm_mdss_6x_setup_ubwc(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data = msm_mdss->mdss_data; - u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | + u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(qcom_ubwc_swizzle(data)) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); u32 prediction_mode; -- 2.47.3