public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Rob Clark <robin.clark@oss.qualcomm.com>,
	Dmitry Baryshkov <lumag@kernel.org>,
	Abhinav Kumar <abhinav.kumar@linux.dev>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	Sean Paul <sean@poorly.run>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Akhil P Oommen <akhilpo@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: [PATCH v3 21/27] soc: qcom: ubwc: set min_acc length to 64 for all UBWC 1.0 targets
Date: Thu, 12 Mar 2026 15:29:42 +0200	[thread overview]
Message-ID: <20260312-ubwc-rework-v3-21-b7e8f800176a@oss.qualcomm.com> (raw)
In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com>

According to the documentation, the MAL should be set for all UBWC 1.0
targets, no matter what is the version of the UBWC decoders are present
on the device. The helper comes from DPU / GPU world, where there was no
separate bit to control MAL before UBWC 2.0. As the helper is now being
used by other drivers too, correct the helper to return the correct MAL
value (Iris doesn't support UBWC 1.0 devices for now, so there is no
changes of the behaviour).

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
 include/linux/soc/qcom/ubwc.h | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h
index 83d2c2a7116c..0b5aa9d0343b 100644
--- a/include/linux/soc/qcom/ubwc.h
+++ b/include/linux/soc/qcom/ubwc.h
@@ -75,14 +75,9 @@ static inline bool qcom_ubwc_get_ubwc_mode(const struct qcom_ubwc_cfg_data *cfg)
 	return ret;
 }
 
-/*
- * This is the best guess, based on the MDSS driver, which worked so far.
- */
 static inline bool qcom_ubwc_min_acc_length_64b(const struct qcom_ubwc_cfg_data *cfg)
 {
-	return cfg->ubwc_enc_version == UBWC_1_0 &&
-		(cfg->ubwc_dec_version == UBWC_2_0 ||
-		 cfg->ubwc_dec_version == UBWC_3_0);
+	return cfg->ubwc_enc_version == UBWC_1_0;
 }
 
 static inline bool qcom_ubwc_macrotile_mode(const struct qcom_ubwc_cfg_data *cfg)

-- 
2.47.3


  parent reply	other threads:[~2026-03-12 13:30 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12 13:29 [PATCH v3 00/27] soc/qcom/ubwc: rework UBWC configuration database Dmitry Baryshkov
2026-03-12 13:29 ` [PATCH v3 01/27] drm/msm/mdss: correct UBWC programming sequences Dmitry Baryshkov
2026-03-13  4:12   ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 02/27] soc: qcom: ubwc: define UBWC 3.1 Dmitry Baryshkov
2026-03-13  4:12   ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 03/27] soc: qcom: ubwc: define helper for MDSS and Adreno drivers Dmitry Baryshkov
2026-03-13  4:12   ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 04/27] soc: qcom: ubwc: add helper controlling AMSBC enablement Dmitry Baryshkov
2026-03-13  4:12   ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 05/27] drm/msm/adreno: Trust the SSoT UBWC config Dmitry Baryshkov
2026-03-13  4:12   ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 06/27] drm/msm/adreno: use qcom_ubwc_version_tag() helper Dmitry Baryshkov
2026-03-13  4:12   ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 07/27] drm/msm/mdss: " Dmitry Baryshkov
2026-03-13  4:12   ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 08/27] drm/msm/adreno: use new helper to set min_acc length Dmitry Baryshkov
2026-03-12 13:29 ` [PATCH v3 09/27] drm/msm/mdss: " Dmitry Baryshkov
2026-03-12 13:29 ` [PATCH v3 10/27] drm/msm/adreno: use new helper to set macrotile_mode Dmitry Baryshkov
2026-03-12 13:29 ` [PATCH v3 11/27] drm/msm/mdss: " Dmitry Baryshkov
2026-03-12 13:29 ` [PATCH v3 12/27] drm/msm/mdss: use new helper to set UBWC bank spreading Dmitry Baryshkov
2026-03-13  4:12   ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 13/27] drm/msm/adreno: use new helper to set ubwc_swizzle Dmitry Baryshkov
2026-03-12 13:29 ` [PATCH v3 14/27] drm/msm/dpu: " Dmitry Baryshkov
2026-03-12 13:29 ` [PATCH v3 15/27] drm/msm/mdss: " Dmitry Baryshkov
2026-03-12 13:29 ` [PATCH v3 16/27] drm/msm/adreno: use new helper to set amsbc Dmitry Baryshkov
2026-03-13  4:12   ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 17/27] drm/msm/mdss: " Dmitry Baryshkov
2026-03-13  4:12   ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 18/27] drm/msm/dpu: drop ubwc_dec_version Dmitry Baryshkov
2026-03-13  4:12   ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 19/27] drm/msm/dpu: invert the order of UBWC checks Dmitry Baryshkov
2026-03-13  4:12   ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 20/27] drm/msm/adreno: adapt for UBWC 3.1 support Dmitry Baryshkov
2026-03-13  4:12   ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` Dmitry Baryshkov [this message]
2026-03-13  4:12   ` Claude review: soc: qcom: ubwc: set min_acc length to 64 for all UBWC 1.0 targets Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 22/27] soc: qcom: ubwc: drop ubwc_dec_version Dmitry Baryshkov
2026-03-13  4:12   ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 23/27] soc: qcom: ubwc: drop ubwc_bank_spread Dmitry Baryshkov
2026-03-13  4:12   ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 24/27] soc: qcom: ubwc: drop macrotile_mode from the database Dmitry Baryshkov
2026-03-13  4:12   ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 25/27] soc: qcom: ubwc: use fixed values for UBWC swizzle for UBWC < 4.0 Dmitry Baryshkov
2026-03-13  4:12   ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 26/27] soc: qcom: ubwc: sort out the rest of the UBWC swizzle settings Dmitry Baryshkov
2026-03-13  4:12   ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 27/27] soc: qcom: ubwc: deduplicate UBWC configuration data Dmitry Baryshkov
2026-03-13  4:12   ` Claude review: " Claude Code Review Bot
2026-03-13  4:12 ` Claude review: soc/qcom/ubwc: rework UBWC configuration database Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260312-ubwc-rework-v3-21-b7e8f800176a@oss.qualcomm.com \
    --to=dmitry.baryshkov@oss.qualcomm.com \
    --cc=abhinav.kumar@linux.dev \
    --cc=airlied@gmail.com \
    --cc=akhilpo@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox