From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83AA1105A59E for ; Thu, 12 Mar 2026 13:29:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B06C010EA12; Thu, 12 Mar 2026 13:29:47 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="NK9vMxAX"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="L+3ui9Yx"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B4A610EA18 for ; Thu, 12 Mar 2026 13:29:46 +0000 (UTC) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C2boNd1740509 for ; Thu, 12 Mar 2026 13:29:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IE7+voqoAHNNKrIs7WzVDBWghsRgS97+vaqd0IwCOgE=; b=NK9vMxAXLa+1OCQ4 /RNDXVlHxuqQ7vlDp6mpnN2BZqNsfMjUy/P12K0O0EmB+hLGVZ9VUt9UOYHxNra0 DwJkI3CnW+e6XOLsc5VBNv2EK2wf7jAPtZLyjr5BbPNwLfAS9/rx8jDt+yY1CgrE JBN66tsYUTlxI8CBbsdrUbfockLi4vESGpNkmn5szRSIJv35cnSaxvl5aZhIqUce 5vmMYV2uUvfp0oZbH4f087OzMrCpDXFdAqEHQOULmmhEUGgnsFluO4ldo1c6ooi3 LOCQA750ZcnQ15hAMllFf1V6UyavnHuRNkwbEv1Ui2+L/qX8YhPhyz1xheUzGDTt 3ClSFw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cumvdhjs1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:45 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd80bea54dso602205985a.3 for ; Thu, 12 Mar 2026 06:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322185; x=1773926985; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IE7+voqoAHNNKrIs7WzVDBWghsRgS97+vaqd0IwCOgE=; b=L+3ui9YxLCZYTieIAlEvi6yENsph3fsYNTdYkGDikD28GNBVwqWwENPyyfjSmFFvWq 8QGPYSRUTECm29tcomzMiBGmr685YP1GYDco0LOOK81/3Azd5LBoee2APHEWUQmfzipS IQjwGg4hijA90WdVhKD6GfU7I1NRTbHBzeSiN6i+Iy9osvFPubzL7yRXm7AxykmXnl1A pkNFu17Gwlt8b80vHDkJQ9VML4hYRbwg+3Xvec/Un5GZbeV2YbmhNaIdsfiuPza6jWLX nxhmJlAMPn1RIlOXSBOMUaUAbSwTz5Ec869uY+DcCWs8+cL/M3kSLKCRDCTTeg5R1pyG vxiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322185; x=1773926985; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IE7+voqoAHNNKrIs7WzVDBWghsRgS97+vaqd0IwCOgE=; b=wlMAPUKJeneq/wTTRnH2x4gIXPIjWbTneTByqK3WVs5yTu77NNGQkSTSXZYVKF6r+O rJ/H1KjD8nd1g93kcaMaGaf3su+mp/Ldda5RbQx2qXUjkNp4xbl0PMgIc1ptzTIb1WC+ AnMU7g0VDNgrzAdsCmhZ3mGtgtG70vYxrYHPmXi/NK1ljiMmryWP3P8qHGQxK6vJbuQI gYp6lzUMT9pbwGu2+jzCS6v864gfNkhbnGanQtgcERY3AZfp8bxn7Qt5cSqTQspkd2us JVinZyL1Z2bEW64ucf7gVngKPvI4wa5WJ6cH/2dyOVa3g8GSt6F0IChCADyGiJ2NysrE cE7g== X-Forwarded-Encrypted: i=1; AJvYcCX47eFm56JiICSDfjB1DBBckc1OCo1iBYaVaER21mWucFT6x58IB8+YzY5lASR/bMTn1VugV//8Oo4=@lists.freedesktop.org X-Gm-Message-State: AOJu0YzS9NYTafuzYfweYGWjXol15pfUzJ7F5o8QpxY/TTCAkEjw9e4A TT1Vcgcs94BAwonLqpGYk8rEwB46MPS7bGYFV1fEnym3tcRFbGnNGkxAkuIeYXvamHYLhYskyvp r5Efd71Dsnhaxuz/4daF+XQ+ExmGq3BE9apE6TO8k4QtbKEEr1333O2YkABtK1ybCV8hzlQA= X-Gm-Gg: ATEYQzw6bSYIOtSCCosyM5kIgFcIrYdJ9ktj4zahfIZJ2lJwBUt9rLC9Kfe5+xtpGHp fBdu0GaIGOAy1GUPRZMfvT02V9BPYqcDKXcxw6RxVw+TG8Q09ZQXOHdf2TubJdRJXGMxhlqdxvO jPBJ+LrbLjhwnuzFp57ogUVhFAxs/a5bDJlrBCOP2RFQkpcXhbowiKbJApxjIPPf89Rr7IRxij6 d7ZbaQZ6N8DzgGYAEBZg1ugkHg/nsk2xbOiiIq9d2q/QK7kuw6NDNzhgXcvb1YA4jdwxqabSVWf duECLHm+pPx6fKgnedHkx7nm6cef68k3uRrwOdborxE8yTwbfa5MxM2jnVLzP7xHmVhmotxsJcg mNw5ngiitc724SH1k5o0BqbU59bx98ssdxz/tig0ynquNKIeVzv5yJ4H6IZsg3ogStV5mwxO4Cl P+oZSZYAqj5j5yLjDg8lMYbE54psbO/cM0PYc= X-Received: by 2002:a05:620a:2a06:b0:8cd:97a7:a334 with SMTP id af79cd13be357-8cda19bb33fmr749043085a.4.1773322184994; Thu, 12 Mar 2026 06:29:44 -0700 (PDT) X-Received: by 2002:a05:620a:2a06:b0:8cd:97a7:a334 with SMTP id af79cd13be357-8cda19bb33fmr749039085a.4.1773322184565; Thu, 12 Mar 2026 06:29:44 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:43 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:28 +0200 Subject: [PATCH v3 07/27] drm/msm/mdss: use qcom_ubwc_version_tag() helper MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260312-ubwc-rework-v3-7-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1662; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=xO+dmVKeAgw+NPDr2h9siH1EsNMcwlIuWzCr5f2QIyw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+1jVZdIm4Z5c9SotutkxEHFGXzgCmOArpB8 PqwvUHddbyJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/tQAKCRCLPIo+Aiko 1aqdCACzDFSUZDp9hHVRuPmRYu0zC16Brt8euwkDH2Sl1Y9E0w8FpOJTHSXVaJFuoE+BmChs6ao UGCBQ3NL87uHHw3x+8JCMXbaIRuo/4HrR9maQ93bdxtGRZiHrTN/sr/LR5JcgOxsbsTjKoW1euQ FO6gVqu+ArbG3jxLUonRzhBk2E2PwSaC8v39zYBnhNs+S6Z3vXrFo5wKf4OdlWOuijXHI60wFeE Bwpoyk9m94uTpd1mZr/WjTc2Ult0FANct/wvS1WxEf6BhNGgEpziUpe3P90k3FuDaFreSPva46V rO+JFmwrOvnIKRju0rm5E0jU3lEWww+jzGi90OUGq7EnLt/X X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX0JC0AIw8sGCc bhB3FnoRBDYSU1mO23481tRkYfc9QYO3ImFk2gbSquv/TpGbn22XgkXAmupUPbLT0wHzinmcM75 ISZ3M+t/P4FbunhodWljFOTIqIMPgd+MABb/sbRR/gfwhopeyJ0/BILU3J3eosh6tOFcW9uPkhj 7PSzsBv4NwsdMteskfsZtAYZvgoTL2rWMczFPQh+hH7rkEhhADUADx1SiJ4R7/heVl5eiavXS+x K8Dpinl9viE6n+j05duI/1FMcS32ySbmEjtu+u8CArIbFx8bvpiC2l5cLPVQF8v78ie7QUNCPSf wxpHvdE7PJwe4PEsY32lwjF6bqGbNFH5rymOWq1H8g0tOPcfjyej6Ik72xglQhUfr7vA+I/nfHp T4WfXDJjv5rp1BqmkVvr60OXCH2levG9n7+ZlawpXlT7AzMy9/7Tf4J1w2qivgojks8muhbqmHE Qg6AHTEQOEV//1c8a/Q== X-Proofpoint-GUID: thgS7halhBqR18rF7K4jcKyVweWSFK_R X-Proofpoint-ORIG-GUID: thgS7halhBqR18rF7K4jcKyVweWSFK_R X-Authority-Analysis: v=2.4 cv=XsT3+FF9 c=1 sm=1 tr=0 ts=69b2bfc9 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=qBJULKV797PGQuHHbA8A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Use new helper defined to program UBWC version to the hardware. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 7cb8aeaa7ecf..e2ec1ee590e7 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -201,7 +201,7 @@ static void msm_mdss_6x_setup_ubwc(struct msm_mdss *msm_mdss) const struct qcom_ubwc_cfg_data *data = msm_mdss->mdss_data; u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); - u32 ver, prediction_mode; + u32 prediction_mode; if (data->ubwc_bank_spread) value |= MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; @@ -219,20 +219,8 @@ static void msm_mdss_6x_setup_ubwc(struct msm_mdss *msm_mdss) else prediction_mode = 1; - if (data->ubwc_enc_version >= UBWC_6_0) - ver = 5; - else if (data->ubwc_enc_version >= UBWC_5_0) - ver = 4; - else if (data->ubwc_enc_version >= UBWC_4_3) - ver = 3; - else if (data->ubwc_enc_version >= UBWC_4_0) - ver = 2; - else if (data->ubwc_enc_version >= UBWC_3_0) - ver = 1; - else /* UBWC 1.0 and 2.0 */ - ver = 0; - - writel_relaxed(ver, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); + writel_relaxed(qcom_ubwc_version_tag(data), + msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); writel_relaxed(prediction_mode, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION_MODE); } -- 2.47.3