From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 302E11049509 for ; Thu, 12 Mar 2026 13:29:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6F4F710EA22; Thu, 12 Mar 2026 13:29:54 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="IlvWnZY+"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dL0LLbsk"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id D8CC510EA1B for ; Thu, 12 Mar 2026 13:29:47 +0000 (UTC) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C7e2Qb509786 for ; Thu, 12 Mar 2026 13:29:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tABjXUq/OjxQFlltJI7qwEI7Ulj0yf3Q34M6i0RzZsQ=; b=IlvWnZY+mW3yuJLB 60borKwhsVIPGWbcwdqQipWGHZ8lFPiDl+WjkyfhrKIOn/prUIQw1O2SeLgrBGaj bidNLEEZ08qfNh9CqbrCRUmV6Il8LthjjOh+LxgFi+hlWEQ6vcXb4alwlA/5UB/3 niBja0IKTPWjICEiUuEvwLMVz7m0dEMpGqb4nq+hd0tU1O8gfcgWeoZtQ0eHg2OW q1TV/Nbf3IYQZ8JVkpMpvm6pzQ8WSFqBYKsDhqBmyM5e+C9ze60rb5XJN+Osz17f YBDbEFe99xQvAm4YRvOWbdlnMfX2+jkt+z0AVqhBuK6KQK4JWLhrAfxKUpf1PIvG TKWRUA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cus9w0vbq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:46 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cd77bc8186so993940285a.0 for ; Thu, 12 Mar 2026 06:29:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322186; x=1773926986; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tABjXUq/OjxQFlltJI7qwEI7Ulj0yf3Q34M6i0RzZsQ=; b=dL0LLbsk+emEAjyO8hd6ioblxh4OHnRZqo10TueV7cIK1oJkNeSd6i5d02+KbjQ8W4 fAJgE9ywBs0ZEyf1+BMN/wq2oz0W1XIR203P1W4XgfXbgZWDIv6k4muOiCJaIfLf/MtA brj3PkX5E5IS4c+2RasmUbeBOmOH+CszFHJJlz/ZUiRQsyjOTyat9uilxxIdalZXquN3 0kvRP8A79UmLhkHIaQ8FzmxUBJ6sJno1fdn4IUroVsz1fQysKuT7Af8HgjNi9z0G015n GqBH6B4EfyS/d8AiLRWxOz3xLC1XdcTjNkPkEfCbMjnjluQnFcdzQMsebkVh72xLOBl6 7W5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322186; x=1773926986; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=tABjXUq/OjxQFlltJI7qwEI7Ulj0yf3Q34M6i0RzZsQ=; b=dV1KUfzksTbO/ASHdGcHRnnJlIc/Tcy9so89ucSsEpp6RFvhOyJySlQ8XTIhYJTkh5 0VmU1geIjAq6j3sWZXmnnGBhA3oQw3zM0T2lx9bc1OKfafMGVfiNq57bGylJW7EVrYkG wLeQ9aYPPlUbOBxne06F3dUgJLu/lCp2xkmye/bZ0b4YPOO4UB/b0VjrOM9gsw6Ohoh1 0msR5ryhrAFTAf6au5CCAS1Qyr9g8g3mF6plkqvKUQ4Pn0P1UxUAAlVwB8X8RFSgePAa Q9sWlI+ABMnppo4UID2xZ/a7e0gLpMkJBAtzvPUUWU5Pym49/11pJULBbyjfKvD3WYpV aRLw== X-Forwarded-Encrypted: i=1; AJvYcCWo2ulUKOimdXcdI3o2THpQAaSM7GrZ2esmQ68edGhK7P2BhgV1XR3cWE7TNGglDR1tCiDItIMtC8U=@lists.freedesktop.org X-Gm-Message-State: AOJu0YyJ7Tk/fxe3TSMFDol1ewkfE2XoeQ466HgTT7+Vrcc4piXb1Aq8 565+GQ2vrT/dTXr988MZRomtxlH82jBRk+6CeF9GTk8pzHYoEz+VZldjXghu+WTMLy5wPK5yCN4 sPAY5nCEa8gV66saewljwC4DCJiqPyp7mdyB11AGpFO6eq0h/1BThaU8v2EAXJZflKFKn5Xo= X-Gm-Gg: ATEYQzzrh2iVpK2oEypk2jN3Or08BQmaKrUDZptNuqgYTw3dmQM0slesrE2j5/xtjVB c1notW6KKBxBXwRxZUeh3IMpB10I91M3cNluoCsbzlbugyAOcu5aqsmLCfU4V+C4VCtGGHOOO2j GnAF1XFK9/KhROO1KxUzKo9f0Fevh5TNDltj8EYSjd1AtUN40gs6XFlkympo5qT5FUlhITr46Zh LFNE0NoBm4NKOwEsLcFTaERtSP9PFbU91AWc+1rJOcnos8Dza0vVq6a6KmCV+D9Ydei8Jb3T+RA GUHqEa3quhyvgo0mXHWPuIpbjphxOMBHGx/eaGNaNP1Zlhc9JI99gTsCBo+RtxRJOanzE6ALalW IF45zFMOPSB0YC6phutgsUnG3zAEITKQ0typOx0rKkEZvme1oSDuEZE+Ed2pu9kCtpCp2YaoGZB /cTjQ/rM/oNrheg+0Ztqk413QPb3Z90JYysIo= X-Received: by 2002:a05:620a:2916:b0:8cd:8ddd:2699 with SMTP id af79cd13be357-8cda1956f9fmr801125685a.24.1773322186406; Thu, 12 Mar 2026 06:29:46 -0700 (PDT) X-Received: by 2002:a05:620a:2916:b0:8cd:8ddd:2699 with SMTP id af79cd13be357-8cda1956f9fmr801120885a.24.1773322185943; Thu, 12 Mar 2026 06:29:45 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:44 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:29 +0200 Subject: [PATCH v3 08/27] drm/msm/adreno: use new helper to set min_acc length MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260312-ubwc-rework-v3-8-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1349; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=vcRHbEAGLYLgXe4iaZftIzhetGkuS44tvnfyt/ZXY1c=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+1rj+PHUNlD0J8j3P+ZVuif5d8CEw9DAHQ5 ab5tj69UE2JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/tQAKCRCLPIo+Aiko 1XSjB/43r7ue2sSmqHbXg7+6qoUEbRedeQX3JwYda/B/TL6hkDaz92L4KI85wgZFVOJ46+V6C1Y LqWePdp5OnhNo4QXCFSFY8XdflEfMhWA6mCqo6ifFJ9qF9x0H/z+4jsTMqZ4sxPcylTcaLg2Eo9 eYR29itoR1+Tk6aQcQ88K88I8g/SQoH+24vB2qudT5X6mvmnbJBqp0kbbqMKilWPgXPsJwGHpmr G70fHNeUKKjR3PRpwcDmLkRubSg/7Nh/9h0LwaWee9DNoecIAWVBvvjBdT5ujNbDr152Gb3wKQu /fVGIPQtzaiQX6AiuwtDtQTAcqxCO0SkU7NI1J8dU8xeS1vS X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: jXzTgB7tsEzfscIj3kwwXxUo0tMnXqk_ X-Authority-Analysis: v=2.4 cv=IIIPywvG c=1 sm=1 tr=0 ts=69b2bfcb cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=X-e67srwgh_QgMMAbO4A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX4tksfe5oSPcu +KDbuUnEe26J51qiyQGzr3xTu28rg1h4I3RBwxc/ZGqXYD6QYkinGdSsHqSPKbT9ue/juP+YVvs xQvR69xCRv4vvKTJ8j2noa2k44KBiEJLdxkqEpYC5i2Vg64zobkwDYjmBMWEsYfw3q+fntqByrQ z+YJzmzQHPz7qcafq/EDZ+qGxRc3yZPzuSfh7xIsmzADAlc9yk2gfDp6x98mkYiPpuCREZefsS6 cyFFAe4dh+72nzzBGon/jy4iD8f7sOkATd6H0XctUaTAthKafsVYiYn6933OyaxxqruTuwpxpRC eapVkTkSd61hrmYI8sJ5zr6GA0bIrUETyWVIvsCtPPYbgHcV+r1ztVf/LQrB2lnLPBDtanepEC2 lr5WxivxWNv4QMZSbS67eArtGWA3Lj6m2kAHYPtX6kgiX9FHxm05mYIg6Bw+E4HlDGw3eky/fJO hIVzRyuxakxZcPBRPyg== X-Proofpoint-ORIG-GUID: jXzTgB7tsEzfscIj3kwwXxUo0tMnXqk_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 impostorscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Use freshly defined helper instead of hardcoding the checks in the driver. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index 6eca7888013b..2027e479d5b1 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -744,7 +744,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) u32 level2_swizzling_dis = !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LVL2); bool ubwc_mode = qcom_ubwc_get_ubwc_mode(cfg); bool amsbc = cfg->ubwc_enc_version >= UBWC_3_0; - bool min_acc_len_64b = false; + bool min_acc_len_64b; u8 uavflagprd_inv = 0; u32 hbb_hi = hbb >> 2; u32 hbb_lo = hbb & 3; @@ -752,8 +752,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) if (adreno_is_a650_family(adreno_gpu) || adreno_is_a7xx(adreno_gpu)) uavflagprd_inv = 2; - if (adreno_is_a610(adreno_gpu) || adreno_is_a702(adreno_gpu)) - min_acc_len_64b = true; + min_acc_len_64b = qcom_ubwc_min_acc_length_64b(cfg); gpu_write(gpu, REG_A6XX_RB_NC_MODE_CNTL, level2_swizzling_dis << 12 | -- 2.47.3