From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C0EA105A59E for ; Thu, 12 Mar 2026 13:29:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 69E4310EA1B; Thu, 12 Mar 2026 13:29:52 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="Zz/zUjYw"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fv8vPVp2"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 651D510EA1B for ; Thu, 12 Mar 2026 13:29:49 +0000 (UTC) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62CALZ2U4026924 for ; Thu, 12 Mar 2026 13:29:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JSQrds/2TP9Ues0FjNkY9V1Kd4kRgiqfrKRrWp2sgaA=; b=Zz/zUjYwUoaf5Xpk Xy8d2SdjHkMv2MT4ohrq9AiBk8apgsgrWJAdthKILsQZJSUk9vGXVVyy9zJzMTb5 aKfTT8gfWYamRRGp6hSgFtfAbUFuJ+t4uESjiHHb1KMPh85NUegARZ8XeRVOdRQz QkvZAth2r1toGRes5YvaJ1KkjSzJzoBeJWWBAKDOJZuSiGi1mZ5XF6JCEt//ru87 2T0vQzeQ7jOXoWH7zjoSkXN4l1bkCG7Y9oHFYZEYVgP3wm3WA6uCJn+JWFM51tFE S1gB+FNKixldkQFCL+1DQstXRoAXEaaO4Luz0mzKOXg6PlO022C4j9bbPAVn+Fmk Hd1FzQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh54t5rw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:48 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd91c0262fso694681085a.1 for ; Thu, 12 Mar 2026 06:29:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322188; x=1773926988; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JSQrds/2TP9Ues0FjNkY9V1Kd4kRgiqfrKRrWp2sgaA=; b=fv8vPVp2TElNXN8piBBzuCTM8S/GLBYvtcrqEjBBhlzkeqiCOHlscG4oZhc6KnmcSd esyoJ1AdTdHBu9krFLAyVm/t0jwhcbMetxzfcgxnIAqDWhiXGHjAFldSP3fUNWAxHppM oNMv2BR8d0lr0zERmJQTWNIUbergXFM+Btay27pOr+Rolx7NtqcBFlHTDrX+Ynjy1GxM D2EDcLOpE8oAiBLUiq8+Ku51Ayvx1Y/gMHV2uS66q7+CCmReIN2QElDwAj99/x8QD4d4 xJ5fT0M7RObKtFuoFb0pkjJi9F7CNo7wTYwsVlLovBj1QQuuAmHY3R8Rlbl5WH+RszlW w8RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322188; x=1773926988; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=JSQrds/2TP9Ues0FjNkY9V1Kd4kRgiqfrKRrWp2sgaA=; b=onrXDo9mXEPJn3KeAxnUTC7TIGKl6dBtS2bb5jJm3ltEdzRPiicJVjRHr/4XFv9eES Y977vb5k3xDUxxAsCJJDwrhHa9ciXxH01dl0b8x8FpuX+LBHmZh2nbLmxGidbza1dcgn D2PrI3rXm3XkDsN3fQ5tqFcbW9GaHloxgzKt9tewyKOSW05IgfLsylm2yuQYxS2F0mr+ /EDk40uGhATebtvdhRNry/AKkZGMAprVD6hwBW36nXs6aPdH4+rwsNN2F8d176YgIL2G ADXSZTWjS+9Xfgqm7kr3XdikrLjcxZjW1CMTNYFyJHh2Tr2xDPrbO01FnTzk/UXEnQ16 orXg== X-Forwarded-Encrypted: i=1; AJvYcCV+DMJ2RqVMQMU9a+IBvkbp6rlKKWdI6x/bUJHS6+aG4BuPzUT7mO4mRB2H5R7kt7SeKc4rZWiKl1s=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yw0JXWORhWSj4B+wLD6AFB1+eREmJJV9Q3yyBMjGlAP2QC+LHzI /BlYzbIFCn/8EiLzHSiScHNfUrzi+WlYmngy8wxp647NFYDPVoXu0eeA5D36/MkO3ODu9F7ocNQ x9nWNhtn5rT3y7TVfLkJGA8pPNo5FkiuiCMPKwhtxu/w8CE29efLs/dei6OO66J5ojAbLZAk= X-Gm-Gg: ATEYQzxmmhOhML9swfB1nM0GbbWeTwx/7ST5xyL+cpUsPEYUnDwLAuwpB/PVFtR4ahy MaPd6xFIRx/JY5CRiHGUMwt14VO+tKsaLNWKcrnuOHRyG4/Ft6KIAfH4Gfhp6NxqJ7PA1IU+aAl 6xos4s2L0pc0ct4Ph5+ff4e/khhfSYn+hEyI8Ku0LqiG24WesfcxLz4vE8HWxHV36oFSd8/G5Ga fF3NH1J6wIbgLVCOk5f8IdDztJ2iwgbozX1bsApDuGW0EyMoo4nZqrbeAgkvffw8Rlu5GTnIagd SIyOq+2Su3CGzCf7RJRddM+18emCacjRfOHftHppTdwt4fcxfPLCXReCIFHjRRsP8rYxjgkaMfC wcz8uICMnLyRajj9svRJA+Nb3a/zYspdAqBziK9YQgEeVCKpXbiPfnk1GCBGrIyTVKO0ghgdodh i0k+gWpKOryd7+MesLRkNnWco0q6yMM6Xw56g= X-Received: by 2002:a05:620a:d8c:b0:8cd:79f2:dc3d with SMTP id af79cd13be357-8cda19f812bmr830432385a.26.1773322187926; Thu, 12 Mar 2026 06:29:47 -0700 (PDT) X-Received: by 2002:a05:620a:d8c:b0:8cd:79f2:dc3d with SMTP id af79cd13be357-8cda19f812bmr830426785a.26.1773322187398; Thu, 12 Mar 2026 06:29:47 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:46 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:30 +0200 Subject: [PATCH v3 09/27] drm/msm/mdss: use new helper to set min_acc length MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260312-ubwc-rework-v3-9-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1832; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=f+xu0X2Dvffg/en/Ri5kZ4UL9cHuySjQYKW8TgamZik=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+1jHsb426zm4uBrGigV+rm0TCVg4UZFxS4n iCmaHB12Q2JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/tQAKCRCLPIo+Aiko 1a+EB/9I+Mufht0YPVIuz1//POLvhN2ER/ApEdvJrcFQQ9P/xjK9eewewKpmFQWZ31l5lnmdj+B WDjRexmqPBJ89caruMpnFqK6O8DifeAq5T2YtPGtS64X2XXIXIEGSNqX/wRegJtKAhzxL9x8DCq jMeXyG75jz2ezsqphslt3BdjTGb+cWhnatfCUFihx+Z37Z6KC1zf/hFtlBYA6AH8yvcYhjoOboU 7rf2G5eyvk1R/0UV1alrzhdfUWqzv+Qu3Uh2JLNN9RwfinudH4dmtbh8OTQqEIDFHYsSKXzQsaq wea1b1Yx4MLs906RQZO1iy5MvwOI9QSVmZoMYbFQyPvh4h7L X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: no-kxfgFPG8h5Nht-ZrA7y_yc3lBZIvH X-Authority-Analysis: v=2.4 cv=BNG+bVQG c=1 sm=1 tr=0 ts=69b2bfcc cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=X-e67srwgh_QgMMAbO4A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: no-kxfgFPG8h5Nht-ZrA7y_yc3lBZIvH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX8xmSw1ACWgK6 dIHwEjjKPo1MhL6trNVQ7fTQfrrbZA2jm0/8pdcJ/Q8Wm7oJAkndJBrWvlL75qcVbJcYeOCmEGd DpsLfq3q9piRyNhubeF//hbg+k78MVbkdh8tNknOoSazIdw6/4wEbt7eKy9zof6WD6SmyvWkZV9 jQ29oRp3wEU+oKp1eg5JWp0Z3bz1n1hqdgPzjRytVP+6A4Rg7ku6nfUIugJu6A2WQl71WqHkMz1 EaBAKkWK0WmOti+mQ+scHw/eE3jl3wqI1PVGBDm1SZe4KowkU4fjZFZ4VD7OSm90HpU9i/fFNvc +lobbAPAObCR+hJpv0uJpEa0sdRhaaWzfnlUn+3wGikXqC7RYW/PrBNva9zRByZcLPNTrl1PZtY wAcRRCb0I0Zc4Tl+cX0/jB1OZarNmsIsAU8cV7I1QXElh+Y9AbgmsMWnrBmbR6ZKOZPRTzuls38 FyCE92oY5wJrzs76gPA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 adultscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Use freshly defined helper instead of hardcoding the checks in the driver. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index e2ec1ee590e7..565e671ee402 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -172,8 +172,7 @@ static void msm_mdss_4x_setup_ubwc(struct msm_mdss *msm_mdss) u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); - if (data->ubwc_enc_version == UBWC_1_0) - value |= MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); + value |= MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b(data)); writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); } @@ -190,8 +189,7 @@ static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm_mdss) if (data->ubwc_enc_version == UBWC_3_0) value |= MDSS_UBWC_STATIC_UBWC_AMSBC; - if (data->ubwc_enc_version == UBWC_1_0) - value |= MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); + value |= MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b(data)); writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); } @@ -209,8 +207,7 @@ static void msm_mdss_6x_setup_ubwc(struct msm_mdss *msm_mdss) if (data->macrotile_mode) value |= MDSS_UBWC_STATIC_MACROTILE_MODE; - if (data->ubwc_enc_version == UBWC_1_0) - value |= MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); + value |= MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b(data)); writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); -- 2.47.3