public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Animesh Manna <animesh.manna@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org
Cc: jouni.hogander@intel.com, imre.deak@intel.com,
	jani.nikula@intel.com, arun.r.murthy@intel.com,
	Animesh Manna <animesh.manna@intel.com>
Subject: [PATCH v7 3/3] drm/i915/display: Disable Panel Replay for DP-tunneling without optimization
Date: Thu, 12 Mar 2026 10:30:35 +0530	[thread overview]
Message-ID: <20260312050035.3493690-4-animesh.manna@intel.com> (raw)
In-Reply-To: <20260312050035.3493690-1-animesh.manna@intel.com>

As per DP specification,
    The DP Source device may optionally enable PR optimization
    with DP tunneling. The device shall query the Tunneling Bridge’s
    PR tunneling optimization capability by way of the
    Panel_Replay_Tunneling_Optimization_Support bit in the
    DP_TUNNELING_CAPABILITIES register (DPCD E000Dh[6]), and then enable PR
    only when the Tunneling Bridge is capable.

Therefore, do not enable Panel Replay for DP tunneling when optimization
support is not available.

Suggested-by: Jouni Högander <jouni.hogander@intel.com>
Signed-off-by: Animesh Manna <animesh.manna@intel.com>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 632527ede29f..3ec407a801b1 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1796,6 +1796,13 @@ static bool _panel_replay_compute_config(struct intel_crtc_state *crtc_state,
 	crtc_state->link_off_after_as_sdp_when_pr_active = compute_link_off_after_as_sdp_when_pr_active(connector);
 	crtc_state->disable_as_sdp_when_pr_active = compute_disable_as_sdp_when_pr_active(connector);
 
+	if (intel_dp_tunnel_bw_alloc_is_enabled(intel_dp) &&
+	    !intel_dp_tunnel_pr_optimization_supported(intel_dp)) {
+		drm_dbg_kms(display->drm,
+			    "Panel Replay is disabled as DP tunelling enabled without optimization\n");
+		return false;
+	}
+
 	if (!intel_dp_is_edp(intel_dp))
 		return true;
 
-- 
2.29.0


  parent reply	other threads:[~2026-03-12  5:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12  5:00 [PATCH v7 0/3] Panel Replay BW optimization Animesh Manna
2026-03-12  5:00 ` [PATCH v7 1/3] drm/i915/display: Add drm helper to check pr optimization support Animesh Manna
2026-03-12  6:40   ` Hogander, Jouni
2026-03-12  8:36     ` Manna, Animesh
2026-03-13  4:30   ` Claude review: " Claude Code Review Bot
2026-03-12  5:00 ` [PATCH v7 2/3] drm/i915/display: Panel Replay BW optimization for DP2.0 tunneling Animesh Manna
2026-03-12  6:44   ` Hogander, Jouni
2026-03-12  8:44     ` Manna, Animesh
2026-03-13  4:30   ` Claude review: " Claude Code Review Bot
2026-03-12  5:00 ` Animesh Manna [this message]
2026-03-12  6:17   ` [PATCH v7 3/3] drm/i915/display: Disable Panel Replay for DP-tunneling without optimization Hogander, Jouni
2026-03-12  8:33     ` Manna, Animesh
2026-03-13  4:30   ` Claude review: " Claude Code Review Bot
2026-03-12  8:05 ` [PATCH v7 0/3] Panel Replay BW optimization Hogander, Jouni
2026-03-12  8:41   ` Manna, Animesh
2026-03-12 15:18   ` Imre Deak
2026-03-13  4:30 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260312050035.3493690-4-animesh.manna@intel.com \
    --to=animesh.manna@intel.com \
    --cc=arun.r.murthy@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=jouni.hogander@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox