From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C0CBFED2F6 for ; Thu, 12 Mar 2026 09:14:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CA31D10E9B1; Thu, 12 Mar 2026 09:14:53 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="M3W2Ujtf"; dkim-atps=neutral Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 24C5610E9B1 for ; Thu, 12 Mar 2026 09:14:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1773306891; bh=zgxk0//QyziYfJrx3apL3fhL8/lCV/XFNVn/xnVYans=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=M3W2UjtfiSeUBzDdPZESNlEA+mDpdMKEKKVH/ByBojRFlcojHW3n7UF6kjGlwoR5K jnsvvFKl6y0HUp4eyN/5NiLaQJ+cZN5u9lBsL7G00jqoa9+2TgKNw7dP3fj5MJW3zA 6RWwKirJmEZCkvDd1U/xeLoMgCgzQeMyKKMnPBPgwcnMXTpko3XAgUgwt411i7sikI PIkd1p5Nzxs5FfLXL3jl87E4USIeHCuZVIbRTBQh+hxoux0LlI0itS+IlFSOqgx0ky 1nYNHV9kJfOvKSGg3gtwXQgba7s1wuCekro8T7tciFcbOu3X15ky7MPAzyGWr/huUl 6y4Hp1lSVMnmg== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:d919:a6e:5ea1:8a9f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 0E64A17E01B1; Thu, 12 Mar 2026 10:14:51 +0100 (CET) Date: Thu, 12 Mar 2026 10:14:47 +0100 From: Boris Brezillon To: Deborah Brouwer Cc: dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Danilo Krummrich , Alice Ryhl , Daniel Almeida , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Miguel Ojeda , Gary Guo , =?UTF-8?B?QmrDtnJu?= Roy Baron , Benno Lossin , Andreas Hindborg , Trevor Gross , Steven Price , Dirk Behme , Alexandre Courbot , Boqun Feng Subject: Re: [PATCH v2 1/5] drm/tyr: Use register! macro for GPU_CONTROL Message-ID: <20260312101447.52a867a6@fedora> In-Reply-To: <20260311-b4-tyr-use-register-macro-v2-v2-1-b936d9eb8f51@collabora.com> References: <20260311-b4-tyr-use-register-macro-v2-v2-0-b936d9eb8f51@collabora.com> <20260311-b4-tyr-use-register-macro-v2-v2-1-b936d9eb8f51@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 11 Mar 2026 16:03:58 -0700 Deborah Brouwer wrote: > + /// Support flags for compressed texture formats. Read only constant. > + pub(crate) TEXTURE_FEATURES_0(u32) @ 0xb0 { > + 31:0 format; That thing is a bitmap of supported formats, the index in the bitmap is an opaque format ID. s/format/supported_formats/ > + } How about we define that one as an array from the start: pub(crate) TEXTURE_FEATURES(u32)[4] @ 0xb0 { 31:0 supported_formats; }