From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51383106ACCF for ; Thu, 12 Mar 2026 16:48:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E099310EA6F; Thu, 12 Mar 2026 16:48:11 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; secure) header.d=bitbyteword.org header.i=@bitbyteword.org header.b="LZq/2ZuL"; dkim-atps=neutral Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id 432B410EA30 for ; Thu, 12 Mar 2026 15:05:39 +0000 (UTC) Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-7d7653db148so821255a34.2 for ; Thu, 12 Mar 2026 08:05:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bitbyteword.org; s=google; t=1773327938; x=1773932738; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cNc1V3lTb2QUW0xjd0W9BOVRtnhujjy4WaV1yGr6BKQ=; b=LZq/2ZuLY9AgMoYSWTubX/qsG6sRFdco6GSeMtPlizBO92vftgr1cYKukcuJIpiFAV Sazbu9ftqSo5vPflBZEV8gvCt/klZ7xCTzviVH9iaVdhU1h22mWJ1FS41WWyU0iOkcHd seHvraATsw3KUoIZfZgxzakRExs1+vVOisNfLucfw75gfa+TCdnf36+ezjf7Tm2il4uQ zMBMKeFv51OkuBco7wZPBBX7I9Mf8ACh2B5NVWeCQSI61K0sCZTiEeVk4mcWeYD0IkSO UTh56AcTnq8eDeS8fMd1s7ZUkH2ipXKuXOevJdJIORqgJaRtG666amDo3FpsYPeL1H4X wPRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773327938; x=1773932738; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cNc1V3lTb2QUW0xjd0W9BOVRtnhujjy4WaV1yGr6BKQ=; b=tUUj9Q5FMtmxHd1FV2fzDLY33Q1V3sjNUmHIcy8QojYqPy3T0OeU0cbBRUMv1hhBqy 2zxNNF3p5uuBUD/4lVxeaFO/RFeRzrU+JKcUkabTQ35dTL3R6Ha36l5r2IKvOeSoUqC7 Nzu1o20nf4ZF9kxGywJXcuhucZl8d5mXh7hsiOVwJodNYk6GJQyhxNvilZOWwaaS3O55 wYkVMKHTO9hvIUQAoKh2/mfSgNaaLrw+ZlekC/01jYUbDWstUSB599MNKb52/u68qL0b q5LaG+rKLiPhXz4V3UefMg74Ue1vYfRChvKW/BmS3a3tfMqxFBPfdjX6tRV+PgAd1YiA 7GtA== X-Forwarded-Encrypted: i=1; AJvYcCVyOowzuu6J9iX6y/OiSpxdwm9fwz9IuXejeZyVcDcDoRqdaGiIE3sGVfyLbkeV+vDWpwpj227s+k8=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwAlw53Q3SeDPCpkRXe0ExYkf+3PMW0TWN1v7rpT52zwkmK4f5b JBBAA5E4y4E6ASOMWnTrgIjx4fAppRbnq1b7U6B8c9UvM9noUSL8XX78xSy42WpUTx4= X-Gm-Gg: ATEYQzzmyxxOc3fPddn63ojxOL6BnHuGhFXOd3mNLSzqvSub8y+UjGKBCQlflutrT5o hg5yO0IM+sMGhludg9Lw9V2xk8ICA7bVkgNILdVIzW0CaQm+1YyuzC3fyXT713mmJjAGOs69EAu +8oSV4hD1tUd98IY1RLGkG6XhQFlPjeB2+rhJNOwt+lrP0dU4P5J1auI5gQMpb3kf3c98+kT0TW yYzatnt6iV8tzGQtFZJemg5D9qWvVrGRDdAn0X/AAHw2kAUF8FxYHw/eDH8YE8x+J3H09PzKQwe Sb7lmlH839b7dCryNrr/h9ae9beEgxHe35nn1adGrljcWraTrq4Aliy0wzZ4c83A0t7/B8p93B9 2L/VwfVhcVwsSJzZUitIaHUzYnwdpxr/B39S188MSrQ5xmTFHHeTQZjecdRgLLg1dlZRnojzi6x K/Z6aBDAZ7ntrkKjc2ZG0ONZs9n8zBdKuxO2tA1ILo4XfxhogZ7yHgS3R5BTM9exkK/ZJWrNeeV 2Cn X-Received: by 2002:a05:6830:3113:b0:7c6:d001:afb2 with SMTP id 46e09a7af769-7d76a85b34cmr3668805a34.35.1773327936791; Thu, 12 Mar 2026 08:05:36 -0700 (PDT) Received: from vinmini.lan (c-73-143-21-186.hsd1.vt.comcast.net. [73.143.21.186]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d76aedae57sm4321776a34.28.2026.03.12.08.05.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 08:05:36 -0700 (PDT) From: "Vineeth Pillai (Google)" To: Steven Rostedt , Peter Zijlstra , Dmitry Ilvokhin Cc: "Vineeth Pillai (Google)" , Masami Hiramatsu , Mathieu Desnoyers , Ingo Molnar , Jens Axboe , io-uring@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Marcelo Ricardo Leitner , Xin Long , Jon Maloy , Aaron Conole , Eelco Chaudron , Ilya Maximets , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-sctp@vger.kernel.org, tipc-discussion@lists.sourceforge.net, dev@openvswitch.org, Oded Gabbay , Koby Elbaz , dri-devel@lists.freedesktop.org, "Rafael J. Wysocki" , Viresh Kumar , "Gautham R. Shenoy" , Huang Rui , Mario Limonciello , Len Brown , Srinivas Pandruvada , linux-pm@vger.kernel.org, MyungJoo Ham , Kyungmin Park , Chanwoo Choi , =?UTF-8?q?Christian=20K=C3=B6nig?= , Sumit Semwal , linaro-mm-sig@lists.linaro.org, Eddie James , Andrew Jeffery , Joel Stanley , linux-fsi@lists.ozlabs.org, David Airlie , Simona Vetter , Alex Deucher , Danilo Krummrich , Matthew Brost , Philipp Stanner , Harry Wentland , Leo Li , amd-gfx@lists.freedesktop.org, Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, Wolfram Sang , linux-i2c@vger.kernel.org, Mark Brown , Michael Hennerich , =?UTF-8?q?Nuno=20S=C3=A1?= , linux-spi@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, Chris Mason , David Sterba , linux-btrfs@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/15] tracepoint: Add trace_invoke_##name() API Date: Thu, 12 Mar 2026 11:04:56 -0400 Message-ID: <20260312150523.2054552-2-vineeth@bitbyteword.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260312150523.2054552-1-vineeth@bitbyteword.org> References: <20260312150523.2054552-1-vineeth@bitbyteword.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Thu, 12 Mar 2026 16:48:06 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Add trace_invoke_##name() as a companion to trace_##name(). When a caller already guards a tracepoint with an explicit enabled check: if (trace_foo_enabled() && cond) trace_foo(args); trace_foo() internally repeats the static_branch_unlikely() test, which the compiler cannot fold since static branches are patched binary instructions. This results in two static-branch evaluations for every guarded call site. trace_invoke_##name() calls __do_trace_##name() directly, skipping the redundant static-branch re-check. This avoids leaking the internal __do_trace_##name() symbol into call sites while still eliminating the double evaluation: if (trace_foo_enabled() && cond) trace_invoke_foo(args); /* calls __do_trace_foo() directly */ Three locations are updated: - __DECLARE_TRACE: invoke form omits static_branch_unlikely, retains the LOCKDEP RCU-watching assertion. - __DECLARE_TRACE_SYSCALL: same, plus retains might_fault(). - !TRACEPOINTS_ENABLED stub: empty no-op so callers compile cleanly when tracepoints are compiled out. Suggested-by: Steven Rostedt Suggested-by: Peter Zijlstra Signed-off-by: Vineeth Pillai (Google) Assisted-by: Claude:claude-sonnet-4-6 --- include/linux/tracepoint.h | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h index 22ca1c8b54f32..07219316a8e14 100644 --- a/include/linux/tracepoint.h +++ b/include/linux/tracepoint.h @@ -294,6 +294,10 @@ static inline struct tracepoint *tracepoint_ptr_deref(tracepoint_ptr_t *p) WARN_ONCE(!rcu_is_watching(), \ "RCU not watching for tracepoint"); \ } \ + } \ + static inline void trace_invoke_##name(proto) \ + { \ + __do_trace_##name(args); \ } #define __DECLARE_TRACE_SYSCALL(name, proto, args, data_proto) \ @@ -313,6 +317,11 @@ static inline struct tracepoint *tracepoint_ptr_deref(tracepoint_ptr_t *p) WARN_ONCE(!rcu_is_watching(), \ "RCU not watching for tracepoint"); \ } \ + } \ + static inline void trace_invoke_##name(proto) \ + { \ + might_fault(); \ + __do_trace_##name(args); \ } /* @@ -398,6 +407,8 @@ static inline struct tracepoint *tracepoint_ptr_deref(tracepoint_ptr_t *p) #define __DECLARE_TRACE_COMMON(name, proto, args, data_proto) \ static inline void trace_##name(proto) \ { } \ + static inline void trace_invoke_##name(proto) \ + { } \ static inline int \ register_trace_##name(void (*probe)(data_proto), \ void *data) \ -- 2.53.0