From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A6CF106ACCF for ; Thu, 12 Mar 2026 16:48:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D3DA210EA6A; Thu, 12 Mar 2026 16:48:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; secure) header.d=bitbyteword.org header.i=@bitbyteword.org header.b="YDj3AA1p"; dkim-atps=neutral Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id AFCB010EA30 for ; Thu, 12 Mar 2026 15:05:51 +0000 (UTC) Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-7d7422b4ff1so506444a34.3 for ; Thu, 12 Mar 2026 08:05:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bitbyteword.org; s=google; t=1773327951; x=1773932751; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hYEV1IZi65arMtRDq7eHdk/s/1eZwkkGUhZ8AENKDgw=; b=YDj3AA1pDXMNcjB0NuA/BPuL3ppAaFP0GWgk7GL20IHmQCCEfRhy+BFDUoXgu0PD/l +3awwdVjmVOA9PcbYKUXRgR/xFvfjXGn7GzwCWKgDd6YSHtjRLd/P/D4mCZYzyV3cVpO kudZ80jJ/qm9gQMHO+sIMWSPxczs7xWWcsAwKRpAmKooclJEOcxq+cCJA5bOY5WatH1U HFVzSlJHNznqJxOF2sOA/e/fvOqwGLEmOocSkFjmPJTd0e/0vQP4/F3Vz3PZrkHvju/l 5TnCCax62rlL4gC9glvYULnpWFeuhb0njPJvx0kFEup7XeWUGXVnwqCfznaYOL3fFPZK eMqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773327951; x=1773932751; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hYEV1IZi65arMtRDq7eHdk/s/1eZwkkGUhZ8AENKDgw=; b=YYtlLmhU6xW63EM9KYTSZUnYeETMtpId5JXHQnJEHJSfP6sLl5kxOJjhJEv85dPt3A eQx6ADDifi2vPBRJcniPQm3MigBtJwsOPCSsGqA5PN3MGexNZlux2uxgnOxqCNYSVCoB e2d+FDiMTXydC6YP1tRXthFQ6irQtKFCNi6M+y5GFNmU6spBUOu18K2rYv3+U+CEi1Ef 2oVSeB9ln9FiVZg5Wx7UUM5Rc5074G42axgyQK4uIsz7H8PLlHMogye8Vdgjalp5YzYP qEIT9wh/fgstYiRPCAex9tV1XmqYO5IoIYnNd2wlrpaLs4pCgE3I0xijWeoXEcjXNvRM teYA== X-Forwarded-Encrypted: i=1; AJvYcCUzQo8BUNouJ5DR30kOfB46v2zWTLbXw89oRiMJyXzPxCm1Rl6VnPFejObWa4rOzIBa8G8NbYjmiyY=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwHV3LCsjkzSyNA0xIVFiLpl2IQWuhpvlAkWFK0Vmhml8cj8bqN vd6AQX2E0LinPgm/XVCdPVV/Lx9h60B/iqtafnG2CiKWFZyG4ZJIYS9Zn61UP7pIWa0= X-Gm-Gg: ATEYQzzqcgQJt9YDKpAw6YctXti1wFX22GHkw/B0ty3HlG8p/xPnbJGaCvVb645UgPh 7H1Wc93lRRHvuNJ0D0IlWJsUz8bXYHBticpmXd6lwo4fRvBqO7wMlXYwQLSRHg597Rspfap+fyw hlO52eTANugl3H7yoDcjAsqk1WyXuyZuaq0zR1iWQYH17OLydDryOQdg7k/B4IVFOih/qTpF+oX bY3n38IbAkQ104Ps1nDhGsQ/4bkUYKukvErldTXD42Uqd4GOAo/IXqeZ3A9ik648BdpOsLjEeZ6 BEcLGvyQSlow4fjdKF3ciYSNsZpgMZcdHpk3R+pjyEmzVkrmjSAyoUOF7otYnA/k5fmvFfYxpRr 9QAY4MQoOG3yQ5KhhDnzXBpe2WdmGZR3z/9bEMqWyp0hQE4BomgGLhfNZhpYEEW24oe6ToFk/VX VuotUVrDIoLC1NIq38yMT7ijlTbVcX/EZvNZe/WyaSWWrjxQivHZpTHow0kihYonDbHLQwvUGhL NvS X-Received: by 2002:a05:6830:3888:b0:7ce:2b34:deca with SMTP id 46e09a7af769-7d76a811b11mr4066142a34.28.1773327950878; Thu, 12 Mar 2026 08:05:50 -0700 (PDT) Received: from vinmini.lan (c-73-143-21-186.hsd1.vt.comcast.net. [73.143.21.186]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d76aedae57sm4321776a34.28.2026.03.12.08.05.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 08:05:50 -0700 (PDT) From: "Vineeth Pillai (Google)" To: Cc: "Vineeth Pillai (Google)" , Steven Rostedt , Peter Zijlstra , Koby Elbaz , Konstantin Sinyuk , Oded Gabbay , Kees Cook , Yaron Avizrat , Easwar Hariharan , Andy Shevchenko , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH 05/15] accel/habanalabs: Use trace_invoke_##name() at guarded tracepoint call sites Date: Thu, 12 Mar 2026 11:05:00 -0400 Message-ID: <20260312150523.2054552-6-vineeth@bitbyteword.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260312150523.2054552-1-vineeth@bitbyteword.org> References: <20260312150523.2054552-1-vineeth@bitbyteword.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Thu, 12 Mar 2026 16:48:06 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Replace trace_foo() with the new trace_invoke_foo() at sites already guarded by trace_foo_enabled(), avoiding a redundant static_branch_unlikely() re-evaluation inside the tracepoint. trace_invoke_foo() calls the tracepoint callbacks directly without utilizing the static branch again. Suggested-by: Steven Rostedt Suggested-by: Peter Zijlstra Signed-off-by: Vineeth Pillai (Google) Assisted-by: Claude:claude-sonnet-4-6 --- drivers/accel/habanalabs/common/device.c | 12 ++++++------ drivers/accel/habanalabs/common/mmu/mmu.c | 3 ++- drivers/accel/habanalabs/common/pci/pci.c | 4 ++-- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/accel/habanalabs/common/device.c b/drivers/accel/habanalabs/common/device.c index 09b27bac3a31d..d38cdb5c6c32a 100644 --- a/drivers/accel/habanalabs/common/device.c +++ b/drivers/accel/habanalabs/common/device.c @@ -132,8 +132,8 @@ static void *hl_dma_alloc_common(struct hl_device *hdev, size_t size, dma_addr_t } if (trace_habanalabs_dma_alloc_enabled() && !ZERO_OR_NULL_PTR(ptr)) - trace_habanalabs_dma_alloc(&(hdev)->pdev->dev, (u64) (uintptr_t) ptr, *dma_handle, - size, caller); + trace_invoke_habanalabs_dma_alloc(&(hdev)->pdev->dev, (u64) (uintptr_t) ptr, + *dma_handle, size, caller); return ptr; } @@ -206,7 +206,7 @@ int hl_dma_map_sgtable_caller(struct hl_device *hdev, struct sg_table *sgt, return 0; for_each_sgtable_dma_sg(sgt, sg, i) - trace_habanalabs_dma_map_page(&(hdev)->pdev->dev, + trace_invoke_habanalabs_dma_map_page(&(hdev)->pdev->dev, page_to_phys(sg_page(sg)), sg->dma_address - prop->device_dma_offset_for_host_access, #ifdef CONFIG_NEED_SG_DMA_LENGTH @@ -249,7 +249,7 @@ void hl_dma_unmap_sgtable_caller(struct hl_device *hdev, struct sg_table *sgt, if (trace_habanalabs_dma_unmap_page_enabled()) { for_each_sgtable_dma_sg(sgt, sg, i) - trace_habanalabs_dma_unmap_page(&(hdev)->pdev->dev, + trace_invoke_habanalabs_dma_unmap_page(&(hdev)->pdev->dev, page_to_phys(sg_page(sg)), sg->dma_address - prop->device_dma_offset_for_host_access, #ifdef CONFIG_NEED_SG_DMA_LENGTH @@ -2656,7 +2656,7 @@ inline u32 hl_rreg(struct hl_device *hdev, u32 reg) u32 val = readl(hdev->rmmio + reg); if (unlikely(trace_habanalabs_rreg32_enabled())) - trace_habanalabs_rreg32(&(hdev)->pdev->dev, reg, val); + trace_invoke_habanalabs_rreg32(&(hdev)->pdev->dev, reg, val); return val; } @@ -2674,7 +2674,7 @@ inline u32 hl_rreg(struct hl_device *hdev, u32 reg) inline void hl_wreg(struct hl_device *hdev, u32 reg, u32 val) { if (unlikely(trace_habanalabs_wreg32_enabled())) - trace_habanalabs_wreg32(&(hdev)->pdev->dev, reg, val); + trace_invoke_habanalabs_wreg32(&(hdev)->pdev->dev, reg, val); writel(val, hdev->rmmio + reg); } diff --git a/drivers/accel/habanalabs/common/mmu/mmu.c b/drivers/accel/habanalabs/common/mmu/mmu.c index 6c7c4ff8a8a95..4541146727028 100644 --- a/drivers/accel/habanalabs/common/mmu/mmu.c +++ b/drivers/accel/habanalabs/common/mmu/mmu.c @@ -263,7 +263,8 @@ int hl_mmu_unmap_page(struct hl_ctx *ctx, u64 virt_addr, u32 page_size, bool flu mmu_funcs->flush(ctx); if (trace_habanalabs_mmu_unmap_enabled() && !rc) - trace_habanalabs_mmu_unmap(&hdev->pdev->dev, virt_addr, 0, page_size, flush_pte); + trace_invoke_habanalabs_mmu_unmap(&hdev->pdev->dev, virt_addr, + 0, page_size, flush_pte); return rc; } diff --git a/drivers/accel/habanalabs/common/pci/pci.c b/drivers/accel/habanalabs/common/pci/pci.c index 81cbd8697d4cd..a867ad694e38c 100644 --- a/drivers/accel/habanalabs/common/pci/pci.c +++ b/drivers/accel/habanalabs/common/pci/pci.c @@ -123,7 +123,7 @@ int hl_pci_elbi_read(struct hl_device *hdev, u64 addr, u32 *data) pci_read_config_dword(pdev, mmPCI_CONFIG_ELBI_DATA, data); if (unlikely(trace_habanalabs_elbi_read_enabled())) - trace_habanalabs_elbi_read(&hdev->pdev->dev, (u32) addr, val); + trace_invoke_habanalabs_elbi_read(&hdev->pdev->dev, (u32) addr, val); return 0; } @@ -186,7 +186,7 @@ static int hl_pci_elbi_write(struct hl_device *hdev, u64 addr, u32 data) if ((val & PCI_CONFIG_ELBI_STS_MASK) == PCI_CONFIG_ELBI_STS_DONE) { if (unlikely(trace_habanalabs_elbi_write_enabled())) - trace_habanalabs_elbi_write(&hdev->pdev->dev, (u32) addr, val); + trace_invoke_habanalabs_elbi_write(&hdev->pdev->dev, (u32) addr, val); return 0; } -- 2.53.0