public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Jouni Högander <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org,
	Jouni Högander <jouni.hogander@intel.com>
Subject: [PATCH 1/2] drm/dp: Add quirk to disable Panel Replay on certain panels
Date: Fri, 13 Mar 2026 14:21:44 +0200	[thread overview]
Message-ID: <20260313122145.1747175-2-jouni.hogander@intel.com> (raw)
In-Reply-To: <20260313122145.1747175-1-jouni.hogander@intel.com>

We are currently observing problems with LG panel when Panel Replay is
enabled. Add new quirk DP_DPCD_QUIRK_NO_PANEL_REPLAY and set it for
the problematic panel model.

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/display/drm_dp_helper.c | 2 ++
 include/drm/display/drm_dp_helper.h     | 8 ++++++++
 2 files changed, 10 insertions(+)

diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c
index a697cc227e28..96c8b53ba4e4 100644
--- a/drivers/gpu/drm/display/drm_dp_helper.c
+++ b/drivers/gpu/drm/display/drm_dp_helper.c
@@ -2540,6 +2540,8 @@ static const struct dpcd_quirk dpcd_quirk_list[] = {
 	{ OUI(0x00, 0x22, 0xb9), DEVICE_ID_ANY, true, BIT(DP_DPCD_QUIRK_CONSTANT_N) },
 	/* LG LP140WF6-SPM1 eDP panel */
 	{ OUI(0x00, 0x22, 0xb9), DEVICE_ID('s', 'i', 'v', 'a', 'r', 'T'), false, BIT(DP_DPCD_QUIRK_CONSTANT_N) },
+	/* Problems observed with LG panel */
+	{ OUI(0x00, 0x22, 0xb9), DEVICE_ID_ANY, false, BIT(DP_DPCD_QUIRK_NO_PANEL_REPLAY) },
 	/* Apple panels need some additional handling to support PSR */
 	{ OUI(0x00, 0x10, 0xfa), DEVICE_ID_ANY, false, BIT(DP_DPCD_QUIRK_NO_PSR) },
 	/* CH7511 seems to leave SINK_COUNT zeroed */
diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h
index 1d0acd58f486..ca36b5a9c1b6 100644
--- a/include/drm/display/drm_dp_helper.h
+++ b/include/drm/display/drm_dp_helper.h
@@ -824,6 +824,14 @@ enum drm_dp_quirk {
 	 * driver still need to implement proper handling for such device.
 	 */
 	DP_DPCD_QUIRK_NO_PSR,
+	/**
+	 * @DP_DPCD_QUIRK_NO_PANEL_REPLAY:
+	 *
+	 * The device does not support Panel Replay even if reports
+	 * that it supports or driver still need to implement proper
+	 * handling for such device.
+	 */
+	DP_DPCD_QUIRK_NO_PANEL_REPLAY,
 	/**
 	 * @DP_DPCD_QUIRK_NO_SINK_COUNT:
 	 *
-- 
2.43.0


  reply	other threads:[~2026-03-13 12:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13 12:21 [PATCH 0/2] Disable Panel Replay as quirk for LGD panel Jouni Högander
2026-03-13 12:21 ` Jouni Högander [this message]
2026-03-13 21:04   ` Claude review: drm/dp: Add quirk to disable Panel Replay on certain panels Claude Code Review Bot
2026-03-13 12:21 ` [PATCH 2/2] drm/i915/psr: Disable Panel Replay on DP_DPCD_QUIRK_NO_PANEL_REPLAY quirk Jouni Högander
2026-03-13 21:04   ` Claude review: " Claude Code Review Bot
2026-03-13 21:04 ` Claude review: Disable Panel Replay as quirk for LGD panel Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260313122145.1747175-2-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox