From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFF2F107BCEE for ; Sat, 14 Mar 2026 01:09:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1E93810EC71; Sat, 14 Mar 2026 01:09:37 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="SIAneFIH"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SNDIF6sk"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0845F10ECCB for ; Sat, 14 Mar 2026 01:09:33 +0000 (UTC) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62DHMntJ1498952 for ; Sat, 14 Mar 2026 01:09:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XHiLCL2Q/VJoKNHmnopqEVjk+hwroQfPTl82ni3pxPw=; b=SIAneFIHYzYtdSvw i9c457l72+BFGZ/KasS3k2GREWqF6viYExSWOfuXX8gmy6qwS6Io5Pods97BxbJu nckolsBAE7yW+SOf0f+WKlKS3jCDyCKXUsWC6unEc+fVbB1W5z1nRFexUiFyE6xv XNdMPsfgPDrjCvUy/oHi26aKwInwIWXvf3xDy0eIfmpbAUM8r9Lng938kNTViaAY R9b1cWohv1UUFGfagfM82n4REkqPv51u/Jro5UVnMg72EYPlnkPCkSdblqvD1GBA YAALyr0aowIdAqfiJaKbdoIPeO2jbJTkZV8UmW2Q/YOt08j4wYFNnCYMtOEQFIPy iTBHow== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cvg0hjsu4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 14 Mar 2026 01:09:33 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cb6291d95aso2731863785a.1 for ; Fri, 13 Mar 2026 18:09:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773450572; x=1774055372; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XHiLCL2Q/VJoKNHmnopqEVjk+hwroQfPTl82ni3pxPw=; b=SNDIF6skTemBrQkpW44BoE3FHxIsiWZnk++X8wX5ZA3Osgz8HVKDaS8hO4YgTqU/nh TKvLdootIh6cTtNQlTGIf6eGNCIj05ycxG6YVLlV/XNIx/BLAw2TfAxb2MjKOqtceqIE qSq1POsjLMFSNZUJnKrtUTdH8+Ko/6cGYDKU3nAv9CpZmyQOOJdcnZDFvmyMXuGKT+Tj FOjE1RMr4L7/biPo93l9MDdU8v8lPM11nKyfyyDnQr/KApDnrDgrlsTO9VfM3Y+esGlT hcLKyRGR9hUbI79huiiosfECBP/mIgQl11ldqisd+Tj8CTJm3MGiJdcQXXBuiVx5VHTj tfbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773450572; x=1774055372; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=XHiLCL2Q/VJoKNHmnopqEVjk+hwroQfPTl82ni3pxPw=; b=LtB43V59UKoJj87K2xe2GWQi8lf9GkL3yc6wVt4Kzc0tiDJwa0LUma9PQhslG7zumT bg/3ayKDi1q2puGohEg2eX2uAOCnCZhL3+aNB6bsEtgtFNBBXeaDlvLlN+9rKFzFU+bW 8NONOeDYFlFoTdI7a2Zg7NoqBGycr7ZgLbrXaebNACoF8EKA4rtRXXWR08s7yc9Q00AH rkrrdQ5e6/r6MwbkxEjzAKLE1fYvlsNuw5URPHYBkQEDu0wbcaJWiTykHaggmG72sGop bvmDi2xqd71Ph+zjiEWgGyOA1Kq88+vxBx4Vm8APdA+i+hbFfPm+HTvDp+YGc4l6vIK+ 5bHA== X-Forwarded-Encrypted: i=1; AJvYcCVFuWEQZt30WMnIcvjT1GvP9JZnuI08OVY0qw9ZWdMAh8gOVyL5A7OrT0rUx9iYRLKq7hMdpRdO2jM=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yw6dNdyZRRE81w7sI6X3mN+R+G9Aq45fhdVXw86KW+HnBd4/VPY 8TvekJMexkj09bOesvh9rH1mgI98+B2HaZeZbf9SZflDobP+Cmt+RHIW167Y92/X/NswOxywjlk JsTQxZdys1bxL+T/sZBrr5vql4SvMXSsuwehwDy2GDndVPoqtjGbzPdasRxahmm29EqV8k5U= X-Gm-Gg: ATEYQzw5MSOs832+AlR0qhsiGBRZ0kd/7c52N/AI9rT8+UyoyYrzM3sVC/UovXSRbzC T6/Lz0xaQJ2VZwuNoaSv5Aqg3C2br7q0Ua+dxERt1c0rD3HCndxwaFER1rRTT84QdMVtZ8yssRJ q9rdP0S14kmLIZulFwXASu6FByrqIKk8fxZryoXCrlm7R2TZdU38numI20OQHCXvRBgpidC6ljC ZhFLxGb3T6ulIkVfIl8p4Momg7e8Q3GBl70zwuEJOFDQrqeHWmqeKG4EAT5lYsuJ4OBVziiHRlA ymTvEPZbA29MLJpLVwY83LN9g89dJ8xHjC7zGq7AIq3kyJ0xgUXVZjBigcGm+XM8YS6LbavcCLO ohhbXEfr5dOy1NIcI6sJnwQ8r/Ngx87hZXlslKlbHwZuRU8HZotxuoK5HZgNrhpQQ/VPSbtIx+R PRkch604pYSH5ypT8u7GSn6XLy7j8WV753SN0= X-Received: by 2002:a05:620a:40c7:b0:8c7:1986:6b3e with SMTP id af79cd13be357-8cdb5a9e986mr769565285a.32.1773450572536; Fri, 13 Mar 2026 18:09:32 -0700 (PDT) X-Received: by 2002:a05:620a:40c7:b0:8c7:1986:6b3e with SMTP id af79cd13be357-8cdb5a9e986mr769561985a.32.1773450571974; Fri, 13 Mar 2026 18:09:31 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a156366b22sm1806805e87.77.2026.03.13.18.09.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 18:09:29 -0700 (PDT) From: Dmitry Baryshkov Date: Sat, 14 Mar 2026 03:09:10 +0200 Subject: [PATCH v5 06/10] drm/msm/dp: drop event data MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260314-hpd-refactor-v5-6-0c8450737d64@oss.qualcomm.com> References: <20260314-hpd-refactor-v5-0-0c8450737d64@oss.qualcomm.com> In-Reply-To: <20260314-hpd-refactor-v5-0-0c8450737d64@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Kuogee Hsieh , Yongxing Mou Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=5908; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=uXjrwf6kVU4yfPAvO2dRImodIsQs6Els2Ljkho09jGo=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBptLUzZ2VstDQcB4PSoYDcuWy2wYNQsofcctUxZ JuPfGzZpHOJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabS1MwAKCRCLPIo+Aiko 1Xx9B/wNTzCyzrkjOiq6O/FZ0Q5qkNJinQZmVe6SQM5AmzOtzXD2KKnqSOArT57vXmDMBsXYPIx Dembn3NJGuT3NdbV+BG5/udtsbjkh31ptutuVZWmAW/VLXaBq/57EQyUdQM5NvS7iejHuyp3Ke6 2kL0643sIgryGo/KILVpsSUDLUiobOFEaEak1riNis8EEUSHjvBQkQ0nD0fcRPYIZAOQFgxc6d+ OzjxOeGLCFxY17EXsjlaK4UYlj/8aGmg2v1f4fGUdLdkaLIAD7mWCrNwzPlI00+6PgCS9Q08dA+ ekVY/6QQXtSms0YTKXmpHoMt+iFwF5NaA2iUoHH/WpgXmNMe X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=T6eBjvKQ c=1 sm=1 tr=0 ts=69b4b54d cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=zd47t_UtYfsHpvN5YEcA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: 9ZDhUafszDV9uoPtLjDg3oGtKMSHrxio X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE0MDAwNiBTYWx0ZWRfX7Q58OoBM6BW+ WldWv8OykWC6NoCrwEXGNyqg3CqJlmsOfsm4RZz8/ObsHItjl3yEoEntRFRLEtGBxkRUEfOOgQI SY+fUz/sI1XuPY6OSiIvFcYhkFNa9KrJBxBa+9C5x7TAfUrsXyRY7KweG/HbTF+xEV/aWQqMqzu xvjAcu269vbg2QlDt4P5eGoastqB1AuNmBKIkCDzO0okfmUpSTavBfrxVkRmHcWpgJBwhpAHzOG TSg5oZ5uF5OIW9aJxXTm382Rs/PeAPeQr66H+hcpqbw+WZ6i7E/YpAVXLVvGujrwJkqePz7vn4A SA9YXVHVNK6Ro/oRIfBJWsTl6WmiBGlMw4NhisC48KlMNNWBFPmuhRHx8fwE2GZ/lABHhOE2y9J WX0nAvmAI9iWrQA153ZaO0YD4z26/iePdcwOcrerQrq+VRRU++3MHU8Lp5/wMaEvwhRYrz4eewJ I6dzd/glBoGbPw+Oe9w== X-Proofpoint-GUID: 9ZDhUafszDV9uoPtLjDg3oGtKMSHrxio X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_05,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 suspectscore=0 bulkscore=0 phishscore=0 impostorscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603140006 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" With EV_USER_NOTIFICATION gone event's data is no longer useful. Drop it, removing also the argument from event handlers. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 39 +++++++++++++++++-------------------- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 05c292e27126..bc4078c229cb 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -69,7 +69,6 @@ enum { struct msm_dp_event { u32 event_id; - u32 data; u32 delay; }; @@ -218,7 +217,7 @@ static struct msm_dp_display_private *dev_get_dp_display_private(struct device * } static int msm_dp_add_event(struct msm_dp_display_private *msm_dp_priv, u32 event, - u32 data, u32 delay) + u32 delay) { unsigned long flag; struct msm_dp_event *todo; @@ -236,7 +235,6 @@ static int msm_dp_add_event(struct msm_dp_display_private *msm_dp_priv, u32 even todo = &msm_dp_priv->event_list[msm_dp_priv->event_pndx++]; msm_dp_priv->event_pndx %= DP_EVENT_Q_MAX; todo->event_id = event; - todo->data = data; todo->delay = delay; wake_up(&msm_dp_priv->event_q); spin_unlock_irqrestore(&msm_dp_priv->event_lock, flag); @@ -576,7 +574,7 @@ static int msm_dp_display_usbpd_attention_cb(struct device *dev) return rc; } -static int msm_dp_hpd_plug_handle(struct msm_dp_display_private *dp, u32 data) +static int msm_dp_hpd_plug_handle(struct msm_dp_display_private *dp) { u32 state; int ret; @@ -602,7 +600,7 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_display_private *dp, u32 data) if (state == ST_DISCONNECT_PENDING) { /* wait until ST_DISCONNECTED */ - msm_dp_add_event(dp, EV_HPD_PLUG_INT, 0, 1); /* delay = 1 */ + msm_dp_add_event(dp, EV_HPD_PLUG_INT, 1); mutex_unlock(&dp->event_mutex); return 0; } @@ -644,7 +642,7 @@ static void msm_dp_display_handle_plugged_change(struct msm_dp *msm_dp_display, plugged); } -static int msm_dp_hpd_unplug_handle(struct msm_dp_display_private *dp, u32 data) +static int msm_dp_hpd_unplug_handle(struct msm_dp_display_private *dp) { u32 state; struct platform_device *pdev = dp->msm_dp_display.pdev; @@ -706,7 +704,7 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_display_private *dp, u32 data) return 0; } -static int msm_dp_irq_hpd_handle(struct msm_dp_display_private *dp, u32 data) +static int msm_dp_irq_hpd_handle(struct msm_dp_display_private *dp) { u32 state; @@ -724,7 +722,7 @@ static int msm_dp_irq_hpd_handle(struct msm_dp_display_private *dp, u32 data) if (state == ST_MAINLINK_READY || state == ST_DISCONNECT_PENDING) { /* wait until ST_CONNECTED */ - msm_dp_add_event(dp, EV_IRQ_HPD_INT, 0, 1); /* delay = 1 */ + msm_dp_add_event(dp, EV_IRQ_HPD_INT, 1); mutex_unlock(&dp->event_mutex); return 0; } @@ -1079,7 +1077,6 @@ static int hpd_event_thread(void *data) todo_next = &msm_dp_priv->event_list[msm_dp_priv->event_pndx++]; msm_dp_priv->event_pndx %= DP_EVENT_Q_MAX; todo_next->event_id = todo->event_id; - todo_next->data = todo->data; todo_next->delay = todo->delay - 1; /* clean up older event */ @@ -1105,13 +1102,13 @@ static int hpd_event_thread(void *data) switch (todo->event_id) { case EV_HPD_PLUG_INT: - msm_dp_hpd_plug_handle(msm_dp_priv, todo->data); + msm_dp_hpd_plug_handle(msm_dp_priv); break; case EV_HPD_UNPLUG_INT: - msm_dp_hpd_unplug_handle(msm_dp_priv, todo->data); + msm_dp_hpd_unplug_handle(msm_dp_priv); break; case EV_IRQ_HPD_INT: - msm_dp_irq_hpd_handle(msm_dp_priv, todo->data); + msm_dp_irq_hpd_handle(msm_dp_priv); break; default: break; @@ -1212,19 +1209,19 @@ static irqreturn_t msm_dp_display_irq_handler(int irq, void *dev_id) dp->msm_dp_display.connector_type, hpd_isr_status); /* hpd related interrupts */ if (hpd_isr_status & DP_DP_HPD_PLUG_INT_MASK) - msm_dp_add_event(dp, EV_HPD_PLUG_INT, 0, 0); + msm_dp_add_event(dp, EV_HPD_PLUG_INT, 0); if (hpd_isr_status & DP_DP_IRQ_HPD_INT_MASK) { - msm_dp_add_event(dp, EV_IRQ_HPD_INT, 0, 0); + msm_dp_add_event(dp, EV_IRQ_HPD_INT, 0); } if (hpd_isr_status & DP_DP_HPD_REPLUG_INT_MASK) { - msm_dp_add_event(dp, EV_HPD_UNPLUG_INT, 0, 0); - msm_dp_add_event(dp, EV_HPD_PLUG_INT, 0, 3); + msm_dp_add_event(dp, EV_HPD_UNPLUG_INT, 0); + msm_dp_add_event(dp, EV_HPD_PLUG_INT, 3); } if (hpd_isr_status & DP_DP_HPD_UNPLUG_INT_MASK) - msm_dp_add_event(dp, EV_HPD_UNPLUG_INT, 0, 0); + msm_dp_add_event(dp, EV_HPD_UNPLUG_INT, 0); ret = IRQ_HANDLED; } @@ -1649,7 +1646,7 @@ void msm_dp_bridge_atomic_enable(struct drm_bridge *drm_bridge, } if (dp->is_edp) - msm_dp_hpd_plug_handle(msm_dp_display, 0); + msm_dp_hpd_plug_handle(msm_dp_display); mutex_lock(&msm_dp_display->event_mutex); if (pm_runtime_resume_and_get(&dp->pdev->dev)) { @@ -1721,7 +1718,7 @@ void msm_dp_bridge_atomic_post_disable(struct drm_bridge *drm_bridge, msm_dp_display = container_of(dp, struct msm_dp_display_private, msm_dp_display); if (dp->is_edp) - msm_dp_hpd_unplug_handle(msm_dp_display, 0); + msm_dp_hpd_unplug_handle(msm_dp_display); mutex_lock(&msm_dp_display->event_mutex); @@ -1843,7 +1840,7 @@ void msm_dp_bridge_hpd_notify(struct drm_bridge *bridge, return; if (!msm_dp_display->link_ready && status == connector_status_connected) - msm_dp_add_event(dp, EV_HPD_PLUG_INT, 0, 0); + msm_dp_add_event(dp, EV_HPD_PLUG_INT, 0); else if (msm_dp_display->link_ready && status == connector_status_disconnected) - msm_dp_add_event(dp, EV_HPD_UNPLUG_INT, 0, 0); + msm_dp_add_event(dp, EV_HPD_UNPLUG_INT, 0); } -- 2.47.3