From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DE4110706DB for ; Sat, 14 Mar 2026 13:31:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9FFA510E16F; Sat, 14 Mar 2026 13:31:46 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dv9u0Zpw"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id D564B10E16F for ; Sat, 14 Mar 2026 13:31:44 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id CFC7B60008; Sat, 14 Mar 2026 13:31:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3F5EC116C6; Sat, 14 Mar 2026 13:31:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1773495103; bh=33fhq7j5vg+tmMCu8Sapd06qjx9fDJbLUGUc3OjM+E4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dv9u0ZpwOCbxh1VMl/0LobIPwxuijRelA04TesVduk5vbbp+kGnqw9UNedhXkOOPt TgOyvngKw842sT462V0uXDzZPJyziLSVipaw4mLC3ezBVhYFy0S4I/UtVix2RzkKKh ROKzexdoLNYAubV50MkEEGhFHovLrU33mKuM81sc= Date: Sat, 14 Mar 2026 14:31:38 +0100 From: Greg Kroah-Hartman To: Markus Probst Cc: Rob Herring , Jiri Slaby , Miguel Ojeda , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Kari Argillander , "Rafael J. Wysocki" , Viresh Kumar , Boqun Feng , David Airlie , Simona Vetter , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-pm@vger.kernel.org, driver-core@lists.linux.dev, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v3 2/4] serdev: add rust private data to serdev_device Message-ID: <2026031447-margarita-untamed-e976@gregkh> References: <20260313-rust_serdev-v3-0-c9a3af214f7f@posteo.de> <20260313-rust_serdev-v3-2-c9a3af214f7f@posteo.de> <2026031402-absence-graph-af5d@gregkh> <2026031422-shaded-matchbook-5078@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, Mar 14, 2026 at 12:08:09PM +0000, Markus Probst wrote: > On Sat, 2026-03-14 at 12:52 +0100, Greg Kroah-Hartman wrote: > > On Sat, Mar 14, 2026 at 11:42:02AM +0000, Markus Probst wrote: > > > On Sat, 2026-03-14 at 09:07 +0100, Greg Kroah-Hartman wrote: > > > > On Fri, Mar 13, 2026 at 06:12:31PM +0000, Markus Probst wrote: > > > > > Add rust private data to `struct serdev_device`, as it is required by the > > > > > rust abstraction added in the following commit > > > > > (rust: add basic serial device bus abstractions). > > > > > > > > why is rust "special" here? What's wrong with the existing private > > > > pointer in this structure? Why must we add another one? > > > Because in rust, the device drvdata will be set after probe has run. In > > > serdev, once the device has been opened, it can receive data. It must > > > be opened either inside probe or before probe, because it can only be > > > configured (baudrate, flow control etc.) and data written to after it > > > has been opened. Because it can receive data before drvdata has been > > > set yet, we need to ensure it waits on data receival for the probe to > > > be finished. Otherwise this would be a null pointer dereference. To do > > > this, we need to store a `Completion` for it to wait and a `bool` in > > > case the probe exits with an error. We cannot store this data in the > > > device drvdata, because this is where the drivers drvdata goes. We also > > > cannot create a wrapper of the drivers drvdata, because > > > `Device::drvdata::()` would always fail in that case. That is why we > > > need a "rust_private_data" for this abstraction to store the > > > `Completion` and `bool`. > > > > So why is this any different from any other bus type? I don't see the > > "uniqueness" here that has not required this to happen for PCI or USB or > > anything else. > > > > What am I missing? > In Short: > In serdev, we have to handle incoming device data (serdev calls on a > function pointer we provide in advance), even in the case that the > driver hasn't completed probe yet. But how is that any different from a USB or PCI driver doing the same thing? Why is serdev so unique here? What specific serdev function causes this and why isn't it an issue with the C api? Can we change the C code to not require this? thanks, greg k-h