public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Damon Ding <damon.ding@rock-chips.com>
To: andrzej.hajda@intel.com, neil.armstrong@linaro.org,
	rfoss@kernel.org, maarten.lankhorst@linux.intel.com,
	mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
	simona@ffwll.ch, victor.liu@nxp.com, shawnguo@kernel.org,
	s.hauer@pengutronix.de, inki.dae@samsung.com,
	sw0312.kim@samsung.com, kyungmin.park@samsung.com,
	krzk@kernel.org, jingoohan1@gmail.com, p.zabel@pengutronix.de,
	hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com
Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
	jernej.skrabec@gmail.com, kernel@pengutronix.de,
	festevam@gmail.com, alim.akhtar@samsung.com,
	dmitry.baryshkov@oss.qualcomm.com, luca.ceresoli@bootlin.com,
	nicolas.frattaroli@collabora.com, dianders@chromium.org,
	m.szyprowski@samsung.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	Damon Ding <damon.ding@rock-chips.com>
Subject: [PATCH v11 10/17] drm/bridge: analogix_dp: Pass struct drm_atomic_state* for analogix_dp_bridge_mode_set()
Date: Thu, 19 Mar 2026 15:14:45 +0800	[thread overview]
Message-ID: <20260319071452.1961274-11-damon.ding@rock-chips.com> (raw)
In-Reply-To: <20260319071452.1961274-1-damon.ding@rock-chips.com>

To avoid using &analogix_dp_device.connector for compatibility
with the bridge connector framework, get &drm_connector from
&drm_atomic_state instead.

Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
---
 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index 3efd910ea463..7e42eb18313d 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -1095,14 +1095,21 @@ static int analogix_dp_set_bridge(struct analogix_dp_device *dp)
 }
 
 static void analogix_dp_bridge_mode_set(struct drm_bridge *bridge,
+					struct drm_atomic_state *state,
 					const struct drm_display_mode *mode)
 {
 	struct analogix_dp_device *dp = to_dp(bridge);
-	struct drm_display_info *display_info = &dp->connector.display_info;
 	struct video_info *video = &dp->video_info;
 	struct device_node *dp_node = dp->dev->of_node;
+	struct drm_connector *connector;
+	struct drm_display_info *display_info;
 	int vic;
 
+	connector = drm_atomic_get_new_connector_for_encoder(state, bridge->encoder);
+	if (!connector)
+		return;
+	display_info = &connector->display_info;
+
 	/* Input video interlaces & hsync pol & vsync pol */
 	video->interlaced = !!(mode->flags & DRM_MODE_FLAG_INTERLACE);
 	video->v_sync_polarity = !!(mode->flags & DRM_MODE_FLAG_NVSYNC);
@@ -1186,7 +1193,7 @@ static void analogix_dp_bridge_atomic_enable(struct drm_bridge *bridge,
 	new_crtc_state = drm_atomic_get_new_crtc_state(old_state, crtc);
 	if (!new_crtc_state)
 		return;
-	analogix_dp_bridge_mode_set(bridge, &new_crtc_state->adjusted_mode);
+	analogix_dp_bridge_mode_set(bridge, old_state, &new_crtc_state->adjusted_mode);
 
 	old_crtc_state = drm_atomic_get_old_crtc_state(old_state, crtc);
 	/* Not a full enable, just disable PSR and continue */
-- 
2.34.1


  parent reply	other threads:[~2026-03-19  7:15 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19  7:14 [PATCH v11 00/17] Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver Damon Ding
2026-03-19  7:14 ` [PATCH v11 01/17] drm/bridge: analogix_dp: Add &analogix_dp_plat_data.next_bridge Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:14 ` [PATCH v11 02/17] drm/bridge: Move legacy bridge driver out of imx directory for multi-platform use Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:14 ` [PATCH v11 03/17] drm/exynos: exynos_dp: Remove &exynos_dp_device.ptn_bridge Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:14 ` [PATCH v11 04/17] drm/exynos: exynos_dp: Remove unused &exynos_dp_device.connector Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:14 ` [PATCH v11 05/17] drm/exynos: exynos_dp: Apply of-display-mode-bridge to parse the display-timings node Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:14 ` [PATCH v11 06/17] drm/bridge: analogix_dp: Remove redundant &analogix_dp_plat_data.skip_connector Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:14 ` [PATCH v11 07/17] drm/bridge: analogix_dp: Move the color format check to .atomic_check() for Rockchip platforms Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:14 ` [PATCH v11 08/17] drm/bridge: analogix_dp: Remove unused &analogix_dp_plat_data.get_modes() Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:14 ` [PATCH v11 09/17] drm/bridge: analogix_dp: Remove unused struct drm_connector* for &analogix_dp_plat_data.attach() Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:14 ` Damon Ding [this message]
2026-03-21 18:35   ` Claude review: drm/bridge: analogix_dp: Pass struct drm_atomic_state* for analogix_dp_bridge_mode_set() Claude Code Review Bot
2026-03-19  7:14 ` [PATCH v11 11/17] drm/bridge: analogix_dp: Apply drm_bridge_connector helper Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:14 ` [PATCH v11 12/17] drm/bridge: analogix_dp: Add new API analogix_dp_finish_probe() Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:14 ` [PATCH v11 13/17] drm/rockchip: analogix_dp: Apply analogix_dp_finish_probe() Damon Ding
2026-03-21 18:35   ` Claude review: " Claude Code Review Bot
2026-03-19  7:47 ` [PATCH v11 14/17] drm/exynos: exynos_dp: " Damon Ding
2026-03-19  7:47   ` [PATCH v11 15/17] drm/bridge: analogix_dp: Attach the next bridge in analogix_dp_bridge_attach() Damon Ding
2026-03-21 18:35     ` Claude review: " Claude Code Review Bot
2026-03-19  7:47   ` [PATCH v11 16/17] drm/bridge: analogix_dp: Remove bridge disabing and panel unpreparing in analogix_dp_unbind() Damon Ding
2026-03-21 18:35     ` Claude review: " Claude Code Review Bot
2026-03-19  7:47   ` [PATCH v11 17/17] drm/bridge: analogix_dp: Apply panel_bridge helper Damon Ding
2026-03-21 18:35     ` Claude review: " Claude Code Review Bot
2026-03-21 18:35   ` Claude review: drm/exynos: exynos_dp: Apply analogix_dp_finish_probe() Claude Code Review Bot
2026-03-21 18:35 ` Claude review: Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260319071452.1961274-11-damon.ding@rock-chips.com \
    --to=damon.ding@rock-chips.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=alim.akhtar@samsung.com \
    --cc=andrzej.hajda@intel.com \
    --cc=andy.yan@rock-chips.com \
    --cc=dianders@chromium.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=festevam@gmail.com \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=imx@lists.linux.dev \
    --cc=inki.dae@samsung.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jingoohan1@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=kernel@pengutronix.de \
    --cc=krzk@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=m.szyprowski@samsung.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=nicolas.frattaroli@collabora.com \
    --cc=p.zabel@pengutronix.de \
    --cc=rfoss@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=sw0312.kim@samsung.com \
    --cc=tzimmermann@suse.de \
    --cc=victor.liu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox