From: Damon Ding <damon.ding@rock-chips.com>
To: hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
andrzej.hajda@intel.com, neil.armstrong@linaro.org,
rfoss@kernel.org
Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
jernej.skrabec@gmail.com, nicolas.frattaroli@collabora.com,
alchark@gmail.com, cristian.ciocaltea@collabora.com,
sebastian.reichel@collabora.com, kever.yang@rock-chips.com,
heiko.stuebner@cherry.de, tomeu@tomeuvizoso.net,
amadeus@jmu.edu.cn, michael.riesch@collabora.com,
didi.debian@cknow.org, dmitry.baryshkov@oss.qualcomm.com,
luca.ceresoli@bootlin.com, dianders@chromium.org,
m.szyprowski@samsung.com, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Damon Ding <damon.ding@rock-chips.com>
Subject: [PATCH v2 4/9] drm/rockchip: analogix_dp: Enable clock "hclk" for RK3588
Date: Thu, 19 Mar 2026 18:40:26 +0800 [thread overview]
Message-ID: <20260319104031.1986946-5-damon.ding@rock-chips.com> (raw)
In-Reply-To: <20260319104031.1986946-1-damon.ding@rock-chips.com>
The RK3588 eDP controller needs the video datapath clock "hclk" to work
well. Previously, it works without explicitly adding this clock because
the 'rockchip,vo-grf = <&vo1_grf>' property implicitly enables HCLK_VO1.
Fixes: 729f8eefdcad ("drm/rockchip: analogix_dp: Add support for RK3588")
Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
---
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
index 832e9766bef0..aa01ede4945e 100644
--- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
+++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
@@ -311,6 +311,7 @@ static int rockchip_dp_of_probe(struct rockchip_dp_device *dp)
{
struct device *dev = dp->dev;
struct device_node *np = dev->of_node;
+ struct clk *clk;
dp->grf = syscon_regmap_lookup_by_phandle(np, "rockchip,grf");
if (IS_ERR(dp->grf))
@@ -327,6 +328,11 @@ static int rockchip_dp_of_probe(struct rockchip_dp_device *dp)
return dev_err_probe(dev, PTR_ERR(dp->pclk),
"failed to get pclk property\n");
+ clk = devm_clk_get_optional_enabled(dev, "hclk");
+ if (IS_ERR(clk))
+ return dev_err_probe(dev, PTR_ERR(clk),
+ "failed to get hclk property\n");
+
dp->rst = devm_reset_control_get(dev, "dp");
if (IS_ERR(dp->rst))
return dev_err_probe(dev, PTR_ERR(dp->rst),
--
2.34.1
next prev parent reply other threads:[~2026-03-19 10:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 10:40 [PATCH v2 0/9] Add eDP support for RK3576 Damon Ding
2026-03-19 10:40 ` [PATCH v2 1/9] dt-bindings: display: rockchip: analogix-dp: Expand clock-names "hclk" for the third clock Damon Ding
2026-03-20 9:19 ` Krzysztof Kozlowski
2026-03-20 9:41 ` Krzysztof Kozlowski
2026-03-21 18:26 ` Claude review: " Claude Code Review Bot
2026-03-19 10:40 ` [PATCH v2 2/9] arm64: dts: rockchip: Add missing clock "hclk" for RK3588 eDP0 nodes Damon Ding
2026-03-21 18:26 ` Claude review: " Claude Code Review Bot
2026-03-19 10:40 ` [PATCH v2 3/9] arm64: dts: rockchip: Add missing clock "hclk" for RK3588 eDP1 nodes Damon Ding
2026-03-21 18:26 ` Claude review: " Claude Code Review Bot
2026-03-19 10:40 ` Damon Ding [this message]
2026-03-21 18:26 ` Claude review: drm/rockchip: analogix_dp: Enable clock "hclk" for RK3588 Claude Code Review Bot
2026-03-19 10:40 ` [PATCH v2 5/9] dt-bindings: display: rockchip: analogix-dp: Add support for RK3576 Damon Ding
2026-03-21 18:26 ` Claude review: " Claude Code Review Bot
2026-03-19 10:40 ` [PATCH v2 6/9] arm64: dts: rockchip: Add eDP node " Damon Ding
2026-03-21 18:26 ` Claude review: " Claude Code Review Bot
2026-03-19 10:40 ` [PATCH v2 7/9] drm/bridge: analogix_dp: Rename and simplify is_rockchip() Damon Ding
2026-03-21 18:26 ` Claude review: " Claude Code Review Bot
2026-03-19 10:40 ` [PATCH v2 8/9] drm/bridge: analogix_dp: Add support for RK3576 Damon Ding
2026-03-21 18:26 ` Claude review: " Claude Code Review Bot
2026-03-20 0:45 ` [PATCH v2 9/9] drm/rockchip: " Damon Ding
2026-03-21 18:26 ` Claude review: " Claude Code Review Bot
2026-03-21 18:26 ` Claude review: Add eDP " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260319104031.1986946-5-damon.ding@rock-chips.com \
--to=damon.ding@rock-chips.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=alchark@gmail.com \
--cc=amadeus@jmu.edu.cn \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=didi.debian@cknow.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko.stuebner@cherry.de \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kever.yang@rock-chips.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=luca.ceresoli@bootlin.com \
--cc=m.szyprowski@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=michael.riesch@collabora.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nicolas.frattaroli@collabora.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=simona@ffwll.ch \
--cc=tomeu@tomeuvizoso.net \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox