From: Chen Ni <nichen@iscas.ac.cn>
To: amd-gfx@lists.freedesktop.org
Cc: christian.koenig@amd.com, alexander.deucher@amd.com,
sunil.khatri@amd.com, dri-devel@lists.freedesktop.org,
Chen Ni <nichen@iscas.ac.cn>
Subject: [PATCH] drm/amdgpu/userq: convert comma to semicolon
Date: Fri, 20 Mar 2026 16:32:47 +0800 [thread overview]
Message-ID: <20260320083247.428482-1-nichen@iscas.ac.cn> (raw)
Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it seems best to use ';'
unless ',' is intended.
Found by inspection.
No functional change intended.
Compile tested only.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
index 781896c9fd26..6daec964ca5e 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
@@ -961,13 +961,13 @@ int amdgpu_userq_wait_ioctl(struct drm_device *dev, void *data,
}
num_read_bo_handles = wait_info->num_bo_read_handles;
- ptr = u64_to_user_ptr(wait_info->bo_read_handles),
+ ptr = u64_to_user_ptr(wait_info->bo_read_handles);
r = drm_gem_objects_lookup(filp, ptr, num_read_bo_handles, &gobj_read);
if (r)
goto free_timeline_points;
num_write_bo_handles = wait_info->num_bo_write_handles;
- ptr = u64_to_user_ptr(wait_info->bo_write_handles),
+ ptr = u64_to_user_ptr(wait_info->bo_write_handles);
r = drm_gem_objects_lookup(filp, ptr, num_write_bo_handles,
&gobj_write);
if (r)
--
2.25.1
next reply other threads:[~2026-03-20 8:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 8:32 Chen Ni [this message]
2026-03-21 17:50 ` Claude review: drm/amdgpu/userq: convert comma to semicolon Claude Code Review Bot
2026-03-21 17:50 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260320083247.428482-1-nichen@iscas.ac.cn \
--to=nichen@iscas.ac.cn \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=sunil.khatri@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox