From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B1891099B36 for ; Fri, 20 Mar 2026 18:35:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 34DFE10EBBE; Fri, 20 Mar 2026 18:35:55 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="O5ZY0Rqc"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6703810EB2A; Fri, 20 Mar 2026 18:35:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774031749; x=1805567749; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=nn0e66Cjyw8HVNHpO2h8i/I63DmYi7XOFXxs8CiLe8k=; b=O5ZY0Rqc4CpSM5/LFTe6Z4COG5Vkdi6+s8AaXtrIcl+nP1EK+8TUVlYh tVITP0hgBU3j8whKWgEC5SSdW4MW4P6rLqjzU7mYiElKWqGeRmlh30scr sCncoUmePniuwntPa4uRoyh3M3soFQqXQIick9PxMK/syIovJy5Kah85L XwETZt1xiCJKh1nkFgPCEOrCsfq44VarVZ2wBsXJn2KEQHnDyAuwzBghI 1ODL/cOdndtLuvh2MT23Zgxg/2O9ipbBseQuokDsrBl0nGOMQR11WbXyg U5rwFCaWdUCgOsQDHsXnM+EhEMfWIliGxCpHB4PIn0NVNStRMfQ9aj6mr g==; X-CSE-ConnectionGUID: YvAl3QHHSHuzh07DvBFm8Q== X-CSE-MsgGUID: 014I0guFSUCLIElSewNqQw== X-IronPort-AV: E=McAfee;i="6800,10657,11735"; a="75092815" X-IronPort-AV: E=Sophos;i="6.23,130,1770624000"; d="scan'208";a="75092815" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2026 11:35:49 -0700 X-CSE-ConnectionGUID: NsiHlvChQZuWXcM+uLaE6w== X-CSE-MsgGUID: 3Wd8EfQqTVOA4lzLwUMKCw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,130,1770624000"; d="scan'208";a="223399392" Received: from dut4086lnl.fm.intel.com ([10.105.10.101]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2026 11:35:48 -0700 From: Jonathan Cavitt To: intel-xe@lists.freedesktop.org Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com, jonathan.cavitt@intel.com, joonas.lahtinen@linux.intel.com, matthew.brost@intel.com, jianxun.zhang@intel.com, shuicheng.lin@intel.com, dri-devel@lists.freedesktop.org, Michal.Wajdeczko@intel.com, michal.mrozek@intel.com, raag.jadav@intel.com, ivan.briano@intel.com, matthew.auld@intel.com, dafna.hirschfeld@intel.com, jose.souza@intel.com, thomas.hellstrom@linux.intel.com Subject: [PATCH v38 1/4] drm/xe/xe_pagefault: Disallow writes to read-only VMAs Date: Fri, 20 Mar 2026 18:35:48 +0000 Message-ID: <20260320183547.61017-7-jonathan.cavitt@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260320183547.61017-6-jonathan.cavitt@intel.com> References: <20260320183547.61017-6-jonathan.cavitt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The page fault handler should reject write/atomic access to read only VMAs. Add code to handle this in xe_pagefault_service after the VMA lookup. v2: - Apply max line length (Matthew) Fixes: fb544b844508 ("drm/xe: Implement xe_pagefault_queue_work") Signed-off-by: Jonathan Cavitt Suggested-by: Matthew Brost Cc: Shuicheng Lin Reviewed-by: Matthew Brost --- drivers/gpu/drm/xe/xe_pagefault.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_pagefault.c b/drivers/gpu/drm/xe/xe_pagefault.c index ea4857acf28d..918d595d1c1b 100644 --- a/drivers/gpu/drm/xe/xe_pagefault.c +++ b/drivers/gpu/drm/xe/xe_pagefault.c @@ -187,6 +187,12 @@ static int xe_pagefault_service(struct xe_pagefault *pf) goto unlock_vm; } + if (xe_vma_read_only(vma) && + pf->consumer.access_type != XE_PAGEFAULT_ACCESS_TYPE_READ) { + err = -EPERM; + goto unlock_vm; + } + atomic = xe_pagefault_access_is_atomic(pf->consumer.access_type); if (xe_vma_is_cpu_addr_mirror(vma)) -- 2.43.0