From: Kexin Sun <kexinsun@smail.nju.edu.cn>
To: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
rodrigo.vivi@intel.com, tursulin@ursulin.net, airlied@gmail.com,
simona@ffwll.ch, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: julia.lawall@inria.fr, xutong.ma@inria.fr,
kexinsun@smail.nju.edu.cn, yunbolyu@smu.edu.sg,
ratnadiraw@smu.edu.sg
Subject: [PATCH] drm/i915: fix outdated i915_vma_get_fence() references in kdoc
Date: Sat, 21 Mar 2026 18:57:33 +0800 [thread overview]
Message-ID: <20260321105733.6391-1-kexinsun@smail.nju.edu.cn> (raw)
The function i915_vma_get_fence() was merged into
i915_vma_pin_fence() by commit 3bd4073524fa ("drm/i915:
Consolidate get_fence with pin_fence").
Remove the stale sentence that tells callers to synchronize
fencing state by calling i915_vma_get_fence() first, and fix
the Returns description: i915_vma_pin_fence() returns int
(0 on success, negative error code on failure), not bool as
the old i915_vma_get_fence() did.
Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
---
drivers/gpu/drm/i915/i915_vma.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_vma.h b/drivers/gpu/drm/i915/i915_vma.h
index 8054047840aa..14ad66f8b398 100644
--- a/drivers/gpu/drm/i915/i915_vma.h
+++ b/drivers/gpu/drm/i915/i915_vma.h
@@ -369,14 +369,13 @@ void i915_vma_unpin_iomap(struct i915_vma *vma);
* @vma: vma to pin fencing for
*
* This pins the fencing state (whether tiled or untiled) to make sure the
- * vma (and its object) is ready to be used as a scanout target. Fencing
- * status must be synchronize first by calling i915_vma_get_fence():
+ * vma (and its object) is ready to be used as a scanout target.
*
* The resulting fence pin reference must be released again with
* i915_vma_unpin_fence().
*
* Returns:
- * True if the vma has a fence, false otherwise.
+ * 0 on success, negative error code on failure.
*/
int __must_check i915_vma_pin_fence(struct i915_vma *vma);
void i915_vma_revoke_fence(struct i915_vma *vma);
--
2.25.1
next reply other threads:[~2026-03-21 11:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 10:57 Kexin Sun [this message]
2026-03-21 17:01 ` Claude review: drm/i915: fix outdated i915_vma_get_fence() references in kdoc Claude Code Review Bot
2026-03-21 17:01 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260321105733.6391-1-kexinsun@smail.nju.edu.cn \
--to=kexinsun@smail.nju.edu.cn \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=ratnadiraw@smu.edu.sg \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=tursulin@ursulin.net \
--cc=xutong.ma@inria.fr \
--cc=yunbolyu@smu.edu.sg \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox