* [PATCH] drm/vc4: update outdated comment for renamed vc4_crtc_atomic_flush()
@ 2026-03-21 10:57 Kexin Sun
2026-03-21 17:04 ` Claude review: " Claude Code Review Bot
2026-03-21 17:04 ` Claude Code Review Bot
0 siblings, 2 replies; 3+ messages in thread
From: Kexin Sun @ 2026-03-21 10:57 UTC (permalink / raw)
To: mripard, dave.stevenson, mcanal, kernel-list, maarten.lankhorst,
tzimmermann, airlied, simona, dri-devel, linux-kernel
Cc: julia.lawall, xutong.ma, kexinsun, yunbolyu, ratnadiraw
The function vc4_crtc_atomic_flush() was moved and renamed
to vc4_hvs_atomic_flush() by commit 8175287bdd06
("drm/vc4: crtc: Move HVS setup code to the HVS driver").
Update the stale reference in struct vc4_plane_state.
Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
---
drivers/gpu/drm/vc4/vc4_drv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h
index 221d8e01d539..9d4bb6144a42 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.h
+++ b/drivers/gpu/drm/vc4/vc4_drv.h
@@ -410,7 +410,7 @@ struct vc4_plane_state {
u32 lbm_offset;
/* Offset where the plane's dlist was last stored in the
- * hardware at vc4_crtc_atomic_flush() time.
+ * hardware at vc4_hvs_atomic_flush() time.
*/
u32 __iomem *hw_dlist;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Claude review: drm/vc4: update outdated comment for renamed vc4_crtc_atomic_flush()
2026-03-21 10:57 [PATCH] drm/vc4: update outdated comment for renamed vc4_crtc_atomic_flush() Kexin Sun
@ 2026-03-21 17:04 ` Claude Code Review Bot
2026-03-21 17:04 ` Claude Code Review Bot
1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-03-21 17:04 UTC (permalink / raw)
To: dri-devel-reviews
Overall Series Review
Subject: drm/vc4: update outdated comment for renamed vc4_crtc_atomic_flush()
Author: Kexin Sun <kexinsun@smail.nju.edu.cn>
Patches: 1
Reviewed: 2026-03-22T03:04:07.574647
---
This is a single-patch series making a trivial but correct comment fix in the VC4 DRM driver. The function `vc4_crtc_atomic_flush()` was renamed to `vc4_hvs_atomic_flush()` in a prior commit, but a comment in `vc4_drv.h` still referenced the old name. The fix is straightforward and verified correct.
**Verdict: Looks good.** No functional concerns.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 3+ messages in thread
* Claude review: drm/vc4: update outdated comment for renamed vc4_crtc_atomic_flush()
2026-03-21 10:57 [PATCH] drm/vc4: update outdated comment for renamed vc4_crtc_atomic_flush() Kexin Sun
2026-03-21 17:04 ` Claude review: " Claude Code Review Bot
@ 2026-03-21 17:04 ` Claude Code Review Bot
1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-03-21 17:04 UTC (permalink / raw)
To: dri-devel-reviews
Patch Review
**Code change:**
```c
- * hardware at vc4_crtc_atomic_flush() time.
+ * hardware at vc4_hvs_atomic_flush() time.
```
The change is correct. `vc4_crtc_atomic_flush()` no longer exists in the tree, and `vc4_hvs_atomic_flush()` is the current function name (defined in `vc4_hvs.c` and declared in `vc4_drv.h`).
**Minor nits on the commit message:**
1. The `Assisted-by: unnamed:deepseek-v3.2 coccinelle` tag is non-standard. The kernel community hasn't settled on a formal tag for AI-assisted patches, but this format mixing an AI model name with "coccinelle" (a separate semantic patching tool) is confusing. It's unclear whether Coccinelle was used to find the stale reference and DeepSeek was used for something else, or if this is meant as a single attribution. These should probably be separated or clarified.
2. Otherwise the commit message is clear and properly references the commit (`8175287bdd06`) that performed the original rename.
**No functional issues.**
Reviewed-by assessment: **Acceptable to merge as-is**, though the maintainer may want clarification on the `Assisted-by` tag.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-21 17:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-21 10:57 [PATCH] drm/vc4: update outdated comment for renamed vc4_crtc_atomic_flush() Kexin Sun
2026-03-21 17:04 ` Claude review: " Claude Code Review Bot
2026-03-21 17:04 ` Claude Code Review Bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox