public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Kexin Sun <kexinsun@smail.nju.edu.cn>
To: matthew.brost@intel.com, thomas.hellstrom@linux.intel.com,
	rodrigo.vivi@intel.com, airlied@gmail.com, simona@ffwll.ch,
	intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Cc: julia.lawall@inria.fr, xutong.ma@inria.fr,
	kexinsun@smail.nju.edu.cn, yunbolyu@smu.edu.sg,
	ratnadiraw@smu.edu.sg
Subject: [PATCH] drm/xe: update outdated reference to xe_pt_commit_bind()
Date: Sat, 21 Mar 2026 18:57:48 +0800	[thread overview]
Message-ID: <20260321105748.6646-1-kexinsun@smail.nju.edu.cn> (raw)

The function xe_pt_commit_bind() was split into
xe_pt_commit_prepare_bind(), xe_pt_commit(), and
xe_pt_abort_bind() by commit a708f6501c69 ("drm/xe: Update
PT layer with better error handling").  Update the stale
reference in xe_pt_stage_bind() to list the two functions
that now perform the cpu-side page-table connection.

Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
---
 drivers/gpu/drm/xe/xe_pt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_pt.c b/drivers/gpu/drm/xe/xe_pt.c
index 13b355fadd58..8f00e6454721 100644
--- a/drivers/gpu/drm/xe/xe_pt.c
+++ b/drivers/gpu/drm/xe/xe_pt.c
@@ -686,7 +686,8 @@ static bool xe_atomic_for_system(struct xe_vm *vm, struct xe_vma *vma)
  *
  * This function builds a disconnected page-table tree for a given address
  * range. The tree is connected to the main vm tree for the gpu using
- * xe_migrate_update_pgtables() and for the cpu using xe_pt_commit_bind().
+ * xe_migrate_update_pgtables() and for the cpu using
+ * xe_pt_commit_prepare_bind() and xe_pt_commit().
  * The function builds xe_vm_pgtable_update structures for already existing
  * shared page-tables, and non-existing shared and non-shared page-tables
  * are built and populated directly.
-- 
2.25.1


             reply	other threads:[~2026-03-21 11:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-21 10:57 Kexin Sun [this message]
2026-03-21 17:03 ` Claude review: drm/xe: update outdated reference to xe_pt_commit_bind() Claude Code Review Bot
2026-03-21 17:03 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260321105748.6646-1-kexinsun@smail.nju.edu.cn \
    --to=kexinsun@smail.nju.edu.cn \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=julia.lawall@inria.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.brost@intel.com \
    --cc=ratnadiraw@smu.edu.sg \
    --cc=rodrigo.vivi@intel.com \
    --cc=simona@ffwll.ch \
    --cc=thomas.hellstrom@linux.intel.com \
    --cc=xutong.ma@inria.fr \
    --cc=yunbolyu@smu.edu.sg \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox