public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Haoyu Lu <hechushiguitu666@gmail.com>
To: lizhi.hou@amd.com
Cc: mamin506@gmail.com, ogabbay@kernel.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	"haoyu.lu" <hechushiguitu666@gmail.com>
Subject: [PATCH v2] accel/amdxdna: fix missing newline in pr_err message
Date: Mon, 23 Mar 2026 11:49:32 +0800	[thread overview]
Message-ID: <20260323034933.216-1-hechushiguitu666@gmail.com> (raw)
In-Reply-To: <1af543d3-46ff-7a9c-6432-fe3c9050e23d@amd.com>

From: "haoyu.lu" <hechushiguitu666@gmail.com>

Add missing newline to pr_err message in amdxdna_mailbox.c.

Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox")
Signed-off-by: haoyu.lu <hechushiguitu666@gmail.com>
---
Changes in v2:
- Added Fixes tag as requested

 drivers/accel/amdxdna/amdxdna_mailbox.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c b/drivers/accel/amdxdna/amdxdna_mailbox.c
index 46d844a73a94..e681a090752d 100644
--- a/drivers/accel/amdxdna/amdxdna_mailbox.c
+++ b/drivers/accel/amdxdna/amdxdna_mailbox.c
@@ -499,7 +499,7 @@ xdna_mailbox_start_channel(struct mailbox_channel *mb_chann,
 	int ret;
 
 	if (!is_power_of_2(x2i->rb_size) || !is_power_of_2(i2x->rb_size)) {
-		pr_err("Ring buf size must be power of 2");
+		pr_err("Ring buf size must be power of 2\n");
 		return -EINVAL;
 	}
 
-- 
2.53.0.windows.1


  parent reply	other threads:[~2026-03-23  8:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-20 11:29 [PATCH] accel/amdxdna: fix missing newline in pr_err message Haoyu Lu
2026-03-20 15:54 ` Lizhi Hou
2026-03-21 17:46   ` Claude review: " Claude Code Review Bot
2026-03-21 17:46   ` Claude Code Review Bot
2026-03-23  3:49   ` Haoyu Lu [this message]
2026-03-23 16:40     ` [PATCH v2] " Lizhi Hou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260323034933.216-1-hechushiguitu666@gmail.com \
    --to=hechushiguitu666@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizhi.hou@amd.com \
    --cc=mamin506@gmail.com \
    --cc=ogabbay@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox