From: "Baoli.Zhang" <baoli.zhang@linux.intel.com>
To: Matthew Brost <matthew.brost@intel.com>,
Thomas Hellström <thomas.hellstrom@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Cc: "Baoli.Zhang" <baoli.zhang@linux.intel.com>,
"Junxiao . Chang" <junxiao.chang@intel.com>
Subject: [PATCH v1] drm/xe: use krealloc_array to prevent integer overflow
Date: Mon, 23 Mar 2026 20:00:49 +0800 [thread overview]
Message-ID: <20260323120051.983301-1-baoli.zhang@linux.intel.com> (raw)
Replace the use of krealloc() with krealloc_array() in xe driver to
mitigate the risk of integer overflow during memory allocation size
calculation.
Signed-off-by: Baoli.Zhang <baoli.zhang@linux.intel.com>
Signed-off-by: Junxiao.Chang <junxiao.chang@intel.com>
---
drivers/gpu/drm/xe/xe_configfs.c | 2 +-
drivers/gpu/drm/xe/xe_vm_madvise.c | 5 +++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_configfs.c b/drivers/gpu/drm/xe/xe_configfs.c
index 7fd07d1280bb1..4cf903c904ba0 100644
--- a/drivers/gpu/drm/xe/xe_configfs.c
+++ b/drivers/gpu/drm/xe/xe_configfs.c
@@ -766,7 +766,7 @@ static ssize_t wa_bb_store(struct wa_bb wa_bb[static XE_ENGINE_CLASS_MAX],
* 2. Allocate a u32 array and set the pointers to the right positions
* according to the length of each class' wa_bb
*/
- tmp = krealloc(wa_bb[0].cs, count * sizeof(u32), GFP_KERNEL);
+ tmp = krealloc_array(wa_bb[0].cs, count, sizeof(u32), GFP_KERNEL);
if (!tmp)
return -ENOMEM;
diff --git a/drivers/gpu/drm/xe/xe_vm_madvise.c b/drivers/gpu/drm/xe/xe_vm_madvise.c
index bc39a9a9790c3..82afe4bef0725 100644
--- a/drivers/gpu/drm/xe/xe_vm_madvise.c
+++ b/drivers/gpu/drm/xe/xe_vm_madvise.c
@@ -63,8 +63,9 @@ static int get_vmas(struct xe_vm *vm, struct xe_vmas_in_madvise_range *madvise_r
if (madvise_range->num_vmas == max_vmas) {
max_vmas <<= 1;
- __vmas = krealloc(madvise_range->vmas,
- max_vmas * sizeof(*madvise_range->vmas),
+ __vmas = krealloc_array(madvise_range->vmas,
+ max_vmas,
+ sizeof(*madvise_range->vmas),
GFP_KERNEL);
if (!__vmas) {
kfree(madvise_range->vmas);
--
2.43.0
next reply other threads:[~2026-03-23 12:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 12:00 Baoli.Zhang [this message]
2026-03-24 21:53 ` Claude review: drm/xe: use krealloc_array to prevent integer overflow Claude Code Review Bot
2026-03-24 21:53 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323120051.983301-1-baoli.zhang@linux.intel.com \
--to=baoli.zhang@linux.intel.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=junxiao.chang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.brost@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox