From: Thomas Zimmermann <tzimmermann@suse.de>
To: jfalempe@redhat.com, airlied@redhat.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
airlied@gmail.com, simona@ffwll.ch
Cc: dri-devel@lists.freedesktop.org, Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 00/15] drm/ast: Clean up access to MMIO registers
Date: Mon, 23 Mar 2026 16:56:13 +0100 [thread overview]
Message-ID: <20260323160407.245773-1-tzimmermann@suse.de> (raw)
Aspeed devices up to Gen6 contain internal memory that is accessible
from the host via the P2A bridge. The helpers ast_moutdwm() and
ast_mindwm() pick a 64-KiB segment of the memory to expose to the
host, which then has the content available. Content is either registers
of the various IP blocks or on-board system memory.
Clean up the driver code involved and provide macro constants for the
registers used by the ast driver. Go through the driver and replace
the magic values with the constants.
The first patch of the series fixes a bug that has been found while
working on these changes. The DP501 writes the content of register
SCU2C to the wrong address. The fix is a separate patch to ease
backporting.
Smoke-tested on AST2100, AST2300, AST2500 and AST2600.
Thomas Zimmermann (15):
drm/ast: dp501: Fix initialization of SCU2C
drm/ast: Move 32-bit register-access helpers to ast_drv.{c,h}
drm/ast: Use constants for AHBC registers
drm/ast: Use constants for MCR registers
drm/ast: Use constants for SCU registers
drm/ast: Use constants for A2P registers
drm/ast: Use constants for WDT registers
drm/ast: Use constants for SDRAM registers
drm/ast: Store register addresses in struct ast_dramstruct
drm/ast: Gen1: Fix open-coded register access
drm/ast: Gen2: Fix open-coded register access
drm/ast: Gen4: Fix open-coded register access
drm/ast: Gen6: Fix open-coded register access
drm/ast: dp501: Fix open-coded register access
drm/ast: Fix open-coded scu_rev access
drivers/gpu/drm/ast/ast_2000.c | 61 +++--
drivers/gpu/drm/ast/ast_2100.c | 292 +++++++++++------------
drivers/gpu/drm/ast/ast_2300.c | 398 ++++++++++++++++----------------
drivers/gpu/drm/ast/ast_2500.c | 319 ++++++++++++-------------
drivers/gpu/drm/ast/ast_dp501.c | 146 ++++++------
drivers/gpu/drm/ast/ast_drv.c | 84 ++++++-
drivers/gpu/drm/ast/ast_drv.h | 60 +++--
drivers/gpu/drm/ast/ast_post.c | 48 +---
drivers/gpu/drm/ast/ast_post.h | 20 +-
drivers/gpu/drm/ast/ast_reg.h | 155 +++++++++++++
10 files changed, 886 insertions(+), 697 deletions(-)
base-commit: 5cb7d14d9bd2061386a0192a4649626a3e3a5ec3
--
2.53.0
next reply other threads:[~2026-03-23 16:04 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 15:56 Thomas Zimmermann [this message]
2026-03-23 15:56 ` [PATCH 01/15] drm/ast: dp501: Fix initialization of SCU2C Thomas Zimmermann
2026-03-24 21:46 ` Claude review: " Claude Code Review Bot
2026-03-23 15:56 ` [PATCH 02/15] drm/ast: Move 32-bit register-access helpers to ast_drv.{c, h} Thomas Zimmermann
2026-03-24 21:46 ` Claude review: " Claude Code Review Bot
2026-03-23 15:56 ` [PATCH 03/15] drm/ast: Use constants for AHBC registers Thomas Zimmermann
2026-03-24 21:46 ` Claude review: " Claude Code Review Bot
2026-03-23 15:56 ` [PATCH 04/15] drm/ast: Use constants for MCR registers Thomas Zimmermann
2026-03-24 21:46 ` Claude review: " Claude Code Review Bot
2026-03-23 15:56 ` [PATCH 05/15] drm/ast: Use constants for SCU registers Thomas Zimmermann
2026-03-24 21:46 ` Claude review: " Claude Code Review Bot
2026-03-23 15:56 ` [PATCH 06/15] drm/ast: Use constants for A2P registers Thomas Zimmermann
2026-03-24 21:46 ` Claude review: " Claude Code Review Bot
2026-03-23 15:56 ` [PATCH 07/15] drm/ast: Use constants for WDT registers Thomas Zimmermann
2026-03-24 21:46 ` Claude review: " Claude Code Review Bot
2026-03-23 15:56 ` [PATCH 08/15] drm/ast: Use constants for SDRAM registers Thomas Zimmermann
2026-03-24 21:46 ` Claude review: " Claude Code Review Bot
2026-03-23 15:56 ` [PATCH 09/15] drm/ast: Store register addresses in struct ast_dramstruct Thomas Zimmermann
2026-03-24 21:46 ` Claude review: " Claude Code Review Bot
2026-03-23 15:56 ` [PATCH 10/15] drm/ast: Gen1: Fix open-coded register access Thomas Zimmermann
2026-03-24 21:46 ` Claude review: " Claude Code Review Bot
2026-03-23 15:56 ` [PATCH 11/15] drm/ast: Gen2: " Thomas Zimmermann
2026-03-24 21:46 ` Claude review: " Claude Code Review Bot
2026-03-23 15:56 ` [PATCH 12/15] drm/ast: Gen4: " Thomas Zimmermann
2026-03-24 21:46 ` Claude review: " Claude Code Review Bot
2026-03-23 15:56 ` [PATCH 13/15] drm/ast: Gen6: " Thomas Zimmermann
2026-03-24 21:46 ` Claude review: " Claude Code Review Bot
2026-03-23 15:56 ` [PATCH 14/15] drm/ast: dp501: " Thomas Zimmermann
2026-03-24 21:46 ` Claude review: " Claude Code Review Bot
2026-03-23 15:56 ` [PATCH 15/15] drm/ast: Fix open-coded scu_rev access Thomas Zimmermann
2026-03-24 21:46 ` Claude review: " Claude Code Review Bot
2026-03-23 16:08 ` [PATCH 00/15] drm/ast: Clean up access to MMIO registers Thomas Zimmermann
2026-03-24 21:46 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323160407.245773-1-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jfalempe@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox