From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85E63E9A75C for ; Tue, 24 Mar 2026 10:02:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EE8D710E5C5; Tue, 24 Mar 2026 10:02:38 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="Wa4WwthL"; dkim-atps=neutral Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id AFE4A10E5C5 for ; Tue, 24 Mar 2026 10:02:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1774346556; bh=NsIVwTttN5mLTvYAaW7hDJrj3FCgMBu36e1Fhhf8Eck=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Wa4WwthLHMlLRf/BlizcxrTsR9rWSxk2tU62xH+RJKZGOx0wJCkAfL+TAiEA0CBC2 YlRVwcUCon99miPluMZet8cICqRXpU1Q1wGJxe2R4GuVFR5tWKn4Q2osglh+8B5C6x UTk4NpG0deTS75K698XrQ9YB4TabaFhdngddJXx7W9jNbQwztvgvMMGrUy7DYJoEc/ 7oaqlrYbVOVx4iNHlrixQLzMf3BUdDLbaboQgDFDaLVxjh3aYU9iJzxvncPIYLW5WH p1On0PP1NIB654pgvI7Lciy8q00hPkPiUZ4XYDD6WPnQmjr5X0BYAls4u4YF/j1XZg 5zoiYj7kj8xlQ== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:d919:a6e:5ea1:8a9f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 7938F17E4B9C; Tue, 24 Mar 2026 11:02:35 +0100 (CET) Date: Tue, 24 Mar 2026 11:02:31 +0100 From: Boris Brezillon To: Deborah Brouwer Cc: dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Boqun Feng , Danilo Krummrich , Alice Ryhl , Daniel Almeida , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Miguel Ojeda , Gary Guo , =?UTF-8?B?QmrDtnJu?= Roy Baron , Benno Lossin , Andreas Hindborg , Trevor Gross , Steven Price , Dirk Behme , Alexandre Courbot Subject: Re: [PATCH v3 06/12] drm/tyr: Remove custom register struct Message-ID: <20260324110231.2bc0f75a@fedora> In-Reply-To: <20260323-b4-tyr-use-register-macro-v3-v3-6-a87daf9e4701@collabora.com> References: <20260323-b4-tyr-use-register-macro-v3-v3-0-a87daf9e4701@collabora.com> <20260323-b4-tyr-use-register-macro-v3-v3-6-a87daf9e4701@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 23 Mar 2026 17:18:08 -0700 Deborah Brouwer wrote: > Now that Tyr uses the register! macro, it no longer needs to define a > custom register struct or read/write functions, so delete them. > > Co-developed-by: Daniel Almeida > Signed-off-by: Daniel Almeida > Reviewed-by: Daniel Almeida > Signed-off-by: Deborah Brouwer Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/tyr/regs.rs | 33 --------------------------------- > 1 file changed, 33 deletions(-) > > diff --git a/drivers/gpu/drm/tyr/regs.rs b/drivers/gpu/drm/tyr/regs.rs > index 869bad81d988b4c3d4d65e014d646b6db568e919..f337d99387417a2eca94cd2d7ce8c8fa38bb1cee 100644 > --- a/drivers/gpu/drm/tyr/regs.rs > +++ b/drivers/gpu/drm/tyr/regs.rs > @@ -27,39 +27,6 @@ > // does. > #![allow(dead_code)] > > -use kernel::{ > - device::{ > - Bound, > - Device, // > - }, > - devres::Devres, > - io::Io, > - prelude::*, // > -}; > - > -use crate::driver::IoMem; > - > -/// Represents a register in the Register Set > -/// > -/// TODO: Replace this with the Nova `register!()` macro when it is available. > -/// In particular, this will automatically give us 64bit register reads and > -/// writes. > -pub(crate) struct Register; > - > -impl Register { > - #[inline] > - pub(crate) fn read(&self, dev: &Device, iomem: &Devres) -> Result { > - let value = (*iomem).access(dev)?.read32(OFFSET); > - Ok(value) > - } > - > - #[inline] > - pub(crate) fn write(&self, dev: &Device, iomem: &Devres, value: u32) -> Result { > - (*iomem).access(dev)?.write32(value, OFFSET); > - Ok(()) > - } > -} > - > /// These registers correspond to the GPU_CONTROL register page. > /// They are involved in GPU configuration and control. > pub(crate) mod gpu_control { >