From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A11D6F54ACE for ; Tue, 24 Mar 2026 15:29:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 857EB10E71D; Tue, 24 Mar 2026 15:29:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="RtJ7+uLj"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id F1F4910E0DB; Tue, 24 Mar 2026 15:29:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774366179; x=1805902179; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=nn0e66Cjyw8HVNHpO2h8i/I63DmYi7XOFXxs8CiLe8k=; b=RtJ7+uLjy91hnecISD8kctA1oYSfgy5+5sbm9iFSmKUv5qCOahC076Tm 6Wqy4q5Wc9GcvsIuLqywUK3OGhDSEgOOCosFbzfqZqysnzPgy6m6E+sE5 AN/sMcpiT7x22stMnvwu+Yk/Lla4p4GxR/if50nksUdMLcO452ChQ2i1u pMUpIi9Gg9/kGOa6gYnrFZK2jVtROM6UZdiEY0sjdTkbXj+rRubIlJ5Qu lvH0fUYe6Kk6YKtfUgza4gO37RrmZfoBCabT1D8Ol03S8AF1BGhqvTeMd h0VuxRKnyX0VQ4aUA2rMtZtOZotA8SijxUsI2RmcKUAF88xogZMf2xXlb g==; X-CSE-ConnectionGUID: CE+3ZEnhQrOCjUslD3vX1A== X-CSE-MsgGUID: LM0RS6IPSnO5TJrxKTMjnw== X-IronPort-AV: E=McAfee;i="6800,10657,11739"; a="75101397" X-IronPort-AV: E=Sophos;i="6.23,138,1770624000"; d="scan'208";a="75101397" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2026 08:29:39 -0700 X-CSE-ConnectionGUID: 8Ep0OvBsS1afqjdJ+Jm5QA== X-CSE-MsgGUID: vy5TkLDFRPG//tSzTVbxCA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,138,1770624000"; d="scan'208";a="223597331" Received: from dut4086lnl.fm.intel.com ([10.105.10.101]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2026 08:29:38 -0700 From: Jonathan Cavitt To: intel-xe@lists.freedesktop.org Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com, jonathan.cavitt@intel.com, joonas.lahtinen@linux.intel.com, matthew.brost@intel.com, jianxun.zhang@intel.com, shuicheng.lin@intel.com, dri-devel@lists.freedesktop.org, Michal.Wajdeczko@intel.com, michal.mrozek@intel.com, raag.jadav@intel.com, ivan.briano@intel.com, matthew.auld@intel.com, thomas.hellstrom@linux.intel.com Subject: [PATCH v39 1/4] drm/xe/xe_pagefault: Disallow writes to read-only VMAs Date: Tue, 24 Mar 2026 15:29:37 +0000 Message-ID: <20260324152935.72444-7-jonathan.cavitt@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260324152935.72444-6-jonathan.cavitt@intel.com> References: <20260324152935.72444-6-jonathan.cavitt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The page fault handler should reject write/atomic access to read only VMAs. Add code to handle this in xe_pagefault_service after the VMA lookup. v2: - Apply max line length (Matthew) Fixes: fb544b844508 ("drm/xe: Implement xe_pagefault_queue_work") Signed-off-by: Jonathan Cavitt Suggested-by: Matthew Brost Cc: Shuicheng Lin Reviewed-by: Matthew Brost --- drivers/gpu/drm/xe/xe_pagefault.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_pagefault.c b/drivers/gpu/drm/xe/xe_pagefault.c index ea4857acf28d..918d595d1c1b 100644 --- a/drivers/gpu/drm/xe/xe_pagefault.c +++ b/drivers/gpu/drm/xe/xe_pagefault.c @@ -187,6 +187,12 @@ static int xe_pagefault_service(struct xe_pagefault *pf) goto unlock_vm; } + if (xe_vma_read_only(vma) && + pf->consumer.access_type != XE_PAGEFAULT_ACCESS_TYPE_READ) { + err = -EPERM; + goto unlock_vm; + } + atomic = xe_pagefault_access_is_atomic(pf->consumer.access_type); if (xe_vma_is_cpu_addr_mirror(vma)) -- 2.43.0