From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CFABFEEF29 for ; Tue, 7 Apr 2026 12:26:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D154010E405; Tue, 7 Apr 2026 12:26:08 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="LD++QH6E"; dkim-atps=neutral Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0962F10E405 for ; Tue, 7 Apr 2026 12:26:08 +0000 (UTC) Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 940A3C5B19C; Tue, 7 Apr 2026 12:26:40 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id CC7B8603C7; Tue, 7 Apr 2026 12:26:06 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 37FA91045020B; Tue, 7 Apr 2026 14:25:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1775564764; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=6jzvuat4HWr3Cl443Yz6IZbyUZIbJglUU0HNcZ8X2Bk=; b=LD++QH6E7COdIppSppSxtiyT7VLdluAuKm0X9wuLeN5mhI33iqlOCIbIC7TJFAMdxoHHHa TeiZ9wcEg8s+HLJ8aMIMOUdq9jmQ/7ei9ytKpCrseNna0cXa6q+zgsb8hDDqV+4PqvLIOp 9L6yvBoIXIoY86xrp/x3hmTaARd2g34144P7YcWFp6KkvfeYMeKeOegN6M05bR6LuFuLAs untNCrc2DJuHFimwfpkBxn+c3J3rVGoWpYspZUepqS1K9V42GXEYJTVtSfhje+7365xxqA ZAlXgOLFwpZ7DQMIyapx059691cQquTD3t6vtaxJ9mEA7ZPKtC7zzOEoCVHPhA== From: Luca Ceresoli Date: Tue, 07 Apr 2026 14:24:23 +0200 Subject: [PATCH v4 09/11] drm/bridge: imx8mp-hdmi-tx-connector-fixup: show a warning when adding the overlay MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260407-drm-lcdif-dbanc-v4-9-247a16e61ef9@bootlin.com> References: <20260407-drm-lcdif-dbanc-v4-0-247a16e61ef9@bootlin.com> In-Reply-To: <20260407-drm-lcdif-dbanc-v4-0-247a16e61ef9@bootlin.com> To: Marek Vasut , Stefan Agner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Liu Ying , Rob Herring , Saravana Kannan Cc: Damon Ding , "Kory Maincent (TI.com)" , =?utf-8?q?Herv=C3=A9_Codina?= , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Adam Ford , Alexander Stein , Christopher Obbard , Daniel Scally , Emanuele Ghidoli , Fabio Estevam , Francesco Dolcini , Frieder Schrempf , Gilles Talis , =?utf-8?q?Goran_Ra=C4=91enovi=C4=87?= , Heiko Schocher , Josua Mayer , Kieran Bingham , Marco Felsch , Martyn Welch , Oleksij Rempel , Peng Fan , Richard Hu , Shengjiu Wang , Stefan Eichenberger , Vitor Soares , Luca Ceresoli X-Mailer: b4 0.15.1 X-Last-TLS-Session-Version: TLSv1.3 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Describing the HDMI connector in device tree is recommended. While the overlay insertion is a workaround to avoid breaking existing devices, every dts should be improved by adding a connector description. Add a warning to make users aware as far as possible. As a warning line cannot hold all the relevant info, add a detailed comment in the code so it easy to find when the warning is seen. Signed-off-by: Luca Ceresoli Reviewed-by: Liu Ying --- Changes in v4: - add missing \n to warning string - Add Liu's R-by Patch added in v3. Kept as a separate comment w.r.t. the patch adding the overlay to let it be added in a later moment in case we want to convert existing dts files before adding the warning. --- .../gpu/drm/bridge/imx/imx8mp-hdmi-tx-connector-fixup.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx-connector-fixup.c b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx-connector-fixup.c index dc1736bfc3ac..aaac27d00590 100644 --- a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx-connector-fixup.c +++ b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx-connector-fixup.c @@ -44,6 +44,23 @@ static int __init imx8mp_hdmi_tx_connector_fixup_init(void) if (endpoint) return 0; + /* + * Boards with an HDMI connector should describe it in a device + * tree node with compatible = "hdmi-connector". + * + * If you see this warning, it means such a node was not found and + * a fallback one is added using a device tree overlay. Please add + * one in your device tree, also describing the exact connector + * type (the added overlay assumes Type A as a fallback, but it + * might be wrong). + * + * This node is necessary for modern DRM, where bridge drivers do + * not create a connector (see the DRM_BRIDGE_ATTACH_NO_CONNECTOR + * flag). See https://docs.kernel.org/gpu/drm-kms-helpers.html for + * more info. + */ + pr_warn("Please add a hdmi-connector DT node for imx8mp-hdmi-tx.\n"); + dtbo_start = __dtbo_imx8mp_hdmi_tx_connector_fixup_begin; dtbo_size = __dtbo_imx8mp_hdmi_tx_connector_fixup_end - __dtbo_imx8mp_hdmi_tx_connector_fixup_begin; -- 2.53.0