From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2EC21EDB7DC for ; Tue, 7 Apr 2026 09:39:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8B8C710E39D; Tue, 7 Apr 2026 09:39:16 +0000 (UTC) Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0411710E39D for ; Tue, 7 Apr 2026 09:39:13 +0000 (UTC) Received: from dfae2b116770.home.arpa (unknown [124.16.138.129]) by APP-01 (Coremail) with SMTP id qwCowAA33mm10NRp+0yADA--.59142S2; Tue, 07 Apr 2026 17:39:01 +0800 (CST) From: Wentao Liang To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Wentao Liang , stable@vger.kernel.org Subject: [PATCH] drm/bridge: it6505: fix use-after-free in it6505_parse_dt() Date: Tue, 7 Apr 2026 09:38:00 +0000 Message-Id: <20260407093800.291489-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: qwCowAA33mm10NRp+0yADA--.59142S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Ww4rtF4fXF1rKr17uF15Arb_yoW8WF1fpr srta15KFsrWa9xKrW8Ar1fJF1Yya1DJFWrCrW7Jw4Ivan5X3WkAFsrurZIqFy8CF1xZw4a yrs2kF9Fgr1F9r7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9K14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628v n2kIc2xKxwCY1x0262kKe7AKxVWUtVW8ZwCY02Avz4vE14v_GFWl42xK82IYc2Ij64vIr4 1l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK 67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI 8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAv wI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14 v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfUeQ6pDUUUU X-Originating-IP: [124.16.138.129] X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBgsKA2nUl8-62AAAsD X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Move of_node_put(ep) after the endpoint is fully used, otherwise the node may be freed before being accessed in the if (ep) block. Fixes: 380d920b582d ("drm/bridge: add it6505 driver to read data-lanes and link-frequencies from dt") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- drivers/gpu/drm/bridge/ite-it6505.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c index 89649c17ffad..2e01b331a168 100644 --- a/drivers/gpu/drm/bridge/ite-it6505.c +++ b/drivers/gpu/drm/bridge/ite-it6505.c @@ -3371,7 +3371,6 @@ static void it6505_parse_dt(struct it6505 *it6505) } ep = of_graph_get_endpoint_by_regs(np, 1, 0); - of_node_put(ep); if (ep) { len = it6505_get_data_lanes_count(ep, 1, 4); @@ -3384,14 +3383,13 @@ static void it6505_parse_dt(struct it6505 *it6505) *max_lane_count = MAX_LANE_COUNT; dev_err(dev, "error data-lanes, use default"); } + of_node_put(ep); } else { *max_lane_count = MAX_LANE_COUNT; dev_err(dev, "error endpoint, use default"); } ep = of_graph_get_endpoint_by_regs(np, 0, 0); - of_node_put(ep); - if (ep) { len = of_property_read_variable_u64_array(ep, "link-frequencies", @@ -3410,6 +3408,7 @@ static void it6505_parse_dt(struct it6505 *it6505) dev_err(dev, "error link frequencies, use default"); *max_dpi_pixel_clock = DPI_PIXEL_CLK_MAX; } + of_node_put(ep); } else { dev_err(dev, "error endpoint, use default"); *max_dpi_pixel_clock = DPI_PIXEL_CLK_MAX; -- 2.34.1