From: Thomas Zimmermann <tzimmermann@suse.de>
To: javierm@redhat.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, airlied@gmail.com, simona@ffwll.ch
Cc: dri-devel@lists.freedesktop.org, Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 4/5] drm/sysfb: simpledrm: Support power management
Date: Wed, 8 Apr 2026 14:03:17 +0200 [thread overview]
Message-ID: <20260408120722.328769-5-tzimmermann@suse.de> (raw)
In-Reply-To: <20260408120722.328769-1-tzimmermann@suse.de>
Set PM ops for the simpledrm driver. Suspend and resume the DRM
state on systems that support it.
Many systems lose the hardware's framebuffer settings on suspend,
hence resuming doesn't work there. Yet some systems, most notably
emulators, keep the hardware state across suspend/resume cycles.
There, DRM's suspend and resume helpers bring back the display on
resume.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/sysfb/simpledrm.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/drivers/gpu/drm/sysfb/simpledrm.c b/drivers/gpu/drm/sysfb/simpledrm.c
index 7a95d2dacd9d..fc168920f2c6 100644
--- a/drivers/gpu/drm/sysfb/simpledrm.c
+++ b/drivers/gpu/drm/sysfb/simpledrm.c
@@ -8,6 +8,7 @@
#include <linux/of_reserved_mem.h>
#include <linux/platform_data/simplefb.h>
#include <linux/platform_device.h>
+#include <linux/pm.h>
#include <linux/pm_domain.h>
#include <linux/regulator/consumer.h>
@@ -24,6 +25,7 @@
#include <drm/drm_gem_framebuffer_helper.h>
#include <drm/drm_gem_shmem_helper.h>
#include <drm/drm_managed.h>
+#include <drm/drm_modeset_helper.h>
#include <drm/drm_modeset_helper_vtables.h>
#include <drm/drm_print.h>
#include <drm/drm_probe_helper.h>
@@ -834,6 +836,24 @@ static struct drm_driver simpledrm_driver = {
* Platform driver
*/
+static int simpledrm_pm_suspend(struct device *dev)
+{
+ struct simpledrm_device *sdev = dev_get_drvdata(dev);
+ struct drm_device *drm = &sdev->sysfb.dev;
+
+ return drm_mode_config_helper_suspend(drm);
+}
+
+static int simpledrm_pm_resume(struct device *dev)
+{
+ struct simpledrm_device *sdev = dev_get_drvdata(dev);
+ struct drm_device *drm = &sdev->sysfb.dev;
+
+ return drm_mode_config_helper_resume(drm);
+}
+
+static DEFINE_SIMPLE_DEV_PM_OPS(simpledrm_pm_ops, simpledrm_pm_suspend, simpledrm_pm_resume);
+
static int simpledrm_probe(struct platform_device *pdev)
{
struct simpledrm_device *sdev;
@@ -874,6 +894,7 @@ static struct platform_driver simpledrm_platform_driver = {
.driver = {
.name = "simple-framebuffer", /* connect to sysfb */
.of_match_table = simpledrm_of_match_table,
+ .pm = pm_sleep_ptr(&simpledrm_pm_ops),
},
.probe = simpledrm_probe,
.remove = simpledrm_remove,
--
2.53.0
next prev parent reply other threads:[~2026-04-08 12:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 12:03 [PATCH 0/5] drm/sysfb: Support basic power management Thomas Zimmermann
2026-04-08 12:03 ` [PATCH 1/5] drm/sysfb: corebootdrm: Support " Thomas Zimmermann
2026-04-12 2:33 ` Claude review: " Claude Code Review Bot
2026-04-08 12:03 ` [PATCH 2/5] drm/sysfb: efidrm: " Thomas Zimmermann
2026-04-12 2:33 ` Claude review: " Claude Code Review Bot
2026-04-08 12:03 ` [PATCH 3/5] drm/sysfb: ofdrm: " Thomas Zimmermann
2026-04-12 2:33 ` Claude review: " Claude Code Review Bot
2026-04-08 12:03 ` Thomas Zimmermann [this message]
2026-04-12 2:33 ` Claude review: drm/sysfb: simpledrm: " Claude Code Review Bot
2026-04-08 12:03 ` [PATCH 5/5] drm/sysfb: vesadrm: " Thomas Zimmermann
2026-04-12 2:33 ` Claude review: " Claude Code Review Bot
2026-04-12 2:33 ` Claude review: drm/sysfb: Support basic " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260408120722.328769-5-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox