From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CC3CF364A4 for ; Thu, 9 Apr 2026 17:09:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CE16D10E843; Thu, 9 Apr 2026 17:09:37 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="2CyiOOQu"; dkim-atps=neutral Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) by gabe.freedesktop.org (Postfix) with ESMTPS id 321E910E843 for ; Thu, 9 Apr 2026 17:09:36 +0000 (UTC) Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 1E04F4E429AE; Thu, 9 Apr 2026 17:09:35 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id DEFAE603E4; Thu, 9 Apr 2026 17:09:34 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 0DC27104501D0; Thu, 9 Apr 2026 19:09:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1775754573; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=db8ka7P2uU7OnUSlW7uuT/LogKA95j6LgGKnwnPZSO8=; b=2CyiOOQu4VUIgXCcPbaIa9rE/A/G6NdNzxg2ZbsNEQV4Esai/av5qezbZP0xomYKv8EpOk Zj0XimgfS8gT3Im5b13pDqVpAccntr7rPk0gXW3ivSpln7rBcvQ9ea2evZf/nAPOidCMrZ kyQB9TbOz/iuM3mNye+U6WVwLZkNpEB2b8w9jxN/jWQKJiobzCon5qPOl1Br6utnZmjYHc D5gXaUZbSaOKx1D4Po5oq9n/oA6xhOdnx6ZmHWIrAGYNw8oHOnonfgs8EbTRHI44F5+4Cg FiWE+zG1NtKoK7/2kSrRYiiEBn7Z9xqAg5r5V2sZaUn6eDs6864r+TWF/8WqLQ== From: Kory Maincent Date: Thu, 09 Apr 2026 19:08:27 +0200 Subject: [PATCH RFC 11/12] drm/bridge: Wire drmm_connector_dp_init() via new DRM_BRIDGE_OP_DP flag MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260409-feat_link_cap-v1-11-7069e8199ce2@bootlin.com> References: <20260409-feat_link_cap-v1-0-7069e8199ce2@bootlin.com> In-Reply-To: <20260409-feat_link_cap-v1-0-7069e8199ce2@bootlin.com> To: Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , David Airlie , Simona Vetter , Dave Airlie , Jesse Barnes , Eric Anholt , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Chris Wilson Cc: Thomas Petazzoni , Mark Yacoub , Sean Paul , Louis Chauvet , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Simona Vetter , Kory Maincent X-Mailer: b4 0.14-dev-d4707 X-Last-TLS-Session-Version: TLSv1.3 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Introduce DRM_BRIDGE_OP_DP, a new bridge operation flag for bridges that provide DisplayPort connector operations with link training support. Bridges advertising this flag must fill the dp_link_train_caps field in struct drm_bridge with their link training capabilities. In drm_bridge_connector_init(), when a bridge sets DRM_BRIDGE_OP_DP, use drmm_connector_dp_init() instead of the generic drmm_connector_init() so the connector exposes link training state properties to userspace. This mirrors the existing pattern used for HDMI bridges. Signed-off-by: Kory Maincent --- drivers/gpu/drm/display/drm_bridge_connector.c | 26 +++++++++++++++++++++++++- include/drm/drm_bridge.h | 13 +++++++++++++ 2 files changed, 38 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/display/drm_bridge_connector.c b/drivers/gpu/drm/display/drm_bridge_connector.c index 39cc18f78eda1..e20b61bb03f12 100644 --- a/drivers/gpu/drm/display/drm_bridge_connector.c +++ b/drivers/gpu/drm/display/drm_bridge_connector.c @@ -13,7 +13,7 @@ #include #include #include -#include +#include #include #include #include @@ -108,6 +108,13 @@ struct drm_bridge_connector { * HDMI Audio infrastructure, if any (see &DRM_BRIDGE_OP_HDMI_AUDIO). */ struct drm_bridge *bridge_hdmi_audio; + /** + * @bridge_dp: + * + * The bridge in the chain that implements necessary support for the + * DisplayPort connector infrastructure, if any (see &DRM_BRIDGE_OP_DP). + */ + struct drm_bridge *bridge_dp; /** * @bridge_dp_audio: * @@ -766,6 +773,7 @@ static void drm_bridge_connector_put_bridges(struct drm_device *dev, void *data) drm_bridge_put(bridge_connector->bridge_hdmi_audio); drm_bridge_put(bridge_connector->bridge_dp_audio); drm_bridge_put(bridge_connector->bridge_hdmi_cec); + drm_bridge_put(bridge_connector->bridge_dp); } /** @@ -898,6 +906,15 @@ struct drm_connector *drm_bridge_connector_init(struct drm_device *drm, bridge_connector->bridge_hdmi_audio = drm_bridge_get(bridge); } + if (bridge->ops & DRM_BRIDGE_OP_DP) { + if (bridge_connector->bridge_dp) + return ERR_PTR(-EBUSY); + if (!bridge->dp_link_train_caps) + return ERR_PTR(-EINVAL); + + bridge_connector->bridge_dp = drm_bridge_get(bridge); + } + if (bridge->ops & DRM_BRIDGE_OP_DP_AUDIO) { if (bridge_connector->bridge_dp_audio) return ERR_PTR(-EBUSY); @@ -986,6 +1003,13 @@ struct drm_connector *drm_bridge_connector_init(struct drm_device *drm, max_bpc); if (ret) return ERR_PTR(ret); + } else if (bridge_connector->bridge_dp) { + ret = drmm_connector_dp_init(drm, connector, + &drm_bridge_connector_funcs, + bridge_connector->bridge_dp->dp_link_train_caps, + connector_type, ddc); + if (ret) + return ERR_PTR(ret); } else { ret = drmm_connector_init(drm, connector, &drm_bridge_connector_funcs, diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h index a8d67bd9ee505..b3df9dffd5bcc 100644 --- a/include/drm/drm_bridge.h +++ b/include/drm/drm_bridge.h @@ -1092,6 +1092,14 @@ enum drm_bridge_ops { * &drm_bridge_funcs->hdmi_clear_spd_infoframe callbacks. */ DRM_BRIDGE_OP_HDMI_SPD_INFOFRAME = BIT(10), + /** + * @DRM_BRIDGE_OP_DP: The bridge provides DisplayPort connector + * operations, including link training support. Bridges that set + * this flag must provide DisplayPort-related information and + * fill the &drm_bridge->dp_link_train_caps link training + * capabilities. + */ + DRM_BRIDGE_OP_DP = BIT(11), }; /** @@ -1267,6 +1275,11 @@ struct drm_bridge { */ void *hpd_data; + /** + * @dp_link_train_caps: DisplayPort link training capabilities + */ + const struct drm_connector_dp_link_train_caps *dp_link_train_caps; + /** * @next_bridge: Pointer to the following bridge, automatically put * when this bridge is freed (i.e. at destroy time). This is for -- 2.43.0