Claude review: drm/panthor: Use a local iomem base for firmware control registers

Claude Code Review Bot
2026-04-11T23:38:16Z

Patch Review

The MCU_CONTROL register offset change from `0x700` to `0x0` (relative to `MCU_CONTROL_BASE = 0x700`) is correct. MCU_STATUS changes from `0x704` to `0x4`, also correct.

The JOB_INT absolute register defines (`JOB_INT_RAWSTAT`, `JOB_INT_CLEAR`, `JOB_INT_MASK`, `JOB_INT_STAT`) are correctly removed since all IRQ accesses now go through `pirq->iomem` with generic `INT_*` offsets. The bit definitions (`JOB_INT_GLOBAL_IF`, `JOB_INT_CSG_IF`) are correctly retained.

The doorbell writes intentionally stay on `ptdev->iomem` (via `panthor_fw_ring_doorbell`) since doorbells live outside the MCU control window. This is clearly documented in the commit message.

No issues.

---
Generated by Claude Code Patch Reviewer