From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D87FFA1FD7 for ; Wed, 22 Apr 2026 16:49:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7B9A010EEB4; Wed, 22 Apr 2026 16:49:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="vnD5aShm"; dkim-atps=neutral Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0634610EEB3 for ; Wed, 22 Apr 2026 16:49:14 +0000 (UTC) Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id ED8011A33A5; Wed, 22 Apr 2026 16:49:12 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id C37685FA8F; Wed, 22 Apr 2026 16:49:12 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 7EA1A10460C15; Wed, 22 Apr 2026 18:49:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1776876551; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=GjZ3Li0hgSFG+5Kg7ETwAe+lLOQj73cG0WZcoLSfcXY=; b=vnD5aShmjCsLo7AieSsev83EoptEuEB5B2FG0aYYWcnJkpll1g/WwCgpPaWW34WWiuOj+s ltE/awsfBR5UloiYFQmuhNNh/gcjLxdFT3oDBn/jJF9PCVAqehymgVZEB4WRu6259oowF+ sxGbRWWwtJLo/+Q+oEPRE+v1meNr2c8QGDMUCNCOrXUKejTVAtqhU4rF207ub4F8pZfZj0 5PP0lt5rsfLxh55jAKGRNeZtKsCZQZ0r+xtdPcMWHLvlrz2s+BMMJ1xkvJNtP9do0plD29 UhwUkO73v0kgHabBD/CH+OwL9+8pzxpR+6lr/hWSRfG+Eio6zx8aHm+QJwXFKw== From: Louis Chauvet Date: Wed, 22 Apr 2026 18:48:05 +0200 Subject: [PATCH v4 08/37] drm/vkms: Add error handling in plane config creation MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260422-vkms-all-config-v4-8-dbb52e9aadc3@bootlin.com> References: <20260422-vkms-all-config-v4-0-dbb52e9aadc3@bootlin.com> In-Reply-To: <20260422-vkms-all-config-v4-0-dbb52e9aadc3@bootlin.com> To: Haneen Mohammed , Simona Vetter , Melissa Wen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , jose.exposito89@gmail.com, Jonathan Corbet , Shuah Khan , Miguel Ojeda , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: victoria@system76.com, sebastian.wick@redhat.com, victoria@system76.com, airlied@gmail.com, thomas.petazzoni@bootlin.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Louis Chauvet , llvm@lists.linux.dev X-Mailer: b4 0.16-dev X-Last-TLS-Session-Version: TLSv1.3 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" For future patches, it is useful to properly handle errors in vkms_config_create_plane. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_config.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_config.c b/drivers/gpu/drm/vkms/vkms_config.c index 5a654d6dead8..1fd2ed1167c5 100644 --- a/drivers/gpu/drm/vkms/vkms_config.c +++ b/drivers/gpu/drm/vkms/vkms_config.c @@ -384,13 +384,16 @@ void vkms_config_register_debugfs(struct vkms_device *vkms_device) ARRAY_SIZE(vkms_config_debugfs_list)); } -struct vkms_config_plane *vkms_config_create_plane(struct vkms_config *config) +struct vkms_config_plane __must_check *vkms_config_create_plane(struct vkms_config *config) { struct vkms_config_plane *plane_cfg; + int ret; plane_cfg = kzalloc_obj(*plane_cfg); - if (!plane_cfg) - return ERR_PTR(-ENOMEM); + if (!plane_cfg) { + ret = -ENOMEM; + goto fail; + } plane_cfg->config = config; plane_cfg->default_pipeline = false; @@ -400,6 +403,9 @@ struct vkms_config_plane *vkms_config_create_plane(struct vkms_config *config) list_add_tail(&plane_cfg->link, &config->planes); return plane_cfg; + +fail: + return ERR_PTR(ret); } EXPORT_SYMBOL_IF_KUNIT(vkms_config_create_plane); -- 2.54.0