From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E41EECD37B6 for ; Wed, 13 May 2026 07:54:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F1DE088668; Wed, 13 May 2026 07:54:31 +0000 (UTC) Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7652710E148 for ; Mon, 11 May 2026 06:40:06 +0000 (UTC) X-UUID: 3c12b0804d0411f1aa26b74ffac11d73-20260511 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12, REQID:f0f91fc8-8208-4355-aad3-255cd683fc87, IP:0, U RL:0,TC:0,Content:-5,EDM:25,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:20 X-CID-META: VersionHash:e7bac3a, CLOUDID:161d4b1f46ccd6a30e485e9a7e661017, BulkI D:nil,BulkQuantity:0,Recheck:0,SF:102|850|898,TC:nil,Content:0|15|50,EDM:5 ,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV :0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 3c12b0804d0411f1aa26b74ffac11d73-20260511 X-User: yanlonglong@kylinos.cn Received: from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1184201426; Mon, 11 May 2026 14:40:00 +0800 From: Bob ynn To: dri-devel@lists.freedesktop.org Cc: andy.yan@rock-chips.com, dmitry.baryshkov@linaro.org, yanlonglong Subject: [PATCH] drm/bridge: synopsys: dw-dp: fix bool function returning negative error code Date: Mon, 11 May 2026 14:39:41 +0800 Message-ID: <20260511063941.2070-1-yanlonglong@kylinos.cn> X-Mailer: git-send-email 2.47.1.windows.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Wed, 13 May 2026 07:53:28 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: yanlonglong The function dw_dp_video_need_vsc_sdp() is declared to return bool, but it returns -EINVAL when dw_dp_get_bridge_state() fails. Since -EINVAL is a non-zero value (-22), it is implicitly converted to true, which is the opposite of the intended behavior Fixes: 86eecc3a9c2e("drm/bridge: synopsys: Add DW DPTX Controller support library") Signed-off-by: yanlonglong --- drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c index 21541be094c4..7b99d91b3456 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c @@ -1143,7 +1143,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp) state = dw_dp_get_bridge_state(dp); if (!state) - return -EINVAL; + return false; if (!link->vsc_sdp_supported) return false; -- 2.43.0