From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DEBECD4F24 for ; Wed, 13 May 2026 13:10:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8361C10EE65; Wed, 13 May 2026 13:10:51 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="tbg0yfkl"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id CCF5010EE51 for ; Wed, 13 May 2026 13:10:44 +0000 (UTC) Received: from [127.0.1.1] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9B1FF1243; Wed, 13 May 2026 15:10:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1778677835; bh=SvGr15LIkhTg2rbMsXyqYuERM2cP+iPiWWKsOCPGKDM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=tbg0yfkl28MegPUR/DCcFtoe3i+gfmk1BhSjrwmtcThNmOJ+MrjQV4P/zcD0UfqGc S6LKDwhOjZG/HzD6xjkL3d4kx73V2niuVS0OUMofxhwunWHJb/EO3kfUBn9yJ7Iga0 v/C0ncu1vyDZ6MJk8ERNxiYSSeCjsNy03cBQTexU= From: Tomi Valkeinen Date: Wed, 13 May 2026 16:10:12 +0300 Subject: [PATCH v3 03/13] drm/bridge: tc358762: Improve LCDCTRL defines MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260513-tc358762-fixes-v3-3-6698b55008b9@ideasonboard.com> References: <20260513-tc358762-fixes-v3-0-6698b55008b9@ideasonboard.com> In-Reply-To: <20260513-tc358762-fixes-v3-0-6698b55008b9@ideasonboard.com> To: Marek Vasut , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dave Stevenson , Tomi Valkeinen X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=3005; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=SvGr15LIkhTg2rbMsXyqYuERM2cP+iPiWWKsOCPGKDM=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBqBHhLLW08+MpyIy2BpLeyg+Vy6XWaabBYr34oD ptvdYH9JxWJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCagR4SwAKCRD6PaqMvJYe 9SWWD/9fJx0BAyUdekCd+JHx0QK+2rn5z6DDec3ZrvMSsHObBV+qbhhU53xH3vJ7AI1idGOmfaA u+fzlj/1EbJzKT+Ot09iw7ypL0Q1JpMtxG2AFZkyGqP+yNQYOQ7B0MshcMUTQZlPkhxZ/DlhjS6 7BH6GDdtocMqNSHdWOXf6ZEVmGS/t/N3SVH3AsTv8ZBnriyo6CgIMHT/rAh0Qbbp40w5ZRrAVpa 8uuoZ9X5aCJfjP4Y+mRMCNYo48IS7h3ihF9f9A210GbZc2wxGVJ+H4bH0MFpd/DS8yqkEPEkELO 4DnKOe/yuKiurmqwriLNWiidzWdZYC/DIugNPBY530aC8oyAh67QUBa0bnmH/TouCdyQ421Av4H GlLThs2fQagCZC7yJVJlSU7SpFS9s8g/NQjUCq7ucVggel2pR/r4RMU/JDBwdHf13dtY3e5BtyR Kt21nEvciXuS0jXdv1qXy6zpZlQEJzj9sDC2w2xZrzW151S9c22SbXV2ywAeo6RBdeSV7LgXHly InDmu+h55IdCT6dpg1axGRhc5fBub9/b80T1/bU7aDrM6T+C1wKFMXMbTfU17x00aznFRdzfb61 855l3g14DniG3d0lPTCGFoEv7FT6ueGqX+OHrNQL5dhjzWp/wfAnbIiG6CFYaWkFbYr6M4l0ujL sghfUoJcvmwnmbw== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" LCDCTRL fields are quite wrong in the driver. Fix the field defines. A few notes about the wrong fields: LCDCTRL_VSDELAY(1) actually sets LCDCTRL_DCLK_POL LCDCTRL_UNK6 | LCDCTRL_VTGEN actually set LCDCTRL_PXLFORM_RGB888 LCDCTRL_RGB888 actually sets LCDCTRL_DPI_EN The total still resulted in a working display even if the defines were quite wrong. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358762.c | 33 ++++++++++++++++++++------------- 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c index c8b9984ff301..669052074974 100644 --- a/drivers/gpu/drm/bridge/tc358762.c +++ b/drivers/gpu/drm/bridge/tc358762.c @@ -47,17 +47,22 @@ #define DSI_LANEENABLE_L0EN BIT(1) #define DSI_LANEENABLE_L1EN BIT(2) -/* LCDC/DPI Host Registers, based on guesswork that this matches TC358764 */ +/* LCDC/DPI Registers */ #define LCDCTRL 0x0420 /* Video Path Control */ #define LCDCTRL_MSF BIT(0) /* Magic square in RGB666 */ -#define LCDCTRL_VTGEN BIT(4)/* Use chip clock for timing */ -#define LCDCTRL_UNK6 BIT(6) /* Unknown */ -#define LCDCTRL_EVTMODE BIT(5) /* Event mode */ -#define LCDCTRL_RGB888 BIT(8) /* RGB888 mode */ -#define LCDCTRL_HSPOL BIT(17) /* Polarity of HSYNC signal */ -#define LCDCTRL_DEPOL BIT(18) /* Polarity of DE signal */ -#define LCDCTRL_VSPOL BIT(19) /* Polarity of VSYNC signal */ -#define LCDCTRL_VSDELAY(v) (((v) & 0xfff) << 20) /* VSYNC delay */ +#define LCDCTRL_VTGEN BIT(1) /* Use chip clock for timing */ +#define LCDCTRL_PXLFORM GENMASK_U32(6, 4) +#define LCDCTRL_PXLFORM_RGB666 0 /* x:R:G:B 6:8:8:8 */ +#define LCDCTRL_PXLFORM_RGB666_24 1 /* x:R:x:G:x:B 2:6:2:6:2:6 */ +#define LCDCTRL_PXLFORM_RGB565 2 /* x:R:G:B 8:5:6:5 */ +#define LCDCTRL_PXLFORM_RGB565_1 3 /* x:R:x:G:x:B 3:5:2:6:3:5 */ +#define LCDCTRL_PXLFORM_RGB565_2 4 /* x:R:x:G:x:B:x 2:5:3:6:2:5:1 */ +#define LCDCTRL_PXLFORM_RGB888 5 /* R:G:B 8:8:8 */ +#define LCDCTRL_DPI_EN BIT(8) +#define LCDCTRL_HSYNC_POL BIT(17) /* Polarity of HSYNC signal */ +#define LCDCTRL_DE_POL BIT(18) /* Polarity of DE signal */ +#define LCDCTRL_VSYNC_POL BIT(19) /* Polarity of VSYNC signal */ +#define LCDCTRL_DCLK_POL BIT(20) /* Polarity of pixel clock */ /* SPI Master Registers */ #define SPICMR 0x0450 @@ -140,14 +145,16 @@ static int tc358762_init(struct tc358762 *ctx) tc358762_write(ctx, SPICMR, 0x00); - lcdctrl = LCDCTRL_VSDELAY(1) | LCDCTRL_RGB888 | - LCDCTRL_UNK6 | LCDCTRL_VTGEN; + lcdctrl = FIELD_PREP(LCDCTRL_PXLFORM, LCDCTRL_PXLFORM_RGB888) | + LCDCTRL_DPI_EN; + + lcdctrl |= LCDCTRL_DCLK_POL; if (ctx->mode.flags & DRM_MODE_FLAG_NHSYNC) - lcdctrl |= LCDCTRL_HSPOL; + lcdctrl |= LCDCTRL_HSYNC_POL; if (ctx->mode.flags & DRM_MODE_FLAG_NVSYNC) - lcdctrl |= LCDCTRL_VSPOL; + lcdctrl |= LCDCTRL_VSYNC_POL; tc358762_write(ctx, LCDCTRL, lcdctrl); -- 2.43.0