On Thu, May 14, 2026 at 12:24:49PM -0500, Aaron Kling via B4 Relay wrote: > From: Aaron Kling > > The Chipone ICNA35xx series of DDICs are high refresh, low power > MIPI-DSI drivers for OLED panels. The icna3512 is used by the Ayn Odin 2 > Portal and the icna3520 is used by the Ayn Thor top panel and the Ayn > Odin 3. > > Signed-off-by: Aaron Kling > --- > .../bindings/display/panel/chipone,icna35xx.yaml | 79 ++++++++++++++++++++++ > 1 file changed, 79 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/chipone,icna35xx.yaml b/Documentation/devicetree/bindings/display/panel/chipone,icna35xx.yaml > new file mode 100644 > index 00000000000000..6464d8d0cf86d5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/chipone,icna35xx.yaml Filename matching a compatible please. > @@ -0,0 +1,79 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/chipone,icna35xx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Chipone ICNA35xx display drivers > + > +maintainers: > + - Neil Armstrong > + > +description: > + The Chipone ICNA35xx are a series of DDICs connected > + using a MIPI-DSI video interface. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - ayaneo,pocketds-panel-top > + - ayntec,odin2portal-panel > + - const: chipone,icna3512 > + > + - items: > + - enum: > + - ayntec,odin3-panel > + - ayntec,thor-panel-top > + - const: chipone,icna3520 Commit message should state why these ddics are not compatible with one another. Rest of this seems okay. pw-bot: changes-requested Thanks, Conor.