On Thu, May 21, 2026 at 04:00:50PM +0100, Vitor Soares wrote: > From: Vitor Soares > > Add the compatible string for the LG LP156WF1 15.6" FHD (1920x1080) > dual-channel TFT LCD LVDS panel. > > Assisted-by: Claude:claude-sonnet-4.6 > Signed-off-by: Vitor Soares > --- > Documentation/devicetree/bindings/display/panel/panel-lvds.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml > index 45183a1439ce..a6af2b9cc2f9 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml > +++ b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml > @@ -58,6 +58,8 @@ properties: > - hydis,hv070wx2-1e0 > # Jenson Display BL-JT60050-01A 7" WSVGA (1024x600) color TFT LCD LVDS panel > - jenson,bl-jt60050-01a > + # LG LP156WF1 15.6" FHD (1920x1080) dual-channel TFT LCD LVDS panel > + - lg,lp156wf1 > # Logic Technologies LT170410-2WHC 10.1" 1280x800 IPS TFT Cap Touch Mod. > - logictechno,lt170410-2whc > # Riverdi RVT101HVLNWC00 10.1" WXGA (1280x800) TFT LCD LVDS panel Copy pasting a reply from me to sashiko-bot, cos the mail from it only went to the submitter, dt maintainers and dt list: |On Thu, May 21, 2026 at 03:27:16PM +0000, sashiko-bot@kernel.org wrote: |> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: |> - [Medium] The dt-binding fails to enforce the dual-channel requirement (the `ports` property) for the newly added `lg,lp156wf1` compatible string. |> -- |> |> commit a568203d1851908daadd835b566099e0a123357a |> Author: Vitor Soares |> dt-bindings: display: panel-lvds: Add LG LP156WF1 |> |> This commit adds the compatible string for the LG LP156WF1 15.6" FHD |> dual-channel TFT LCD LVDS panel to the generic panel-lvds schema. |> |> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml |> > index 45183a1439ce9..a6af2b9cc2f9a 100644 |> > --- a/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml |> > +++ b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml |> > @@ -58,6 +58,8 @@ properties: |> > - hydis,hv070wx2-1e0 |> > # Jenson Display BL-JT60050-01A 7" WSVGA (1024x600) color TFT LCD LVDS panel |> > - jenson,bl-jt60050-01a |> > + # LG LP156WF1 15.6" FHD (1920x1080) dual-channel TFT LCD LVDS panel |> > + - lg,lp156wf1 |> |> [Severity: Medium] |> Since the commit message indicates this is a dual-channel panel, shouldn't we |> add an if-then conditional block to require the ports property specifically for |> this compatible string? | |No idea if this is accurate, but if it is accurate, would the |lvds-dual-ports bindings come into play? | |> |> Currently, the panel-lvds.yaml schema allows panels to be configured with |> either a single port or multiple ports. Without a specific conditional block |> enforcing required: [ports] for lg,lp156wf1, a device tree incorrectly |> configuring this dual-channel hardware with only a single port will silently |> pass validation. |> |> -- |> Sashiko AI review · https://sashiko.dev/#/patchset/20260521150038.103538-17-ivitro@gmail.com?part=14 I don't understand these deviecs enough to know if this is a valid report.