From: Lizhi Hou <lizhi.hou@amd.com>
To: <ogabbay@kernel.org>, <quic_jhugo@quicinc.com>,
<mario.limonciello@amd.com>, <karol.wachowski@linux.intel.com>
Cc: Lizhi Hou <lizhi.hou@amd.com>, <linux-kernel@vger.kernel.org>,
<linaro-mm-sig@lists.linaro.org>,
<dri-devel@lists.freedesktop.org>, <Christian.Koenig@amd.com>,
<simona@ffwll.ch>, <max.zhen@amd.com>, <sonal.santan@amd.com>
Subject: [PATCH V1] Revert "accel/amdxdna: Support read-only user-pointer BO mappings"
Date: Thu, 21 May 2026 09:29:30 -0700 [thread overview]
Message-ID: <20260521162930.1451042-1-lizhi.hou@amd.com> (raw)
This reverts commit f649e63d4a6423eda8eb208638849fd6396aedd7.
The read-only feature requires further consideration.
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
---
drivers/accel/amdxdna/amdxdna_ubuf.c | 29 ++--------------------------
1 file changed, 2 insertions(+), 27 deletions(-)
diff --git a/drivers/accel/amdxdna/amdxdna_ubuf.c b/drivers/accel/amdxdna/amdxdna_ubuf.c
index 3769210c55cc..4c0647057759 100644
--- a/drivers/accel/amdxdna/amdxdna_ubuf.c
+++ b/drivers/accel/amdxdna/amdxdna_ubuf.c
@@ -125,26 +125,6 @@ static const struct dma_buf_ops amdxdna_ubuf_dmabuf_ops = {
.vunmap = amdxdna_ubuf_vunmap,
};
-static int readonly_va_entry(struct amdxdna_drm_va_entry *va_ent)
-{
- struct mm_struct *mm = current->mm;
- struct vm_area_struct *vma;
- int ret;
-
- mmap_read_lock(mm);
-
- vma = find_vma(mm, va_ent->vaddr);
- if (!vma ||
- vma->vm_start > va_ent->vaddr ||
- vma->vm_end - va_ent->vaddr < va_ent->len)
- ret = -ENOENT;
- else
- ret = vma->vm_flags & VM_WRITE ? 0 : 1;
-
- mmap_read_unlock(mm);
- return ret;
-}
-
struct dma_buf *amdxdna_get_ubuf(struct drm_device *dev,
u32 num_entries, void __user *va_entries)
{
@@ -154,7 +134,6 @@ struct dma_buf *amdxdna_get_ubuf(struct drm_device *dev,
struct amdxdna_ubuf_priv *ubuf;
u32 npages, start = 0;
struct dma_buf *dbuf;
- bool readonly = true;
int i, ret;
DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
@@ -193,10 +172,6 @@ struct dma_buf *amdxdna_get_ubuf(struct drm_device *dev,
ret = -EINVAL;
goto free_ent;
}
-
- /* Pin pages as writable as long as not all entries are read-only. */
- if (readonly && readonly_va_entry(&va_ent[i]) != 1)
- readonly = false;
}
ubuf->nr_pages = exp_info.size >> PAGE_SHIFT;
@@ -219,7 +194,7 @@ struct dma_buf *amdxdna_get_ubuf(struct drm_device *dev,
npages = va_ent[i].len >> PAGE_SHIFT;
ret = pin_user_pages_fast(va_ent[i].vaddr, npages,
- (readonly ? 0 : FOLL_WRITE) | FOLL_LONGTERM,
+ FOLL_WRITE | FOLL_LONGTERM,
&ubuf->pages[start]);
if (ret >= 0) {
start += ret;
@@ -236,7 +211,7 @@ struct dma_buf *amdxdna_get_ubuf(struct drm_device *dev,
exp_info.ops = &amdxdna_ubuf_dmabuf_ops;
exp_info.priv = ubuf;
- exp_info.flags = (readonly ? O_RDONLY : O_RDWR) | O_CLOEXEC;
+ exp_info.flags = O_RDWR | O_CLOEXEC;
dbuf = dma_buf_export(&exp_info);
if (IS_ERR(dbuf)) {
--
2.34.1
next reply other threads:[~2026-05-21 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 16:29 Lizhi Hou [this message]
2026-05-22 7:29 ` [PATCH V1] Revert "accel/amdxdna: Support read-only user-pointer BO mappings" Christian König
2026-05-25 9:46 ` Claude review: " Claude Code Review Bot
2026-05-25 9:46 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260521162930.1451042-1-lizhi.hou@amd.com \
--to=lizhi.hou@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=karol.wachowski@linux.intel.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=max.zhen@amd.com \
--cc=ogabbay@kernel.org \
--cc=quic_jhugo@quicinc.com \
--cc=simona@ffwll.ch \
--cc=sonal.santan@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox