From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5DF3CD5BB0 for ; Fri, 22 May 2026 14:42:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7E17510F65F; Fri, 22 May 2026 14:42:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="TTpiOWei"; dkim-atps=neutral Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id C1C1510E4B6 for ; Thu, 21 May 2026 16:46:36 +0000 (UTC) Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-490388fd0dbso8750375e9.0 for ; Thu, 21 May 2026 09:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779381995; x=1779986795; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=NA/nM16UoxaTsk3A7SWQL7q3HkgK647mNtY2rDcRyyc=; b=TTpiOWeiFWUfAbnU9qhNz35ZYcE1aZrtiVIQBGuIHP9g8HcTPKaWyrdxazCFF6Wt6t U5IRxyK1k9rU9z9DPPUBzEJyRjxmcv/iDJduGZthJkl4AZaMheqPhMCiYg2q6HjF5wzf 0Dm1oye6c3hgOzLszPemltJEVkNzzVuI+D56wmSvITdpBduXxx+u3QAD4Hchg5XDSxBE R2jGA2uOLv9iMnJ6rCczkxMuSYIoQePLvIJLALnzcpeNCGgGGHVJC1vwurIlt30LeQBJ YCXlPJjN8riF/d8udOaJeoBLFB7sgQd/OjJ1JeqkQu9KrLp552t5/kaAfUvMXpvaVMTX tIZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779381995; x=1779986795; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NA/nM16UoxaTsk3A7SWQL7q3HkgK647mNtY2rDcRyyc=; b=AweUyLe+K5GC3wclBVlzy4t+TYHadFpzHJIw/nbFm5GIFcEoDwtCjNsTtubNu3GjbJ KeaqX/5E4TVluwV62+tGJr4V8YYr6+q3hM8q8Sw94M+rVvtNA0pFG4XvcbmErjCx9SnD C0fa8JOY4sy6h5cB3l7J2iQOQfsXMCTUPo1ldTQm8Y8Lu9Tg3hmjGUwqOGIPjVeTIRDs MDOVh6gpAtcU7k59LGB+94hdFhzU4YaVn5j29b8UCXTU2Pp7AUKa85UfoJVTo4hG/yPU 2R/a9q0Vwxay099oYrCKymi+wazxqCn+bVGyOtG8eFRhZCFbVSuXfBR8DS2rw+FKLjMo IiQA== X-Forwarded-Encrypted: i=1; AFNElJ+YpHMPYKCxlN89rj6fVs7ZoMSeO4Ud0iBGhaLgsEt3m2OgxDnon8jy7cS8YawnkpE2MyF34nXLtm0=@lists.freedesktop.org X-Gm-Message-State: AOJu0YypS+27vUKNQoMBMFkagbGypO2YMSksA9yWiFWSLHeTvpba4YQE TTAOex9oUMlWb38Aqy/rGRHtSlnoKhFvCw0ddowP9rJDo9Wtzm49gdy3 X-Gm-Gg: Acq92OFafGYWlD8bwVCQfQJxQTARf0t5rHzwVnVEZ5067NrlK8/iUejsabJLmrooM8c j+QzL6WmXNEwMNKxtX8Ww8QyxXMbOEDW2nDrYpbXDpldAixvZoiGEwtpw9lEIwzHiBjS3puewhn Vvz5q/jIMkBU/zZ32QzWQO1nd1xFP0/uaWoA2T0oyTlnlPcpJWeQ2x8ACTeNW7POvIJKKZCndHX NgCzZtw1CIkMbp8R05yNQqRMjEHguJ6tKBZ2sgXbZlDoEdxDvaN1kpQv26SWtFeOJg4jRhLXrGS R4giRe7ItpQKgHVoe5uJaa+NVhRsEQhIVTv9x4k53vQn0TrPPv125ioaLc4PwMcD7Qe5Aokp3Rv nDmaPLkt/m+gzJ2hL4TiF88GvKhrSjbpY96+4gCmNKwCoSGgwdb0hdXlxuVP0QrwnvYZJ3rgDjq ke613GQgq46V74b0YkJTnW7K+U3O7E5ngtcMpcG5++rCxcRsSXmq2qdyaysfWCY7dV X-Received: by 2002:a05:600c:45c6:b0:488:ac01:72de with SMTP id 5b1f17b1804b1-49036033502mr53623425e9.5.1779381994891; Thu, 21 May 2026 09:46:34 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49035ecac15sm31613075e9.6.2026.05.21.09.46.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 09:46:34 -0700 (PDT) Date: Thu, 21 May 2026 17:46:31 +0100 From: David Laight To: Kees Cook Cc: Luis Chamberlain , Pengpeng Hou , stable@vger.kernel.org, Petr Pavlu , Richard Weinberger , Anton Ivanov , Johannes Berg , "Rafael J. Wysocki" , Len Brown , Corey Minyard , Gabriel Somlo , "Michael S. Tsirkin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Bart Van Assche , Jason Gunthorpe , Leon Romanovsky , Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab , Bjorn Helgaas , Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Greg Kroah-Hartman , Jiri Slaby , Alan Stern , Jason Wang , Xuan Zhuo , Eugenio =?UTF-8?B?UMOpcmV6?= , Jason Baron , Jim Cromie , Tiwei Bie , Benjamin Berg , Ilpo =?UTF-8?B?SsOkcnZpbmVu?= , "David E. Box" , "Maciej W. Rozycki" , Srinivas Pandruvada , Peter Zijlstra , Heiko Carstens , Vasily Gorbik , Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vinod Koul , Frank Li , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Andy Shevchenko , Georgia Garcia , kvm@vger.kernel.org, dmaengine@vger.kernel.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, openipmi-developer@lists.sourceforge.net, qemu-devel@nongnu.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 01/11] params: bound array element output to the caller's page buffer Message-ID: <20260521174631.71a06440@pumpkin> In-Reply-To: <20260521133326.2465264-1-kees@kernel.org> References: <20260521133315.work.845-kees@kernel.org> <20260521133326.2465264-1-kees@kernel.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Fri, 22 May 2026 14:41:04 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 21 May 2026 06:33:14 -0700 Kees Cook wrote: > From: Pengpeng Hou > > param_array_get() appends each element's string representation into the > shared sysfs page buffer by passing buffer + off to the element getter. > > That works for getters that only write a small bounded string, but > param_get_charp() and similar helpers format against PAGE_SIZE from the > pointer they receive. Once off is non-zero, an element getter can > therefore write past the end of the original sysfs page buffer. > > Collect each element into a temporary PAGE_SIZE buffer first and then > copy only the remaining space into the caller's page buffer. Should this be using a 4k buffer on all architectures? Initially perhaps just using a different name for the constant until all the associated PAGE_SIZE limits have been removed. -- David > > Cc: stable@vger.kernel.org > Reviewed-by: Petr Pavlu > Signed-off-by: Pengpeng Hou > Signed-off-by: Kees Cook > --- > kernel/params.c | 26 ++++++++++++++++++++------ > 1 file changed, 20 insertions(+), 6 deletions(-) > > diff --git a/kernel/params.c b/kernel/params.c > index 74d620bc2521..752721922a15 100644 > --- a/kernel/params.c > +++ b/kernel/params.c > @@ -475,22 +475,36 @@ static int param_array_set(const char *val, const struct kernel_param *kp) > static int param_array_get(char *buffer, const struct kernel_param *kp) > { > int i, off, ret; > + char *elem_buf; > const struct kparam_array *arr = kp->arr; > struct kernel_param p = *kp; > > + elem_buf = kmalloc(PAGE_SIZE, GFP_KERNEL); > + if (!elem_buf) > + return -ENOMEM; > + > for (i = off = 0; i < (arr->num ? *arr->num : arr->max); i++) { > - /* Replace \n with comma */ > - if (i) > - buffer[off - 1] = ','; > p.arg = arr->elem + arr->elemsize * i; > check_kparam_locked(p.mod); > - ret = arr->ops->get(buffer + off, &p); > + ret = arr->ops->get(elem_buf, &p); > if (ret < 0) > - return ret; > + goto out; > + ret = min(ret, (int)(PAGE_SIZE - 1 - off)); > + if (!ret) > + break; > + /* Replace the previous element's trailing newline with a comma. */ > + if (i) > + buffer[off - 1] = ','; > + memcpy(buffer + off, elem_buf, ret); > off += ret; > + if (off == PAGE_SIZE - 1) > + break; > } > buffer[off] = '\0'; > - return off; > + ret = off; > +out: > + kfree(elem_buf); > + return ret; > } > > static void param_array_free(void *arg)