From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16CF2CD5BB8 for ; Sat, 23 May 2026 19:46:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6F79810E634; Sat, 23 May 2026 19:46:28 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="QPM9JWpy"; dkim-atps=neutral Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0F1D910E6A1; Sat, 23 May 2026 19:46:27 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; t=1779565576; cv=none; d=zohomail.com; s=zohoarc; b=PQtAsBcoNUBp/6kxGDEpgGq0b7GNFkDSdiJaeF9z0TtEGXJvLbsReM5erqSTSiW4EGQ+ENDbxhCN1RtA/8cO3hYiqtyF99iZ9P7CNJpFrY88l/jFCKGKuXecnDY5FxldlWw+AUP7y8q7YCmrQg07vpfuCzWTMDECaul/X0UPTWc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779565576; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=uXlMHiZXyK0pHqFsZkkWeqkdCGOzg631Kuqphs1XteU=; b=O1wgR2FS5gnf9O1OiKQGwkkpjqopq59sx1RZL62ssScqbJrFG9HqOA2xO+Bee2xMpUwysZSj1BDQY9vg4TF20x+XRnFmNOhu0Avgo8Bc6N4YFnKELt6t9GoNjc4ge+BTXZepNP+Jh+gccB9cFsVqnHYNK8nRTrw5J3kfLvCk1J8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779565576; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=uXlMHiZXyK0pHqFsZkkWeqkdCGOzg631Kuqphs1XteU=; b=QPM9JWpyJKli8E4rh2fxQK89HYzVrWkD2+ehCOVfVCN7Nk3jVLpjoyY1KfZiI6sa SJZiTk0iaBCy1qubh7kYaQVdahtfpbUVDx3n27KQ50R13DuEz1RpQhoTO1H03HbegWj 70pFxNQKc4rklwlpVtyU3Cq1RfQTYWhIcaPbZbzY= Received: by mx.zohomail.com with SMTPS id 177956557541210.67986265494369; Sat, 23 May 2026 12:46:15 -0700 (PDT) From: Nicolas Frattaroli Date: Sat, 23 May 2026 21:43:46 +0200 Subject: [PATCH v16 11/28] drm/i915/hdmi: Add YCBCR444 handling for sink formats MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260523-color-format-v16-11-24340c5e4732@collabora.com> References: <20260523-color-format-v16-0-24340c5e4732@collabora.com> In-Reply-To: <20260523-color-format-v16-0-24340c5e4732@collabora.com> To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Dmitry Baryshkov , Sascha Hauer , Rob Herring , Jonathan Corbet , Shuah Khan , Daniel Stone Cc: kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-doc@vger.kernel.org, wayland-devel@lists.freedesktop.org, Nicolas Frattaroli X-Mailer: b4 0.15.2 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" In anticipation of userspace being able to explicitly select supported sink formats, add handling of the YCBCR444 sink format. The AUTO path does not choose this format, but with explicit format selection added to the driver, it becomes a possibility. Check for YCBCR444 support on the sink in sink_bpc_possible, and on the source and sink in sink_format_valid. Acked-by: Daniel Stone Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/i915/display/intel_hdmi.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c index 9076c2b176ec..6c6a3a0677fe 100644 --- a/drivers/gpu/drm/i915/display/intel_hdmi.c +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c @@ -1966,6 +1966,8 @@ static bool intel_hdmi_sink_bpc_possible(struct drm_connector *_connector, if (sink_format == INTEL_OUTPUT_FORMAT_YCBCR420) return hdmi->y420_dc_modes & DRM_EDID_YCBCR420_DC_36; + else if (sink_format == INTEL_OUTPUT_FORMAT_YCBCR444) + return info->edid_hdmi_ycbcr444_dc_modes & DRM_EDID_HDMI_DC_36; else return info->edid_hdmi_rgb444_dc_modes & DRM_EDID_HDMI_DC_36; case 10: @@ -1974,6 +1976,8 @@ static bool intel_hdmi_sink_bpc_possible(struct drm_connector *_connector, if (sink_format == INTEL_OUTPUT_FORMAT_YCBCR420) return hdmi->y420_dc_modes & DRM_EDID_YCBCR420_DC_30; + else if (sink_format == INTEL_OUTPUT_FORMAT_YCBCR444) + return info->edid_hdmi_ycbcr444_dc_modes & DRM_EDID_HDMI_DC_30; else return info->edid_hdmi_rgb444_dc_modes & DRM_EDID_HDMI_DC_30; case 8: @@ -2021,6 +2025,17 @@ intel_hdmi_mode_clock_valid(struct drm_connector *_connector, int clock, return status; } +static bool +intel_hdmi_can_ycbcr444(struct intel_connector *connector) +{ + const struct intel_display *display = to_intel_display(connector); + + if (!HAS_GMCH(display)) + return true; + + return false; +} + static enum drm_mode_status intel_hdmi_sink_format_valid(struct intel_connector *connector, const struct drm_display_mode *mode, @@ -2036,6 +2051,15 @@ intel_hdmi_sink_format_valid(struct intel_connector *connector, !drm_mode_is_420(info, mode)) return MODE_NO_420; + return MODE_OK; + case INTEL_OUTPUT_FORMAT_YCBCR444: + if (!has_hdmi_sink) + return MODE_BAD; + if (!intel_hdmi_can_ycbcr444(connector)) + return MODE_BAD; + if (!(info->color_formats & BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR444))) + return MODE_BAD; + return MODE_OK; case INTEL_OUTPUT_FORMAT_RGB: return MODE_OK; -- 2.54.0