From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BEB15CD5BC9 for ; Mon, 25 May 2026 23:02:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4CB5C10E349; Mon, 25 May 2026 23:02:13 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="bemvlSxN"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7375610E346 for ; Mon, 25 May 2026 23:02:11 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 489FE445BA; Mon, 25 May 2026 23:02:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B3D11F000E9; Mon, 25 May 2026 23:02:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779750131; bh=NQRc8RHwdq2jCkTtlcpPnLRgr54Ug9pwCPdCfI4Dghg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=bemvlSxNh4VCbbJBewp9R3s35oCxzFYf5OJRuU8MFY94wQjEozOwJtL7tVdOuBkMb RkfJZi3QG36XDq2cD+/Akcb7+E6xxjqscKykGMmDuNJlFvMJxtiWqGfpRYfEHANUaG X9vR8mC/NahBsBRFhggzW6gDuVehbFYpYweU/4nGZWyKlfy3G9cfDsOzFKdkO3LrCy +88CXA5Qw4eLST6zCYc9KSGlpr/ChYBCKi0wk9tNtXz3NCf2u12UfDJXidFaOnHIXy F9+os/nKQTfuz6NHFlYogN3iZEJMAnzjmufMSM6YohFKl5e+NnByUArsGUR7IhYbtz jVNuuvbeRKUWA== From: Danilo Krummrich To: dakr@kernel.org, aliceryhl@google.com, daniel.almeida@collabora.com, boris.brezillon@collabora.com, deborah.brouwer@collabora.com, gary@garyguo.net Cc: dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org Subject: [PATCH 2/2] gpu: drm: tyr: use IoMem directly instead of Devres Date: Tue, 26 May 2026 01:01:44 +0200 Message-ID: <20260525230152.277820-3-dakr@kernel.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260525230152.277820-1-dakr@kernel.org> References: <20260525230152.277820-1-dakr@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Now that IoMem is lifetime-parameterized, use it directly in probe rather than wrapping it in Devres and Arc. The I/O memory mapping is only used during probe and not stored in driver data, so device-managed revocation is unnecessary. This removes the Devres access(dev) pattern from issue_soft_reset(), GpuInfo::new(), and l2_power_on(), simplifying register access. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/tyr/driver.rs | 19 ++++++------------- drivers/gpu/drm/tyr/gpu.rs | 13 +++---------- 2 files changed, 9 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/tyr/driver.rs b/drivers/gpu/drm/tyr/driver.rs index 5f4c484f671f..b9a5cc5fc678 100644 --- a/drivers/gpu/drm/tyr/driver.rs +++ b/drivers/gpu/drm/tyr/driver.rs @@ -6,11 +6,9 @@ OptionalClk, // }, device::{ - Bound, Core, Device, // }, - devres::Devres, dma::{ Device as DmaDevice, DmaMask, // @@ -30,7 +28,6 @@ sizes::SZ_2M, sync::{ aref::ARef, - Arc, Mutex, // }, time, // @@ -44,7 +41,7 @@ regs::gpu_control::*, // }; -pub(crate) type IoMem = kernel::io::mem::IoMem<'static, SZ_2M>; +pub(crate) type IoMem<'a> = kernel::io::mem::IoMem<'a, SZ_2M>; pub(crate) struct TyrDrmDriver; @@ -74,15 +71,11 @@ pub(crate) struct TyrDrmDeviceData { pub(crate) gpu_info: GpuInfo, } -fn issue_soft_reset(dev: &Device, iomem: &Devres) -> Result { - let io = (*iomem).access(dev)?; - io.write_reg(GPU_COMMAND::reset(ResetMode::SoftReset)); +fn issue_soft_reset(dev: &Device, iomem: &IoMem<'_>) -> Result { + iomem.write_reg(GPU_COMMAND::reset(ResetMode::SoftReset)); poll::read_poll_timeout( - || { - let io = (*iomem).access(dev)?; - Ok(io.read(GPU_IRQ_RAWSTAT)) - }, + || Ok(iomem.read(GPU_IRQ_RAWSTAT)), |status| status.reset_completed(), time::Delta::from_millis(1), time::Delta::from_millis(100), @@ -123,12 +116,12 @@ fn probe<'bound>( let sram_regulator = Regulator::::get(pdev.as_ref(), c"sram")?; let request = pdev.io_request_by_index(0).ok_or(ENODEV)?; - let iomem = Arc::new(request.iomap_sized::()?.into_devres()?, GFP_KERNEL)?; + let iomem = request.iomap_sized::()?; issue_soft_reset(pdev.as_ref(), &iomem)?; gpu::l2_power_on(pdev.as_ref(), &iomem)?; - let gpu_info = GpuInfo::new(pdev.as_ref(), &iomem)?; + let gpu_info = GpuInfo::new(&iomem)?; gpu_info.log(pdev.as_ref()); let pa_bits = MMU_FEATURES::from_raw(gpu_info.mmu_features) diff --git a/drivers/gpu/drm/tyr/gpu.rs b/drivers/gpu/drm/tyr/gpu.rs index 652556026f50..3acffefaf210 100644 --- a/drivers/gpu/drm/tyr/gpu.rs +++ b/drivers/gpu/drm/tyr/gpu.rs @@ -9,7 +9,6 @@ Bound, Device, // }, - devres::Devres, io::{ poll, register::Array, @@ -40,9 +39,7 @@ pub(crate) struct GpuInfo(pub(crate) uapi::drm_panthor_gpu_info); impl GpuInfo { - pub(crate) fn new(dev: &Device, iomem: &Devres) -> Result { - let io = (*iomem).access(dev)?; - + pub(crate) fn new(io: &IoMem<'_>) -> Result { Ok(Self(uapi::drm_panthor_gpu_info { gpu_id: io.read(GPU_ID).into_raw(), gpu_rev: io.read(REVIDR).into_raw(), @@ -163,15 +160,11 @@ struct GpuModels { }]; /// Powers on the l2 block. -pub(crate) fn l2_power_on(dev: &Device, iomem: &Devres) -> Result { - let io = (*iomem).access(dev)?; +pub(crate) fn l2_power_on(dev: &Device, io: &IoMem<'_>) -> Result { io.write_reg(L2_PWRON_LO::zeroed().with_const_request::<1>()); poll::read_poll_timeout( - || { - let io = (*iomem).access(dev)?; - Ok(io.read(L2_READY_LO)) - }, + || Ok(io.read(L2_READY_LO)), |status| status.ready() == 1, Delta::from_millis(1), Delta::from_millis(100), -- 2.54.0